media: mc: delete redundant code in __media_device_unregister_entity
Subsystems (2)
PATCH 1/1 media: mc: delete redundant code in __media_device_unregister_entity
media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to set it again.
--- drivers/media/mc/mc-device.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/mc/mc-device.c +0 -1
@@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)/* invoke entity_notify callbacks to handle entity removal?? */ - entity->graph_obj.mdev =NULL ; }/**
Signature · 1 line
2.25.1
Hi Hangyu,
Thank you for the patch.
Quoted 4 lines · Hangyu Hua
media_gobj_destroyhas already set graph_obj.mdev to NULL. There is no need to set it again.Signed-off-by Hangyu Hua <[email protected]>
Quoted 16 lines
--- drivers/media/mc/mc-device.c | 1 - 1 file changed, 1 deletion(-)drivers/media/mc/mc-device.c +0
-1@@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)/* invoke entity_notify callbacks to handle entity removal?? */ - entity->graph_obj.mdev =NULL ; }/**
Signature · 3 lines
Regards, Laurent Pinchart
Sakari Ailus
maintainerQuoted 22 lines · Laurent Pinchart
Hi Hangyu,
Thank you for the patch.
Quoted 4 lines · Hangyu Hua
media_gobj_destroyhas already set graph_obj.mdev to NULL. There is no need to set it again.Signed-off-by Hangyu Hua <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Quoted 10 lines
--- drivers/media/mc/mc-device.c | 1 - 1 file changed, 1 deletion(-)drivers/media/mc/mc-device.c +0
-0@@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
Quoted 3 lines
drivers/media/mc/mc-device.c static void __media_device_unregister_entity(struct media_entity *entity) · line 608
Quoted 3 lines
drivers/media/mc/mc-device.c +0
-1/* invoke entity_notify callbacks to handle entity removal?? */ - entity->graph_obj.mdev =NULL ;
Removed the extra newline above, too. Applied.
Please run scripts/checkpatch.pl on the patches, too.
Quoted 8 lines
Quoted 3 lines
drivers/media/mc/mc-device.c +0
-0}/** Signature · 3 lines
Regards, Laurent Pinchart
Signature · 1 line
Sakari Ailus
Quoted 23 lines · Sakari Ailus
Quoted 22 lines · Laurent Pinchart
Hi Hangyu,
Thank you for the patch.
Quoted 4 lines · Hangyu Hua
media_gobj_destroyhas already set graph_obj.mdev to NULL. There is no need to set it again.Signed-off-by Hangyu Hua <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Quoted 10 lines
--- drivers/media/mc/mc-device.c | 1 - 1 file changed, 1 deletion(-)drivers/media/mc/mc-device.c +0
-0@@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
Quoted 7 lines
Quoted 3 lines
drivers/media/mc/mc-device.c static void __media_device_unregister_entity(struct media_entity *entity) · line 608
Quoted 3 lines
drivers/media/mc/mc-device.c +0
-1/* invoke entity_notify callbacks to handle entity removal?? */ - entity->graph_obj.mdev =NULL ;Removed the extra newline above, too. Applied.
Please run
scripts/checkpatch.plon the patches, too.
Thanks. I will make a v2 with this change.
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines
drivers/media/mc/mc-device.c +0
-0}/** Signature · 3 lines
Regards, Laurent Pinchart