drm/ati_pcigart.c SPDX License Identifier is added in form of a comment.
Subsystems (2)
PATCH 1/1 drm/ati_pcigart.c SPDX License Identifier is added in form of a comment.
SPDX License added Identifier in the first line
--- drivers/gpu/drm/ati_pcigart.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/ati_pcigart.c +1 -0
@@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ /** * \file ati_pcigart.c * ATI PCI GART support
Signature · 1 line
2.7.4
Quoted 6 lines · Bhanusree
SPDX License added Identifier in the first line
Signed-off-by Bhanusree<[email protected]>--- drivers/gpu/drm/ati_pcigart.c | 1 + 1 file changed, 1 insertion(+)
I can not take any kernel changes outside of drivers/staging/ for outreachy applications, sorry.
Also, you need to use your "full" name for the author info and signed-off-by.
thanks,
greg k-h
Quoted 1 line · Bhanusree
SPDX License added Identifier in the first line
Try to use the imperative in the subject line and the log message. Your subject line is actually confusing, since "is added" means that this is something that waas done in the past, so it is not clear what you are planning to do here. You can use git log to look at subject lines and commit logs that others have written.
You should also lok at what others have done in the subject line for indicating the location of the changes. This is something where every subsystem has its conventions, so you can't just guess something by yourself. Buf if you do git log --oneline and the name of the files, you will see that none of the existing patches on this file have constructed the subject line in the way you have done.
julia
Quoted 25 lines
Signed-off-by Bhanusree<[email protected]>--- drivers/gpu/drm/ati_pcigart.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/ati_pcigart.c +1
-1@@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ /** * \file ati_pcigart.c * ATI PCI GART support -- 2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/5bb62c85.1c69fb81.9de38.b242%40mx.google.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 13 lines · Julia Lawall
Quoted 1 line · Bhanusree
SPDX License added Identifier in the first line
Try to use the imperative in the subject line and the log message. Your subject line is actually confusing, since "is added" means that this is something that waas done in the past, so it is not clear what you are planning to do here. You can use git log to look at subject lines and commit logs that others have written.
Quoted 6 lines
You should also lok at what others have done in the subject line for indicating the location of the changes. This is something where every subsystem has its conventions, so you can't just guess something by yourself. Buf if you do git log --oneline and the name of the files, you will see that none of the existing patches on this file have constructed the subject line in the way you have done.
Thank you. I will follow your suggestions and make sure that I will not repeat them.