Skip to contentSkip to conversation

arch/sh/mm/consistent.c: Use dma_zalloc_coherent

PATCH In review Sabyasachi Gupta 3 participants 3 messages Oct 28, 2018 – Jan 21, 2019 SuperH

lore
Share & tools
lore

Sabyasachi Gupta

author
#0 lore raw

PATCH 1/1 arch/sh/mm/consistent.c: Use dma_zalloc_coherent

Replaced dma_alloc_coherent + memset with dma_zalloc_coherant

Signed-off-by Sabyasachi Gupta <[email protected]>
---
 arch/sh/mm/consistent.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/sh/mm/consistent.c +1 -2
index 792f361..fc8d235 100644
@@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
 	if (!memsize)
 		return 0;
 
-	buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
+	buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
 	if (!buf) {
 		pr_warning("%s: unable to allocate memory\n", name);
 		return -ENOMEM;
 	}
 
-	memset(buf, 0, memsize);
 
 	r->flags = IORESOURCE_MEM;
 	r->start = dma_handle;
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Sabyasachi Gupta

Replaced dma_alloc_coherent + memset with dma_zalloc_coherant

Signed-off-by Sabyasachi Gupta <[email protected]>
Acked-by Souptick Joarder <[email protected]>
Quoted 26 lines
---
 arch/sh/mm/consistent.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/sh/mm/consistent.c +1 -3
index 792f361..fc8d235 100644
@@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
        if (!memsize)
                return 0;
 
-       buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
+       buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
        if (!buf) {
                pr_warning("%s: unable to allocate memory\n", name);
                return -ENOMEM;
        }
 
-       memset(buf, 0, memsize);
 
        r->flags = IORESOURCE_MEM;
        r->start = dma_handle;
--

2.7.4

#2 lore raw
In reply to Sabyasachi Gupta

T24gMjgvMTAvMjAxOCAwNjo1OCwgU2FieWFzYWNoaSBHdXB0YSB3cm90ZToNCj4gUmVwbGFjZWQg ZG1hX2FsbG9jX2NvaGVyZW50ICsgbWVtc2V0IHdpdGggZG1hX3phbGxvY19jb2hlcmFudA0KDQpQ bGVhc2UgdGFrZSBhIGxvb2sgYXQgbGludXgtbmV4dCB3aGVyZSB3ZSd2ZSBhbHJlYWR5IHBoYXNl ZCBvdXQNCmRtYV96YWxsb2NfY29oZXJlbnQoKS4gVGhlIG1lbXNldCgpIHNob3VsZCBzdGlsbCBi ZSByZWR1bmRhbnQgYW5kIHdvcnRoDQpjbGVhbmluZyB1cCwgdGhvdWdoLg0KDQpUaGFua3MsDQpS b2Jpbi4NCg0KPiBTaWduZWQtb2ZmLWJ5OiBTYWJ5YXNhY2hpIEd1cHRhIDxzYWJ5YXNhY2hpLmxp bnV4QGdtYWlsLmNvbT4NCj4gLS0tDQo+ICAgYXJjaC9zaC9tbS9jb25zaXN0ZW50LmMgfCAzICst LQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlvbnMoLSkNCj4N Cj4gZGlmZiAtLWdpdCBhL2FyY2gvc2gvbW0vY29uc2lzdGVudC5jIGIvYXJjaC9zaC9tbS9jb25z aXN0ZW50LmMNCj4gaW5kZXggNzkyZjM2MS4uZmM4ZDIzNSAxMDA2NDQNCj4gLS0tIGEvYXJjaC9z aC9tbS9jb25zaXN0ZW50LmMNCj4gKysrIGIvYXJjaC9zaC9tbS9jb25zaXN0ZW50LmMNCj4gQEAg LTUyLDEzICs1MiwxMiBAQCBpbnQgX19pbml0IHBsYXRmb3JtX3Jlc291cmNlX3NldHVwX21lbW9y eShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LA0KPiAgIGlmICghbWVtc2l6ZSkNCj4gICBy ZXR1cm4gMDsNCj4NCj4gLWJ1ZiA9IGRtYV9hbGxvY19jb2hlcmVudCgmcGRldi0+ZGV2LCBtZW1z aXplLCAmZG1hX2hhbmRsZSwgR0ZQX0tFUk5FTCk7DQo+ICtidWYgPSBkbWFfemFsbG9jX2NvaGVy ZW50KCZwZGV2LT5kZXYsIG1lbXNpemUsICZkbWFfaGFuZGxlLCBHRlBfS0VSTkVMKTsNCj4gICBp ZiAoIWJ1Zikgew0KPiAgIHByX3dhcm5pbmcoIiVzOiB1bmFibGUgdG8gYWxsb2NhdGUgbWVtb3J5 XG4iLCBuYW1lKTsNCj4gICByZXR1cm4gLUVOT01FTTsNCj4gICB9DQo+DQo+IC1tZW1zZXQoYnVm LCAwLCBtZW1zaXplKTsNCj4NCj4gICByLT5mbGFncyA9IElPUkVTT1VSQ0VfTUVNOw0KPiAgIHIt PnN0YXJ0ID0gZG1hX2hhbmRsZTsNCj4NCklNUE9SVEFOVCBOT1RJQ0U6IFRoZSBjb250ZW50cyBv ZiB0aGlzIGVtYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgYXJlIGNvbmZpZGVudGlhbCBhbmQgbWF5 IGFsc28gYmUgcHJpdmlsZWdlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVu dCwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGFuZCBkbyBub3QgZGlzY2xv c2UgdGhlIGNvbnRlbnRzIHRvIGFueSBvdGhlciBwZXJzb24sIHVzZSBpdCBmb3IgYW55IHB1cnBv c2UsIG9yIHN0b3JlIG9yIGNvcHkgdGhlIGluZm9ybWF0aW9uIGluIGFueSBtZWRpdW0uIFRoYW5r IHlvdS4NCg=