Skip to contentSkip to conversation

drivers/scsi/fnic/fnic_trace.c: Use vzalloc

PATCH Applied Sabyasachi Gupta 3 participants 5 messages Nov 14, 2018 – Dec 8, 2018

Subsystems (2)
SCSI Cisco FCoE HBA driver
lore
Share & tools
lore

Sabyasachi Gupta

author
#0 lore raw

PATCH v2 1/1 drivers/scsi/fnic/fnic_trace.c: Use vzalloc

Replaced vmalloc + memset with vzalloc

Signed-off-by Sabyasachi Gupta <[email protected]>

---
v2: Removed additional braces

 drivers/scsi/fnic/fnic_trace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/fnic/fnic_trace.c +1 -2
index 8271785..bf0fd2a 100644
@@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
 	fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
 					  FNIC_ENTRY_SIZE_BYTES;
 
-	fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
+	fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
 	if (!fnic_trace_buf_p) {
 		printk(KERN_ERR PFX "Failed to allocate memory "
 				  "for fnic_trace_buf_p\n");
 		err = -ENOMEM;
 		goto err_fnic_trace_buf_init;
 	}
-	memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
 
 	fnic_trace_entries.page_offset =
 		vmalloc(array_size(fnic_max_trace_entries,
Signature · 1 line
2.7.4
author
#1 lore raw
Quoted 4 lines · Sabyasachi Gupta

Replaced vmalloc + memset with vzalloc

Signed-off-by Sabyasachi Gupta <[email protected]>

Any comment on this patch?

Quoted 29 lines

---
v2: Removed additional braces

 drivers/scsi/fnic/fnic_trace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/fnic/fnic_trace.c +1 -3
index 8271785..bf0fd2a 100644
@@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
        fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
                                          FNIC_ENTRY_SIZE_BYTES;
 
-       fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
+       fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
        if (!fnic_trace_buf_p) {
                printk(KERN_ERR PFX "Failed to allocate memory "
                                  "for fnic_trace_buf_p\n");
                err = -ENOMEM;
                goto err_fnic_trace_buf_init;
        }
-       memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
 
        fnic_trace_entries.page_offset =
                vmalloc(array_size(fnic_max_trace_entries,
--

2.7.4

author
#2 lore raw
Quoted 9 lines · Sabyasachi Gupta
Quoted 4 lines · Sabyasachi Gupta

Replaced vmalloc + memset with vzalloc

Signed-off-by Sabyasachi Gupta <[email protected]>

Any comment on this patch?

Any comment on this patch?

Quoted 30 lines
Quoted 30 lines

---
v2: Removed additional braces

 drivers/scsi/fnic/fnic_trace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/fnic/fnic_trace.c +1 -3
index 8271785..bf0fd2a 100644
@@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
        fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
                                          FNIC_ENTRY_SIZE_BYTES;
 
-       fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
+       fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
        if (!fnic_trace_buf_p) {
                printk(KERN_ERR PFX "Failed to allocate memory "
                                  "for fnic_trace_buf_p\n");
                err = -ENOMEM;
                goto err_fnic_trace_buf_init;
        }
-       memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
 
        fnic_trace_entries.page_offset =
                vmalloc(array_size(fnic_max_trace_entries,
--

2.7.4

maintainer Acked-by
#3 lore raw

Looks good. Apologize for the delay in acknowledging the patch.

Acked-by Sesidhar Baddela <[email protected]>

On 12/4/18, 8:37 PM, "Sabyasachi Gupta" <[email protected]> wrote:

    On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
    <[email protected]> wrote:
    >
    > On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
    > <[email protected]> wrote:
    > >
    > > Replaced vmalloc + memset with vzalloc
    > >
    > > Signed-off-by: Sabyasachi Gupta <[email protected]>
    >
    > Any comment on this patch?
    
    Any comment on this patch?
    
    >
    > > ---
    > > v2: Removed additional braces
    > >
    > >  drivers/scsi/fnic/fnic_trace.c | 3 +--
    > >  1 file changed, 1 insertion(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
    > > index 8271785..bf0fd2a 100644
    > > --- a/drivers/scsi/fnic/fnic_trace.c
    > > +++ b/drivers/scsi/fnic/fnic_trace.c
    > > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
    > >         fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
    > >                                           FNIC_ENTRY_SIZE_BYTES;
    > >
    > > -       fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
    > > +       fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
    > >         if (!fnic_trace_buf_p) {
    > >                 printk(KERN_ERR PFX "Failed to allocate memory "
    > >                                   "for fnic_trace_buf_p\n");
    > >                 err = -ENOMEM;
    > >                 goto err_fnic_trace_buf_init;
    > >         }
    > > -       memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
    > >
    > >         fnic_trace_entries.page_offset =
    > >                 vmalloc(array_size(fnic_max_trace_entries,
    > > --
    > > 2.7.4
    > >