mmc: mmc_test: fix missing assignment of 'file' when register debugfs file
PATCH 1/1 mmc: mmc_test: fix missing assignment of 'file' when register debugfs file
From: Ye Bin <[email protected]>
Now, 'file' is always NULL. obviously, 'file' is used to store return value of 'debugfs_create_file()'.
Fixes a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
Signed-off-by Ye Bin <[email protected]>
--- drivers/mmc/core/mmc_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/core/mmc_test.c +2 -1
@@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,struct mmc_test_dbgfs_file *df;if (card->debugfs_root) -debugfs_create_file (name, mode, card->debugfs_root, card, fops); + file =debugfs_create_file (name, mode, card->debugfs_root, + card, fops); df =kmalloc (sizeof (*df),GFP_KERNEL );if (!df) {
Signature · 1 line
2.31.1
Quoted 4 lines · Ye Bin
From: Ye Bin <[email protected]>
Now, 'file' is always NULL. obviously, 'file' is used to store return value of '
debugfs_create_file()'.
'file' is used to remove debugfs files when the mmc_test module is removed.
Quoted 3 lines
Fixes a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")Signed-off-by Ye Bin <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 18 lines
--- drivers/mmc/core/mmc_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/core/mmc_test.c +2
-1@@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,struct mmc_test_dbgfs_file *df;if (card->debugfs_root) -debugfs_create_file (name, mode, card->debugfs_root, card, fops); + file =debugfs_create_file (name, mode, card->debugfs_root, + card, fops); df =kmalloc (sizeof (*df),GFP_KERNEL );if (!df) {
Quoted 8 lines · Ye Bin
From: Ye Bin <[email protected]>
Now, 'file' is always NULL. obviously, 'file' is used to store return value of '
debugfs_create_file()'.Fixes a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")Signed-off-by Ye Bin <[email protected]>
Applied for fixes, by amending the commit message and by adding a stable tag, thanks!
Kind regards
Uffe
Quoted 21 lines
--- drivers/mmc/core/mmc_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/core/mmc_test.c +2
-2@@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,struct mmc_test_dbgfs_file *df;if (card->debugfs_root) -debugfs_create_file (name, mode, card->debugfs_root, card, fops); + file =debugfs_create_file (name, mode, card->debugfs_root, + card, fops); df =kmalloc (sizeof (*df),GFP_KERNEL );if (!df) { --2.31.1