drivers/usb/storage/sddr55.c: Remove duplicate header
Subsystems (2)
PATCH 1/1 drivers/usb/storage/sddr55.c: Remove duplicate header
Remove unusual_sddr55.h which is included more than once
--- drivers/usb/storage/sddr55.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/storage/sddr55.c +0 -1
@@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids); }static struct us_unusual_dev sddr55_unusual_dev_list[] = { -# include "unusual_sddr55.h" { }/* Terminating entry */ };
Greg KH
maintainerQuoted 12 lines · Sabyasachi Gupta
Remove
unusual_sddr55.hwhich is included more than onceSigned-off-by Sabyasachi Gupta <[email protected]>--- drivers/usb/storage/sddr55.c | 1 - 1 file changed, 1 deletion(-)drivers/usb/storage/sddr55.c +0
-0
drivers/usb/storage/sddr55.c MODULE_DEVICE_TABLE(usb, sddr55_usb_ids); · line 66
Quoted 6 lines
drivers/usb/storage/sddr55.c +0
-1@@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids); }static struct us_unusual_dev sddr55_unusual_dev_list[] = { -# include "unusual_sddr55.h" { }/* Terminating entry */ };
As Oliver said on the other patch, this breaks the code. Please do not blindly make changes without understanding what the code does.
thanks,
greg k-h
Quoted 15 lines · Greg KH
Quoted 14 lines · Sabyasachi Gupta
Remove
unusual_sddr55.hwhich is included more than onceSigned-off-by Sabyasachi Gupta <[email protected]>--- drivers/usb/storage/sddr55.c | 1 - 1 file changed, 1 deletion(-)drivers/usb/storage/sddr55.c +0
-0@@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids); }
Quoted 7 lines
drivers/usb/storage/sddr55.c MODULE_DEVICE_TABLE(usb, sddr55_usb_ids); · line 66
Quoted 4 lines
drivers/usb/storage/sddr55.c +0
-1static struct us_unusual_dev sddr55_unusual_dev_list[] = { -# include "unusual_sddr55.h" { }/* Terminating entry */ };As Oliver said on the other patch, this breaks the code. Please do not blindly make changes without understanding what the code does.
Maybe this should be explained. The file that is included does have a name ending in .h. But it is not simply declarations, for which newer trendy languages would use a a statement like ¨import".
"unusual_sddr55.h" is a list of devices. This list is used in multiple places. And it needs to be identical in all those places. Hence it is included. These are true includes. There is nothing wrong with that code.
Our complaint is not that your fix is wrong, but there is nothing wrong with the code as is. Including this list is the good thing to do. Your wish to clean up the kernel is appreciated. But please find a place that actually needs to be cleaned up.
Regards
Oliver