clk: Fix error checking of dev_read_addr_ptr
Subsystems (3)
PATCH 1/1 clk: Fix error checking of dev_read_addr_ptr
dev_read_addr_ptr returns NULL on error, not FDT_ADDR_T_NONE.
--- drivers/clk/imx/clk-imx6q.c | 2 +- drivers/clk/imx/clk-imx8mm.c | 2 +- drivers/clk/imx/clk-imx8mn.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/clk/imx/clk-imx6q.c +1 -1
@@ -115,7 +115,7 @@ static int imx6q_clk_probe(struct udevice *dev)/* CCM clocks */ base =dev_read_addr_ptr (dev); -if (base == (void *)FDT_ADDR_T_NONE ) +if (!base)return -EINVAL ; clk_dm(IMX6QDL_CLK_USDHC1_SEL,
drivers/clk/imx/clk-imx8mm.c +1 -1
@@ -323,7 +323,7 @@ static int imx8mm_clk_probe(struct udevice *dev) imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1)); base =dev_read_addr_ptr (dev); -if (base == (void *)FDT_ADDR_T_NONE ) +if (!base)return -EINVAL ; clk_dm(IMX8MM_CLK_A53_SRC,
drivers/clk/imx/clk-imx8mn.c +1 -1
@@ -293,7 +293,7 @@ static int imx8mn_clk_probe(struct udevice *dev) imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1)); base =dev_read_addr_ptr (dev); -if (base == (void *)FDT_ADDR_T_NONE ) +if (!base)return -EINVAL ; clk_dm(IMX8MN_CLK_A53_SRC,
Signature · 1 line
2.24.1
PATCH 1/1 clk: Fix error checking of dev_read_addr_ptr
Quoted 3 lines · Sean Anderson
dev_read_addr_ptrreturns NULL on error, notFDT_ADDR_T_NONE.Signed-off-by Sean Anderson <[email protected]>
*bump*
Lukasz do you have any comments?
PATCH 1/1 clk: Fix error checking of dev_read_addr_ptr
Hi Sean,
Quoted 8 lines · Sean Anderson
Quoted 3 lines
dev_read_addr_ptrreturns NULL on error, notFDT_ADDR_T_NONE.Signed-off-by Sean Anderson <[email protected]>*bump*
Lukasz do you have any comments?
No, I do not have any comments.
I will prepare PR by end of this week. Thanks for the fix.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200116/86633286/attachment.sig>