Skip to contentSkip to conversation

amdgpu drm-fixes-4.14

GIT PULL Alex Deucher 8 participants 10 messages Oct 12, 2017 – Oct 19, 2017 5 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hi Dave,

One memory management regression fix.

The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:

Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): 1507823900-2785-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 12 lines · Alex Deucher

Hi Dave,

One memory management regression fix.

The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:

Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

Quoted 7 lines

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): dfb5a003-f9a1-24f4-90aa-e9f43fdb4e1c-otUistvHUpPR7s880joybQ@public.gmane.org

#4 lore raw
Quoted 34 lines

-----Original Message-----
From: Michel Dänzer [mailto:[email protected]]
Sent: Thursday, October 12, 2017 12:21 PM
To: Alex Deucher
Cc: [email protected]; [email protected]; [email protected]; Deucher, Alexander
Subject: Re: [pull] amdgpu drm-fixes-4.14

Quoted 5 lines · Alex Deucher

Hi Dave,

One memory management regression fix.

The following changes since commit

545036a9944e9d6e50fed4ca03117147c880ff71:

Quoted 2 lines

Merge tag 'drm-misc-fixes-2017-10-11' of

git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

Quoted 6 lines

are available in the git repository at:

git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to

27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

Quoted 2 lines

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12

10:34:42 -0400)

Quoted 4 lines

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Quoted 5 lines

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

Sorting that out seemed like more effort, so I opted to just send this out. Once we get that fixed up, I can send another fixes pull.

Alex

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 17 lines · Alex Deucher
Quoted 16 lines

Hi Dave,

One memory management regression fix.

The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:

   Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

   git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

   drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)
Quoted 8 lines
Quoted 3 lines

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Christian.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 996c1073-5832-0f3c-91e9-67fac0be6071-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#7 lore raw
Quoted 35 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 27 lines · Alex Deucher
Quoted 16 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

   Merge tag 'drm-misc-fixes-2017-10-11' of

git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

   git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
Quoted 8 lines

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Quoted 5 lines

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

Quoted 3 lines

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down the road when the revert gets merged into drm-next.

Alex
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#8 lore raw
Quoted 36 lines · Alex Deucher
Quoted 34 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 31 lines · Alex Deucher
Quoted 16 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

   Merge tag 'drm-misc-fixes-2017-10-11' of

git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

   git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
Quoted 8 lines

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

Quoted 7 lines
Quoted 3 lines

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down the road when the revert gets merged into drm-next.

That's basically why I asked which way to go. However, Monk just reported a potential regression in one of Nicolai's changes, so reverting seems safer for 4.14.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#9 lore raw

Am 13.10.2017 um 09:41 schrieb Michel Dänzer:

Quoted 36 lines · Alex Deucher
Quoted 35 lines
Quoted 33 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 21 lines · Alex Deucher
Quoted 20 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

    Merge tag 'drm-misc-fixes-2017-10-11' of

git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
10:34:42 -0400)

Quoted 8 lines
Quoted 3 lines

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

The revert is probably easier to handle at this point.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down the road when the revert gets merged into drm-next.

That's basically why I asked which way to go. However, Monk just reported a potential regression in one of Nicolai's changes, so reverting seems safer for 4.14.

I agree that reverting the original offending patch is probably the better approach.

Regards,
Christian.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): b4e9aec8-e69c-e5b2-15d1-c75d9c7dc0f3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#11 lore raw
Quoted 43 lines · Christian König

Am 13.10.2017 um 09:41 schrieb Michel Dänzer:

Quoted 42 lines · Alex Deucher
Quoted 41 lines
Quoted 33 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 25 lines · Alex Deucher
Quoted 18 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

    Merge tag 'drm-misc-fixes-2017-10-11' of
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to
27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

Quoted 6 lines

    drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
        drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Quoted 6 lines

Thanks Alex, but there's another piglit hang regression in 4.14, caused
by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to 4.14, or the former needs to be reverted from it.

Quoted 3 lines

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down the road when the revert gets merged into drm-next.

Quoted 6 lines
Quoted 3 lines

That's basically why I asked which way to go. However, Monk just reported a potential regression in one of Nicolai's changes, so reverting seems safer for 4.14.

I agree that reverting the original offending patch is probably the better approach.

Alex, are you planning to send a pull request for the revert? Let me know if there's anything I can do to help.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#12 lore raw
Quoted 59 lines

-----Original Message-----
From: Michel Dänzer [mailto:[email protected]]
Sent: Wednesday, October 18, 2017 12:06 PM
To: Koenig, Christian; Alex Deucher
Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI developers
Subject: Re: [pull] amdgpu drm-fixes-4.14

Quoted 15 lines · Christian König

Am 13.10.2017 um 09:41 schrieb Michel Dänzer:

Quoted 14 lines · Alex Deucher
Quoted 13 lines
Quoted 11 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 10 lines · Alex Deucher
Quoted 9 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

    Merge tag 'drm-misc-fixes-2017-10-11' of
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-

10-12

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

10:38:09 +1000)

are available in the git repository at:

    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to
27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

    drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-

12

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
        drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused
by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to

4.14,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

or the former needs to be reverted from it.

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down

the

Quoted 5 lines
Quoted 4 lines
Quoted 1 line

road when the revert gets merged into drm-next.

That's basically why I asked which way to go. However, Monk just reported a potential regression in one of Nicolai's changes, so reverting seems safer for 4.14.

Quoted 5 lines
Quoted 2 lines

I agree that reverting the original offending patch is probably the better approach.

Alex, are you planning to send a pull request for the revert? Let me know if there's anything I can do to help.

Yeah, I'll send it out shortly.

Alex

Quoted 5 lines

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB165211DF4F5CB3B9DF33464FF74D0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#14 lore raw

Am 18.10.2017 um 18:58 schrieb Deucher, Alexander:

Quoted 57 lines
Quoted 57 lines

-----Original Message-----
From: Michel Dänzer [mailto:[email protected]]
Sent: Wednesday, October 18, 2017 12:06 PM
To: Koenig, Christian; Alex Deucher
Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI developers
Subject: Re: [pull] amdgpu drm-fixes-4.14

Quoted 15 lines · Christian König

Am 13.10.2017 um 09:41 schrieb Michel Dänzer:

Quoted 14 lines · Alex Deucher
Quoted 13 lines
Quoted 11 lines · Christian König

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:

Quoted 10 lines · Alex Deucher
Quoted 9 lines

Hi Dave,

One memory management regression fix.

The following changes since commit
545036a9944e9d6e50fed4ca03117147c880ff71:

     Merge tag 'drm-misc-fixes-2017-10-11' of

git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-

10-12

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

10:38:09 +1000)

are available in the git repository at:

     git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to
27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-

12

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused
by commit 6af0883ed977 "drm/amdgpu: discard commands of killed processes", fixed by five commits 6b37d03280a4..318d85de9c20 in amd-staging-drm-next. Either the latter need to be backported to

4.14,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

or the former needs to be reverted from it.

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same amount of code and we don't have to worry about any problems down

the

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

road when the revert gets merged into drm-next.

That's basically why I asked which way to go. However, Monk just reported a potential regression in one of Nicolai's changes, so reverting seems safer for 4.14.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

I agree that reverting the original offending patch is probably the better approach.

Alex, are you planning to send a pull request for the revert? Let me know if there's anything I can do to help.

Yeah, I'll send it out shortly.

Sorry for the delay. I wanted to send a revert on Monday, but somehow forgot it over the weekend. Thanks for taking care of this Alex.

Christian.

Quoted 11 lines

Alex

Quoted 4 lines

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx