nfs: don't report STATX_BTIME in ->getattr
Subsystems (3)
Jeff Layton
maintainerPATCH 1/1 nfs: don't report STATX_BTIME in ->getattr
NFS doesn't properly support reporting the btime in getattr (yet), but 61a968b4f05e mistakenly added it to the request_mask. This causes statx for STATX_BTIME to report a zeroed out btime instead of properly clearing the flag.
Cc [email protected] # v6.3+
Fixes 61a968b4f05e ("nfs: report the inode version in getattr if requested")
Signed-off-by Jeff Layton <[email protected]>
--- fs/nfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/inode.c +1 -1
@@ -846,7 +846,7 @@ int nfs_getattr(struct mnt_idmap *idmap, const struct path *path, request_mask &=STATX_TYPE |STATX_MODE |STATX_NLINK |STATX_UID |STATX_GID |STATX_ATIME |STATX_MTIME |STATX_CTIME | -STATX_INO |STATX_SIZE |STATX_BLOCKS |STATX_BTIME | +STATX_INO |STATX_SIZE |STATX_BLOCKS |STATX_CHANGE_COOKIE ;if ((query_flags &AT_STATX_DONT_SYNC ) && !force_sync) {
Signature · 1 line
2.40.1
Jeff Layton
maintainerQuoted 8 lines · Jeff Layton
NFS doesn't properly support reporting the btime in getattr (yet), but
61a968b4f05emistakenly added it to therequest_mask. This causes statx forSTATX_BTIMEto report a zeroed out btime instead of properly clearing the flag.Cc [email protected] # v6.3+Fixes 61a968b4f05e ("nfs: report the inode version in getattr if requested")Signed-off-by Jeff Layton <[email protected]>
Trond/Anna,
If this patch looks OK, could you also add these tags to the commit log?
I forgot to tack them on before sending.
Thanks!
Quoted 17 lines
--- fs/nfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfs/inode.c +1
-1@@ -846,7 +846,7 @@ int nfs_getattr(struct mnt_idmap *idmap, const struct path *path, request_mask &=STATX_TYPE |STATX_MODE |STATX_NLINK |STATX_UID |STATX_GID |STATX_ATIME |STATX_MTIME |STATX_CTIME | -STATX_INO |STATX_SIZE |STATX_BLOCKS |STATX_BTIME | +STATX_INO |STATX_SIZE |STATX_BLOCKS |STATX_CHANGE_COOKIE ;if ((query_flags &AT_STATX_DONT_SYNC ) && !force_sync) {
Signature · 1 line
Jeff Layton <[email protected]>