Skip to contentSkip to conversation

arm64: dts: qcom: msm8996: Add CPU cooling suppor,t

PATCH Guilherme G. Piccoli 1 participant 2 messages Sep 27, 2021 Arm Qualcomm mailing list

lore
Share & tools
lore

Guilherme G. Piccoli

author Tested-by
#0 lore raw

Hi Yassine, thanks for the patch! I was doing some experiments with a dragonboard 820-based board, and without your patch, a CPU benchmark can quickly cause overheating - throttling mechanism doesn't start and we get a FW reset to a bad state (likely a HW protection mechanism).

I noticed that a similar patch including cooling maps is present in Linaro's qcom tree [0], and it was submitted upstream [1], but there was a re-submission [2] by Konrad that was merged and dropped the thermals part. Based on some threads I read, it seems a FW lockup was detected with the complete patch?

I'm not sure, so I'm looping Konrad / Loic / Bjorn here, to understand better what made this portion of the patch to be dropped. Anyway, I think worth to mention this in your commit message Yassine, including perhaps a fixes tag like:

Fixes 90173a954a22 ("arm64: dts: qcom: msm8996: Add CPU opps").

Also, I'm not sure why there was no response here or why it wasn't merged, but if it helps, please have my:

Thanks,

Guilherme

[0]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=release/qcomlt-4.14&id=2274c48c671

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

[2]
https://lore.kernel.org/linux-arm-msm/[email protected]/

#1 lore raw
Quoted 29 lines · Guilherme G. Piccoli

Hi Yassine, thanks for the patch! I was doing some experiments with a dragonboard 820-based board, and without your patch, a CPU benchmark can quickly cause overheating - throttling mechanism doesn't start and we get a FW reset to a bad state (likely a HW protection mechanism).

I noticed that a similar patch including cooling maps is present in Linaro's qcom tree [0], and it was submitted upstream [1], but there was a re-submission [2] by Konrad that was merged and dropped the thermals part. Based on some threads I read, it seems a FW lockup was detected with the complete patch?

I'm not sure, so I'm looping Konrad / Loic / Bjorn here, to understand better what made this portion of the patch to be dropped. Anyway, I think worth to mention this in your commit message Yassine, including perhaps a fixes tag like:

Fixes 90173a954a22 ("arm64: dts: qcom: msm8996: Add CPU opps").

Also, I'm not sure why there was no response here or why it wasn't merged, but if it helps, please have my:

Thanks,

Guilherme

Quoted 9 lines

[0]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=release/qcomlt-4.14&id=2274c48c671

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

[2]
https://lore.kernel.org/linux-arm-msm/[email protected]/

Unfortunately, (likely) due to a typo in the Subject field, this wasn't threaded correctly. So, the original message I was responding is:

https://lore.kernel.org/linux-arm-msm/[email protected]/

I'm sorry about the confusion with the mail thread! Cheers,

Guilherme