Skip to contentSkip to conversation

build: deal with future GNU ld warnings

PATCH In review Jan Beulich 3 participants 10 messages May 6, 2022 – May 16, 2022

lore
Share & tools
lore
#0 lore raw

cover build: deal with future GNU ld warnings

1: suppress future GNU ld warning about RWX load segments 2: silence future GNU ld warning about executable stacks

Jan

#1 lore raw

PATCH 1/2 build: suppress future GNU ld warning about RWX load segments

We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort.

xen/Makefile +2 -0
@@ -397,6 +397,8 @@ endif
 
 AFLAGS += -D__ASSEMBLY__
 
+LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments
+
 CFLAGS += $(CFLAGS-y)
 # allow extra CFLAGS externally via EXTRA_CFLAGS_XEN_CORE
 CFLAGS += $(EXTRA_CFLAGS_XEN_CORE)
#2 lore raw

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

Hi,

You say future, has this option been merged or still in discussion on the ML?

Quoted 3 lines · Jan Beulich

We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort.

Is this a preventive commit, or you have seen it in action?

Cheers,

Signature · 1 line
Julien Grall
#3 lore raw

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

Quoted 2 lines · Julien Grall

You say future, has this option been merged or still in discussion on the ML?

"future" as in "no released version yet". The change is present on the binutils master branch.

Quoted 6 lines · Jan Beulich
Quoted 3 lines

We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort.

Is this a preventive commit, or you have seen it in action?

I've seen it in action.

Jan

#4 lore raw

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

Quoted 5 lines · Jan Beulich
Quoted 2 lines · Julien Grall

You say future, has this option been merged or still in discussion on the ML?

"future" as in "no released version yet". The change is present on the binutils master branch.

In which case, I'd recommend saying "build: suppress GNU ld warning about RWX load segments" in the subject, and in the commit message saying "warning present in master, anticipated to be included in release 2.$whatever".

That, combined with the date, is enough information for people to track things down even if upstream binutils change their versioning scheme.

~Andrew

#5 lore raw

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

Quoted 6 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich
Quoted 2 lines · Julien Grall

You say future, has this option been merged or still in discussion on the ML?

"future" as in "no released version yet". The change is present on the binutils master branch.

Quoted 7 lines

In which case, I'd recommend saying "build: suppress GNU ld warning about RWX load segments" in the subject, and in the commit message saying "warning present in master, anticipated to be included in release 2.$whatever".

That, combined with the date, is enough information for people to track things down even if upstream binutils change their versioning scheme.

One other thing.  With something to ^ effect, both patches Acked-by:
Andrew Cooper <[email protected]>

~Andrew

Acked-by
#6 lore raw

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

In reply to Jan Beulich

Hi Jan,

Quoted 6 lines · Jan Beulich
Quoted 2 lines · Julien Grall

You say future, has this option been merged or still in discussion on the ML?

"future" as in "no released version yet". The change is present on the binutils master branch.

Thanks for the clarification. In which case, can you update the commit message like Andrew suggested. For both:

Cheers,

Signature · 1 line
Julien Grall
#7 lore raw

PATCH 2/2 build: silence future GNU ld warning about executable stacks

In reply to Jan Beulich

While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves.

xen/Makefile +2 -0
@@ -397,6 +397,8 @@ endif
 
 AFLAGS += -D__ASSEMBLY__
 
+$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+
 LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments
 
 CFLAGS += $(CFLAGS-y)
#8 lore raw

Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks

Hi,

You say future, has this option been merged or still in discussion on the ML?

Quoted 2 lines · Jan Beulich

While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves.

Is this a preventive measure, or you have seen it in action?

Cheers,

Signature · 1 line
Julien Grall
#9 lore raw

Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks

Quoted 8 lines · Julien Grall

You say future, has this option been merged or still in discussion on the ML?

Quoted 2 lines · Jan Beulich

While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves.

Is this a preventive measure, or you have seen it in action?

Same answers as for patch 1.

Jan