Skip to contentSkip to conversation

drm/amd/pm: open brace '{' following struct go on the same line

PATCH Applied [email protected] 2 participants 2 messages Jul 24, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/amd/pm: open brace '{' following struct go on the same line

ERROR: open brace '{' following struct go on the same line

---
 .../amd/pm/swsmu/inc/smu_v13_0_7_pptable.h    | 21 +++++++------------
 1 file changed, 7 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +0 -0
index eadbe0149cae..eb694f9f556d 100644
@@ -41,8 +41,7 @@
 #define SMU_13_0_7_PP_OVERDRIVE_VERSION 0x83        // OverDrive 8 

Table Version 0.2
#define SMU_13_0_7_PP_POWERSAVINGCLOCK_VERSION 0x01 // Power Saving
Clock Table Version 1.00

-enum SMU_13_0_7_ODFEATURE_CAP
-{

+enum SMU_13_0_7_ODFEATURE_CAP {
     SMU_13_0_7_ODCAP_GFXCLK_LIMITS = 0,
     SMU_13_0_7_ODCAP_UCLK_LIMITS,
     SMU_13_0_7_ODCAP_POWER_LIMIT,
@@ -62,8 +61,7 @@ enum SMU_13_0_7_ODFEATURE_CAP
     SMU_13_0_7_ODCAP_COUNT,

};

-enum SMU_13_0_7_ODFEATURE_ID
-{

+enum SMU_13_0_7_ODFEATURE_ID {
     SMU_13_0_7_ODFEATURE_GFXCLK_LIMITS           = 1 << 
SMU_13_0_7_ODCAP_GFXCLK_LIMITS,           //GFXCLK Limit feature
     SMU_13_0_7_ODFEATURE_UCLK_LIMITS             = 1 << 
SMU_13_0_7_ODCAP_UCLK_LIMITS,             //UCLK Limit feature
     SMU_13_0_7_ODFEATURE_POWER_LIMIT             = 1 << 

SMU_13_0_7_ODCAP_POWER_LIMIT, //Power Limit feature
@@ -85,8 +83,7 @@ enum SMU_13_0_7_ODFEATURE_ID

#define SMU_13_0_7_MAX_ODFEATURE 32 //Maximum Number of OD Features

-enum SMU_13_0_7_ODSETTING_ID
-{

+enum SMU_13_0_7_ODSETTING_ID {
     SMU_13_0_7_ODSETTING_GFXCLKFMAX = 0,
     SMU_13_0_7_ODSETTING_GFXCLKFMIN,
     SMU_13_0_7_ODSETTING_UCLKFMIN,

@@ -123,8 +120,7 @@ enum SMU_13_0_7_ODSETTING_ID
};
#define SMU_13_0_7_MAX_ODSETTING 64 //Maximum Number of ODSettings

-enum SMU_13_0_7_PWRMODE_SETTING
-{

+enum SMU_13_0_7_PWRMODE_SETTING {
     SMU_13_0_7_PMSETTING_POWER_LIMIT_QUIET = 0,
     SMU_13_0_7_PMSETTING_POWER_LIMIT_BALANCE,
     SMU_13_0_7_PMSETTING_POWER_LIMIT_TURBO,

@@ -144,8 +140,7 @@ enum SMU_13_0_7_PWRMODE_SETTING
};
#define SMU_13_0_7_MAX_PMSETTING 32 //Maximum Number of PowerMode
Settings

-struct smu_13_0_7_overdrive_table
-{
+struct smu_13_0_7_overdrive_table {
uint8_t revision; //Revision =
SMU_13_0_7_PP_OVERDRIVE_VERSION
uint8_t reserve[3]; //Zero filled field
reserved for future use
uint32_t feature_count; //Total number of
supported features
@@ -156,8 +151,7 @@ struct smu_13_0_7_overdrive_table

     int16_t pm_setting[SMU_13_0_7_MAX_PMSETTING]; //Optimized power 

mode feature settings
};

-enum SMU_13_0_7_PPCLOCK_ID
-{

+enum SMU_13_0_7_PPCLOCK_ID {
     SMU_13_0_7_PPCLOCK_GFXCLK = 0,
     SMU_13_0_7_PPCLOCK_SOCCLK,
     SMU_13_0_7_PPCLOCK_UCLK,

@@ -175,8 +169,7 @@ enum SMU_13_0_7_PPCLOCK_ID
};
#define SMU_13_0_7_MAX_PPCLOCK 16 //Maximum Number of PP Clocks

-struct smu_13_0_7_powerplay_table
-{
+struct smu_13_0_7_powerplay_table {
struct atom_common_table_header header; //For PLUM_BONITO,
header.format_revision = 15, header.content_revision = 0
uint8_t table_revision; //For PLUM_BONITO,
table_revision = 2

     uint8_t padding;
Applied
#2 lore raw

Applied. Thanks!

Quoted 95 lines · On Mon, Jul 24, 2023 at 5:08 AM <[email protected]> wrote:

ERROR: open brace '{' following struct go on the same line

---
  .../amd/pm/swsmu/inc/smu_v13_0_7_pptable.h    | 21 +++++++------------
  1 file changed, 7 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +0 -0
index eadbe0149cae..eb694f9f556d 100644
@@ -41,8 +41,7 @@
  #define SMU_13_0_7_PP_OVERDRIVE_VERSION 0x83        // OverDrive 8

Table Version 0.2
#define SMU_13_0_7_PP_POWERSAVINGCLOCK_VERSION 0x01 // Power Saving
Clock Table Version 1.00

drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +2 -4
-enum SMU_13_0_7_ODFEATURE_CAP
-{
+enum SMU_13_0_7_ODFEATURE_CAP {
      SMU_13_0_7_ODCAP_GFXCLK_LIMITS = 0,
      SMU_13_0_7_ODCAP_UCLK_LIMITS,
      SMU_13_0_7_ODCAP_POWER_LIMIT,
@@ -62,8 +61,7 @@ enum SMU_13_0_7_ODFEATURE_CAP
      SMU_13_0_7_ODCAP_COUNT,
  };
 
-enum SMU_13_0_7_ODFEATURE_ID
-{
+enum SMU_13_0_7_ODFEATURE_ID {
      SMU_13_0_7_ODFEATURE_GFXCLK_LIMITS           = 1 <<

SMU_13_0_7_ODCAP_GFXCLK_LIMITS, //GFXCLK Limit feature

      SMU_13_0_7_ODFEATURE_UCLK_LIMITS             = 1 <<
SMU_13_0_7_ODCAP_UCLK_LIMITS,             //UCLK Limit feature
      SMU_13_0_7_ODFEATURE_POWER_LIMIT             = 1 <<

SMU_13_0_7_ODCAP_POWER_LIMIT, //Power Limit feature

drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +2 -4
@@ -85,8 +83,7 @@ enum SMU_13_0_7_ODFEATURE_ID
 
  #define SMU_13_0_7_MAX_ODFEATURE 32 //Maximum Number of OD Features
 
-enum SMU_13_0_7_ODSETTING_ID
-{
+enum SMU_13_0_7_ODSETTING_ID {
      SMU_13_0_7_ODSETTING_GFXCLKFMAX = 0,
      SMU_13_0_7_ODSETTING_GFXCLKFMIN,
      SMU_13_0_7_ODSETTING_UCLKFMIN,
@@ -123,8 +120,7 @@ enum SMU_13_0_7_ODSETTING_ID
  };
  #define SMU_13_0_7_MAX_ODSETTING 64 //Maximum Number of ODSettings
 
-enum SMU_13_0_7_PWRMODE_SETTING
-{
+enum SMU_13_0_7_PWRMODE_SETTING {
      SMU_13_0_7_PMSETTING_POWER_LIMIT_QUIET = 0,
      SMU_13_0_7_PMSETTING_POWER_LIMIT_BALANCE,
      SMU_13_0_7_PMSETTING_POWER_LIMIT_TURBO,
@@ -144,8 +140,7 @@ enum SMU_13_0_7_PWRMODE_SETTING
  };
  #define SMU_13_0_7_MAX_PMSETTING 32 //Maximum Number of PowerMode

Settings

drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +1 -2
-struct smu_13_0_7_overdrive_table
-{
+struct smu_13_0_7_overdrive_table {
      uint8_t revision;                             //Revision =

SMU_13_0_7_PP_OVERDRIVE_VERSION
uint8_t reserve[3]; //Zero filled field
reserved for future use
uint32_t feature_count; //Total number of
supported features

drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +0 -0
@@ -156,8 +151,7 @@ struct smu_13_0_7_overdrive_table
      int16_t pm_setting[SMU_13_0_7_MAX_PMSETTING]; //Optimized power

mode feature settings
};

drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0_7_pptable.h +2 -4
-enum SMU_13_0_7_PPCLOCK_ID
-{
+enum SMU_13_0_7_PPCLOCK_ID {
      SMU_13_0_7_PPCLOCK_GFXCLK = 0,
      SMU_13_0_7_PPCLOCK_SOCCLK,
      SMU_13_0_7_PPCLOCK_UCLK,
@@ -175,8 +169,7 @@ enum SMU_13_0_7_PPCLOCK_ID
  };
  #define SMU_13_0_7_MAX_PPCLOCK 16 //Maximum Number of PP Clocks
 
-struct smu_13_0_7_powerplay_table
-{
+struct smu_13_0_7_powerplay_table {
      struct atom_common_table_header header; //For PLUM_BONITO,

header.format_revision = 15, header.content_revision = 0
uint8_t table_revision; //For PLUM_BONITO,
table_revision = 2

      uint8_t padding;