reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
Subsystems (2)
PATCH 1/1 reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
The devm_regmap_field_alloc() function never returns NULL, it returns error pointers. Update the error checking to match.
Fixes 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/reset/reset-rzg2l-usbphy-ctrl.c +2 -2
@@ -158,8 +158,8 @@ static int rzg2l_usbphy_ctrl_pwrrdy_init(struct device *dev) field.msb =__fls (args[1 ]); pwrrdy =devm_regmap_field_alloc (dev, regmap, field); -if (!pwrrdy) -return -ENOMEM ; +if (IS_ERR (pwrrdy)) +return PTR_ERR (pwrrdy);rzg2l_usbphy_ctrl_set_pwrrdy (pwrrdy, true);
Signature · 1 line
2.51.0
Quoted 5 lines · Dan Carpenter
The
devm_regmap_field_alloc()function never returns NULL, it returns error pointers. Update the error checking to match.Fixes 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Claudiu Beznea <[email protected]>
Quoted 19 lines
--- drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/reset/reset-rzg2l-usbphy-ctrl.c +2
-2@@ -158,8 +158,8 @@ static int rzg2l_usbphy_ctrl_pwrrdy_init(struct device *dev) field.msb =__fls (args[1 ]); pwrrdy =devm_regmap_field_alloc (dev, regmap, field); -if (!pwrrdy) -return -ENOMEM ; +if (IS_ERR (pwrrdy)) +return PTR_ERR (pwrrdy);rzg2l_usbphy_ctrl_set_pwrrdy (pwrrdy, true);
Quoted 5 lines · Dan Carpenter
The
devm_regmap_field_alloc()function never returns NULL, it returns error pointers. Update the error checking to match.Fixes 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")Signed-off-by Dan Carpenter <[email protected]>
Applied to reset/next, thanks!
[1/1] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
https://git.pengutronix.de/cgit/pza/linux/commit/?id=ce2883a0339c
regards
Philipp