Revert "tests/migration: Reduce autoconverge initial bandwidth"
PATCH 1/1 Revert "tests/migration: Reduce autoconverge initial bandwidth"
This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/migration-test.c +1 -1
@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);
Signature · 1 line
MST
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.
Please also mention we can do this since 1de8e4c4dcf which allow marked the s390x job as "unstable" and allow it to fail.
But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +1 -0
@@ -507,6 +507,7 @@ jobs: - name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration
(see commit 6d1da867e65).
dist: bionic
compiler: clang
addons:
---
With the hunk amended (no need to mention 1de8e4c4d actually):
Quoted 21 lines
Signed-off-by Michael S. Tsirkin <[email protected]>--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);
Quoted 23 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +1
-0@@ -507,6 +507,7 @@ jobs: - name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration
Quoted 4 lines
(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:
Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here. Second, if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.
Thanks,
Thomas
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:
Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1 -1
@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration
(see commit 6d1da867e65).
arch: s390x
dist: bionic
addons:---
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.
Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Quoted 47 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1
-1@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
Quoted 4 lines
arch: s390x dist: bionic addons:---
OK - can yo submit this as a proper patch?
Quoted 7 lines
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Quoted 52 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1
-1@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).arch: s390x dist: bionic addons:---
Quoted 8 lines
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Was he? Citing his reply to the mail from your URL:
"Before we take the hammer to it, could you try reducing it's initial
bandwidth"
So all I can see is that he first wanted to try something different than disabling the test. And now, instead of using a small hammer to disable just this test, you now even use a very *big* hammer to disable *all* tests. That's just a very bad idea. Please don't.
Thomas
Philippe Mathieu-Daudé
Reviewed-byQuoted 64 lines · Thomas Huth
Quoted 52 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1
-1@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).arch: s390x dist: bionic addons:---
Quoted 8 lines
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Was he? Citing his reply to the mail from your URL:
Quoted 7 lines
"Before we take the hammer to it, could you try reducing it's initial
bandwidth"So all I can see is that he first wanted to try something different than disabling the test. And now, instead of using a small hammer to disable just this test, you now even use a very *big* hammer to disable *all* tests. That's just a very bad idea. Please don't.
You are right. I was being concerned about having CI working because the more red it stay, the less likely the community will worry about it, and I didn't want we loose interest in testing (or discredit its importance). I now understand without having CI gating, it is pointless to try to keep it green (at the cost of having all local testing running slower, it is worst if maintainers stop their local testing).
WRT this test I have no idea what it is doing, furthermore why it fails on s390x containers, so I sent a simple patch to fix the CI, but failed to foreseen its negative effect on the rest of the developers.
Thanks Michael for fixing my mess with your patch:
Regards,
Phil.
Hi Thomas,
Quoted 65 lines · Philippe Mathieu-Daudé
Quoted 64 lines · Thomas Huth
Quoted 52 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1
-1@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).arch: s390x dist: bionic addons:---
Quoted 8 lines
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Was he? Citing his reply to the mail from your URL:
Quoted 7 lines
Quoted 7 lines
"Before we take the hammer to it, could you try reducing it's initial
bandwidth"So all I can see is that he first wanted to try something different than disabling the test. And now, instead of using a small hammer to disable just this test, you now even use a very *big* hammer to disable *all* tests. That's just a very bad idea. Please don't.
You asked on IRC the CI failures history:
https://travis-ci.org/github/philmd/qemu/jobs/663607963
https://travis-ci.org/github/philmd/qemu/jobs/663622229
https://travis-ci.org/github/philmd/qemu/jobs/663642522
"No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
Quoted 22 lines
You are right. I was being concerned about having CI working because the more red it stay, the less likely the community will worry about it, and I didn't want we loose interest in testing (or discredit its importance). I now understand without having CI gating, it is pointless to try to keep it green (at the cost of having all local testing running slower, it is worst if maintainers stop their local testing).
WRT this test I have no idea what it is doing, furthermore why it fails on s390x containers, so I sent a simple patch to fix the CI, but failed to foreseen its negative effect on the rest of the developers.
Thanks Michael for fixing my mess with your patch:
Reviewed-by Philippe Mathieu-Daudé <[email protected]>Regards,
Phil.
Quoted 76 lines · Philippe Mathieu-Daudé
Hi Thomas,
Quoted 65 lines · Philippe Mathieu-Daudé
Quoted 64 lines · Thomas Huth
Quoted 52 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Thomas Huth
Quoted 20 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable it until someone figure out the issue:
-- >8 --
.travis.yml +0
-0@@ -507,6 +507,7 @@ jobs:Quoted 10 lines
Quoted 7 lines
.travis.yml +1
-0- name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:Sorry, but that looks wrong. First, the disable-tcg test does not run the qtests at all. So this is certainly the wrong location here.
Indeed, this is the previous job:
-- >8 --
.travis.yml +1
-1@@ -464,6 +464,7 @@ jobs: - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).arch: s390x dist: bionic addons:---
Quoted 8 lines
Quoted 3 lines
Second,
if just one of the qtests is failing, please only disable that single failing qtest and not the whole test pipeline.Last time we talked about this Dave was against that option:
https://www.mail-archive.com/[email protected]/msg690085.html
Was he? Citing his reply to the mail from your URL:
Quoted 7 lines
Quoted 7 lines
"Before we take the hammer to it, could you try reducing it's initial
bandwidth"So all I can see is that he first wanted to try something different than disabling the test. And now, instead of using a small hammer to disable just this test, you now even use a very *big* hammer to disable *all* tests. That's just a very bad idea. Please don't.
Quoted 8 lines
You asked on IRC the CI failures history:
https://travis-ci.org/github/philmd/qemu/jobs/663607963
https://travis-ci.org/github/philmd/qemu/jobs/663622229
https://travis-ci.org/github/philmd/qemu/jobs/663642522"No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
Ok, but none of these hangs seem to be related to the migration test. I assume that's just a generic unreliability of the builder machines, which should have been addresses with Alex' patch 1de8e4c4dcf2af8e1 ?
Thomas
Quoted 11 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Please also mention we can do this since
1de8e4c4dcfwhich allow marked the s390x job as "unstable" and allow it to fail.But if nobody is going to look at it, instead lets disable
OK we can do this as an extra patch. Can you supply a S.O.B. pls?
Quoted 42 lines
it until someone figure out the issue:
-- >8 --
.travis.yml +1
-0@@ -507,6 +507,7 @@ jobs: - name: "[s390x] Clang (disable-tcg)" arch: s390x + if: false # Temporarily disabled due to issue testing migration(see commit
6d1da867e65).
dist: bionic
compiler: clang
addons:
---With the hunk amended (no need to mention
1de8e4c4dactually):Quoted 21 lines
Signed-off-by Michael S. Tsirkin <[email protected]>--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);
Quoted 7 lines · * Michael S. Tsirkin ([email protected]) wrote:
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>
Yeh, I'd hoped something else could provide another way but I hadn't realised how this worked; You don't hit auto-converge until you've done two passes, since we're running ~100MByte of dirty memory, that means it wont hit the autoconverge stage until
2x100MByte/1MByte bandwidth=200 seconds
I'm actually measuring 130 seconds, which seems sane to me, since there's a lot of overlap; so yeh we need to find a different way to set this up.
Quoted 20 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>
What's the conclusion here? Should I merge this?
Quoted 19 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST
Quoted 10 lines · Michael S. Tsirkin
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>What's the conclusion here? Should I merge this?
Fine for me (from the s390x side). The test should not run with TCG in the CI for s390x ... if it still does, we have to have another closer look at the check there instead.
Thomas
Quoted 22 lines
Quoted 20 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST
Quoted 10 lines · Thomas Huth
Quoted 9 lines · Michael S. Tsirkin
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>
Quoted 7 lines
Quoted 1 line
What's the conclusion here? Should I merge this?
Fine for me (from the s390x side). The test should not run with TCG in the CI for s390x ... if it still does, we have to have another closer look at the check there instead.
Thomas
ack pls?
Quoted 22 lines
Quoted 22 lines
Quoted 20 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-2@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true); --MST
Thomas Huth
Acked-byQuoted 13 lines · Michael S. Tsirkin
Quoted 12 lines · Thomas Huth
Quoted 10 lines · Michael S. Tsirkin
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>What's the conclusion here? Should I merge this?
Quoted 7 lines
Quoted 5 lines
Fine for me (from the s390x side). The test should not run with TCG in the CI for s390x ... if it still does, we have to have another closer look at the check there instead.
Thomas
ack pls?
Quoted 10 lines · * Michael S. Tsirkin ([email protected]) wrote:
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>What's the conclusion here? Should I merge this?
Yes please; I need to rethink that.
Dave
Quoted 16 lines
Quoted 16 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */
Quoted 5 lines
Quoted 4 lines
tests/qtest/migration-test.c +0
-0/* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 32 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Michael S. Tsirkin ([email protected]) wrote:
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>What's the conclusion here? Should I merge this?
Yes please; I need to rethink that.
Dave
Quoted 16 lines
Quoted 16 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
tests/qtest/migration-test.c +0
-0/* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
ack pls?
Dr. David Alan Gilbert
Acked-byQuoted 38 lines · * Michael S. Tsirkin ([email protected]) wrote:
Quoted 37 lines · Dr. David Alan Gilbert
Quoted 10 lines · * Michael S. Tsirkin ([email protected]) wrote:
Quoted 7 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>What's the conclusion here? Should I merge this?
Yes please; I need to rethink that.
Dave
Quoted 21 lines
Quoted 20 lines
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
MST
Quoted 4 lines
Quoted 2 lines
--
Dr. David Alan Gilbert / [email protected] / Manchester, UKack pls?
Quoted 1 line
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 18 lines · Michael S. Tsirkin
This reverts commit
6d1da867e65f("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.Signed-off-by Michael S. Tsirkin <[email protected]>--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +0
-0
tests/qtest/migration-test.c static void test_migrate_auto_converge(void) · line 1217
Quoted 8 lines
tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);