Skip to contentSkip to conversation

compilation error with latest commit #1b006d838f78

amd-staging-drm-next Dieter Nützel 3 participants 7 messages Oct 13, 2017 – Oct 22, 2017 5 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hello,

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration]

   pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
struct resource_context *res_ctx,
const struct resource_pool *pool,
struct dc_stream_state *stream)
[snip]

Thanks,
Dieter
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): ad4a985ee986c2254f185e888e963d0d-0hun7QTegEsDD4udEopG9Q@public.gmane.org

#2 lore raw
Quoted 11 lines · Dieter Nützel

Hello,

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

Quoted 9 lines

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Harry

Quoted 2 lines

Thanks,
Dieter

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 5d4f42b6-9dd8-6147-9b57-356da6d76fdb-5C7GfCeVMHo@public.gmane.org

#4 lore raw

Am 13.10.2017 21:22, schrieb Harry Wentland:

Quoted 22 lines · Dieter Nützel
Quoted 11 lines

Hello,

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

Quoted 9 lines

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Quoted 3 lines

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Hello Harry,

I've included it by hand and tested it with and without CONFIG_DRM_AMD_DC_FBC (and already send my t-b).

The sad thing is, that latest amd-staging-drm-next (#1c630e83443a) do NOT come back from screen blanking (KDE screen saver, blank after x minutes) any longer. I have to reboot. Nothing in the logs.

Apart from this '[amd-staging-drm-next] regression - no fan info (sensors) on RX580' still stands.
https://lists.freedesktop.org/archives/amd-gfx/2017-October/014065.html

Last thing:
'amd-staging-drm-next' is still based on 4.13.0-rc5.
Could it be 'updated' (rebased) on 4.13.4+ at least?
Since 4.12-rc there seems to be an e1000 issue in the Linux kernel tree, which is fixed for my Fujitsu workstation with 4.13.4+, but not with 'amd-staging-drm-next'. Or should I switch to 'drm-next-4.15[-dc]-wip'?

Thank you for GREAT OSS gfx-support from AMD!

Dieter

Quoted 5 lines

Harry

Quoted 2 lines

Thanks,
Dieter

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive
Quoted 22 lines · Harry Wentland
Quoted 11 lines · Dieter Nützel

Hello,

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

Quoted 9 lines

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Quoted 3 lines

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Would it be possible to drop options like DRM_AMD_DC_FBC and DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially upstream), and just always compile the code?

Signature · 7 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1618481a-0c94-afa0-ac44-2a9116fca5d3-otUistvHUpPR7s880joybQ@public.gmane.org

#7 lore raw
Quoted 23 lines · Michel Dänzer
Quoted 22 lines · Harry Wentland
Quoted 20 lines · Dieter Nützel

Hello,

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Quoted 7 lines
Quoted 3 lines

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Would it be possible to drop options like DRM_AMD_DC_FBC and DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially upstream), and just always compile the code?

DRM_AMD_DC_FBC should be pretty stable by now and can probably be dropped. I'll check with Roma who implemented it.

DRM_AMD_DC_DCN1_0 requires X86 because it makes use of floating point code. We still want to keep that options as users of our driver might need to use it on PowerPC, ARM, or other platforms.

Harry

Quoted 2 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 7c1441f0-45d9-4e67-96b0-c04c4081aedd-5C7GfCeVMHo@public.gmane.org

#9 lore raw
Quoted 27 lines · Harry Wentland
Quoted 26 lines · Michel Dänzer
Quoted 24 lines · Harry Wentland
Quoted 10 lines · Dieter Nützel

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

Quoted 9 lines

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Quoted 6 lines
Quoted 3 lines

Would it be possible to drop options like DRM_AMD_DC_FBC and DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially upstream), and just always compile the code?

DRM_AMD_DC_FBC should be pretty stable by now and can probably be dropped. I'll check with Roma who implemented it.

Cool, thanks.

Quoted 3 lines

DRM_AMD_DC_DCN1_0 requires X86 because it makes use of floating point code. We still want to keep that options as users of our driver might need to use it on PowerPC, ARM, or other platforms.

Okay, but then it can just be automatically enabled or disabled depending on the architecture, it doesn't need to be exposed to users.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1bcf7b0d-12dc-f5f1-2675-4149740878b3-otUistvHUpPR7s880joybQ@public.gmane.org

#11 lore raw

Am 17.10.2017 16:59, schrieb Michel Dänzer:

Quoted 28 lines · Harry Wentland
Quoted 27 lines · Michel Dänzer
Quoted 26 lines · Harry Wentland
Quoted 24 lines · Dieter Nützel
Quoted 10 lines

next (regression) compilation error:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function ‘resource_map_pool_resources’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: implicit declaration of function ‘acquire_first_split_pipe’; did you mean ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              acquire_first_free_pipe

Quoted 9 lines

It is wrongly (?) guarded behind:

#if defined(CONFIG_DRM_AMD_DC_DCN1_0)
static int acquire_first_split_pipe(
                struct resource_context *res_ctx,
                const struct resource_pool *pool,
                struct dc_stream_state *stream)
[snip]

Sent and merged a patch. This function only makes sense for DCN and shouldn't be called otherwise. Thanks for reporting this. I gotta make sure to build without the DCN flag in the future to avoid this.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Would it be possible to drop options like DRM_AMD_DC_FBC and DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially upstream), and just always compile the code?

DRM_AMD_DC_FBC should be pretty stable by now and can probably be dropped. I'll check with Roma who implemented it.

Cool, thanks.

I'm running my RX580 under 'amd-staging-drm-next' and 'drm-next-4.15-dc-wip' with it and don't see any problems so far.

Greetings,
Dieter
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx