Skip to contentSkip to conversation

ACPI: resource: Do IRQ override on TongFang GMxXGxx

PATCH Superseded Werner Sembach 2 participants 5 messages Sep 29, 2023 – Oct 9, 2023 ACPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: resource: Do IRQ override on TongFang GMxXGxx

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding for the keyboard to work. Adding an entry for this laptop to the override_table makes the internal keyboard functional again.

---
 drivers/acpi/resource.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/acpi/resource.c +14 -2
index 32cfa3f4efd3d..3aff81820e321 100644
@@ -470,13 +470,25 @@ static const struct dmi_system_id asus_laptop[] = {
 	{ }
 };
 
-static const struct dmi_system_id tongfang_gm_rg[] = {
+static const struct dmi_system_id tongfang_gm[] = {
 	{
 		.ident = "TongFang GMxRGxx/XMG CORE 15 (M22)/TUXEDO Stellaris 15 Gen4 AMD",
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		.ident = "TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
+		},
+	},
+	{
+		.ident = "TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
+		},
+	},
 	{ }
 };
 
@@ -536,7 +548,7 @@ struct irq_override_cmp {
 static const struct irq_override_cmp override_table[] = {
 	{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
 	{ asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
-	{ tongfang_gm_rg, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
+	{ tongfang_gm, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
 	{ maingear_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
 	{ pcspecialist_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
 	{ lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Werner Sembach

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding for the keyboard to work. Adding an entry for this laptop to the override_table makes the internal keyboard functional again.

You said "again", so it used to work. Do you know which commit broke it?

Quoted 2 lines

What's the oldest kernel version you want this to be applied to?

Quoted 47 lines
---
 drivers/acpi/resource.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/acpi/resource.c +14 -3
index 32cfa3f4efd3d..3aff81820e321 100644
@@ -470,13 +470,25 @@ static const struct dmi_system_id asus_laptop[] = {
        { }
 };
 
-static const struct dmi_system_id tongfang_gm_rg[] = {
+static const struct dmi_system_id tongfang_gm[] = {
        {
                .ident = "TongFang GMxRGxx/XMG CORE 15 (M22)/TUXEDO Stellaris 15 Gen4 AMD",
                .matches = {
                        DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
                },
        },
+       {
+               .ident = "TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD",
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
+               },
+       },
+       {
+               .ident = "TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD",
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
+               },
+       },
        { }
 };
 
@@ -536,7 +548,7 @@ struct irq_override_cmp {
 static const struct irq_override_cmp override_table[] = {
        { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
        { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
-       { tongfang_gm_rg, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
+       { tongfang_gm, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
        { maingear_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
        { pcspecialist_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
        { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
--

2.34.1

#2 lore raw

Hi,

Am 03.10.23 um 20:39 schrieb Rafael J. Wysocki:

Quoted 5 lines · Werner Sembach
Quoted 3 lines

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding for the keyboard to work. Adding an entry for this laptop to the override_table makes the internal keyboard functional again.

You said "again", so it used to work. Do you know which commit broke it?

Sorry that "again" is a bit misleading. I Copied it from here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7592b79ba4a9

I actually only tested the direct predecessor of this Notebook on older kernels: https://bugzilla.kernel.org/show_bug.cgi?id=216698

I suspected that it's the same issue and since the same fix worked I now even more believe so, but I actually never tested a kernel before the breaking change.

Quoted 4 lines
Quoted 3 lines

What's the oldest kernel version you want this to be applied to?

5.15 because Ubuntu 22.04

Kind regards,

Werner Sembach

Quoted 48 lines
Quoted 48 lines
---
  drivers/acpi/resource.c | 16 ++++++++++++++--
  1 file changed, 14 insertions(+), 2 deletions(-)
drivers/acpi/resource.c +14 -3
index 32cfa3f4efd3d..3aff81820e321 100644
@@ -470,13 +470,25 @@ static const struct dmi_system_id asus_laptop[] = {
         { }
  };
 
-static const struct dmi_system_id tongfang_gm_rg[] = {
+static const struct dmi_system_id tongfang_gm[] = {
         {
                 .ident = "TongFang GMxRGxx/XMG CORE 15 (M22)/TUXEDO Stellaris 15 Gen4 AMD",
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
                 },
         },
+       {
+               .ident = "TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD",
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
+               },
+       },
+       {
+               .ident = "TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD",
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
+               },
+       },
         { }
  };
 
@@ -536,7 +548,7 @@ struct irq_override_cmp {
  static const struct irq_override_cmp override_table[] = {
         { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
         { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
-       { tongfang_gm_rg, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
+       { tongfang_gm, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
         { maingear_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
         { pcspecialist_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
         { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
--

2.34.1

#3 lore raw
Quoted 20 lines · Werner Sembach

Hi,

Am 03.10.23 um 20:39 schrieb Rafael J. Wysocki:

Quoted 5 lines · Werner Sembach
Quoted 3 lines

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding for the keyboard to work. Adding an entry for this laptop to the override_table makes the internal keyboard functional again.

You said "again", so it used to work. Do you know which commit broke it?

Sorry that "again" is a bit misleading. I Copied it from here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7592b79ba4a9

I actually only tested the direct predecessor of this Notebook on older kernels:
https://bugzilla.kernel.org/show_bug.cgi?id=216698

I suspected that it's the same issue and since the same fix worked I now even more believe so, but I actually never tested a kernel before the breaking change.

Quoted 1 line
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

What's the oldest kernel version you want this to be applied to?

5.15 because Ubuntu 22.04

So first of all Hans posted this:

https://patchwork.kernel.org/project/linux-acpi/patch/[email protected]/

and I'm wondering if it addresses the problem for you too.

If it doesn't, the patch will need to be rebased on top of the new acpi-resource material in linux-next and retested.

Thanks!

#4 lore raw

Hi

Am 06.10.23 um 21:30 schrieb Rafael J. Wysocki:

Quoted 20 lines · Werner Sembach
Quoted 19 lines

Hi,

Am 03.10.23 um 20:39 schrieb Rafael J. Wysocki:

Quoted 5 lines · Werner Sembach
Quoted 3 lines

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding for the keyboard to work. Adding an entry for this laptop to the override_table makes the internal keyboard functional again.

You said "again", so it used to work. Do you know which commit broke it?

Sorry that "again" is a bit misleading. I Copied it from here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7592b79ba4a9

I actually only tested the direct predecessor of this Notebook on older kernels:
https://bugzilla.kernel.org/show_bug.cgi?id=216698

I suspected that it's the same issue and since the same fix worked I now even more believe so, but I actually never tested a kernel before the breaking change.

Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 2 lines
Quoted 1 line

What's the oldest kernel version you want this to be applied to?

5.15 because Ubuntu 22.04

So first of all Hans posted this:

https://patchwork.kernel.org/project/linux-acpi/patch/[email protected]/

and I'm wondering if it addresses the problem for you too.

Thanks for the link. That patch seems to do the same, but for a different board name so it wont work for the GMxXGxx.

Quoted 3 lines

If it doesn't, the patch will need to be rebased on top of the new acpi-resource material in linux-next and retested.

Sure, no problem, v2 incoming soon.

Kind regards,

Werner

Quoted 2 lines

Thanks!