Skip to contentSkip to conversation

firmware: dmi-id: add product_family to modalias as pf

PATCH In review Crag Wang 2 participants 2 messages Aug 14, 2025 – Dec 22, 2025 Dmi/smbios support

lore
Share & tools
lore

Crag Wang

author
#0 lore raw

PATCH 1/1 firmware: dmi-id: add product_family to modalias as pf

Some devices require product_family information to trigger conditional actions when the value matches a predefined criterion

$ cat /sys/class/dmi/id/product_family
Dell Pro Max Desktops
$ udevadm info -q all --path=/sys/class/dmi/id | grep MODALIAS
E: MODALIAS=dmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDellInc.:pfDellProMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:ct3:cvr:sku0D14:
$ cat /sys/class/dmi/id/modalias
dmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDellInc.:pfDellProMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:ct3:cvr:sku0D14:
---
 drivers/firmware/dmi-id.c | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/dmi-id.c +1 -0
index d19c78a78ae3..284652d75cc7 100644
@@ -87,6 +87,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size)
 		{ "br",  DMI_BIOS_RELEASE },
 		{ "efr", DMI_EC_FIRMWARE_RELEASE },
 		{ "svn", DMI_SYS_VENDOR },
+		{ "pf",  DMI_PRODUCT_FAMILY },
 		{ "pn",  DMI_PRODUCT_NAME },
 		{ "pvr", DMI_PRODUCT_VERSION },
 		{ "rvn", DMI_BOARD_VENDOR },
Signature · 1 line
2.43.0
maintainer
#1 lore raw

Hi Crag,

Quoted 22 lines · Crag Wang

Some devices require product_family information to trigger conditional actions when the value matches a predefined criterion

$ cat /sys/class/dmi/id/product_family
Dell Pro Max Desktops
$ udevadm info -q all --path=/sys/class/dmi/id | grep MODALIAS
E: MODALIAS=dmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDellInc.:pfDellProMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:ct3:cvr:sku0D14:
$ cat /sys/class/dmi/id/modalias
dmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDellInc.:pfDellProMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:ct3:cvr:sku0D14:

---
 drivers/firmware/dmi-id.c | 1 +

 1 file changed, 1 insertion(+)
drivers/firmware/dmi-id.c +0 -0
index d19c78a78ae3..284652d75cc7 100644

drivers/firmware/dmi-id.c static ssize_t get_modalias(char *buffer, size_t buffer_size) · line 93

Quoted 7 lines
drivers/firmware/dmi-id.c +1 -0
@@ -87,6 +87,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size)
  		{ "br",  DMI_BIOS_RELEASE },
  		{ "efr", DMI_EC_FIRMWARE_RELEASE },
  		{ "svn", DMI_SYS_VENDOR },
+		{ "pf",  DMI_PRODUCT_FAMILY },
  		{ "pn",  DMI_PRODUCT_NAME },
  		{ "pvr", DMI_PRODUCT_VERSION },
  		{ "rvn", DMI_BOARD_VENDOR },

For consistency, I'd rather add it between DMI_PRODUCT_VERSION and DMI_BOARD_VENDOR.

That's simple enough, so why not. Out of curiosity, which udev rule (and/or driver) needs this?

Signature · 2 lines
Jean Delvare
SUSE L3 Support