Skip to contentSkip to conversation

wireguard: omit need_resched() before cond_resched()

PATCH New Mikulas Patocka 1 participant 1 message Jul 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireguard: omit need_resched() before cond_resched()

There's no need to call need_resched() because cond_resched() will do nothing if need_resched() returns false.

---
 drivers/net/wireguard/receive.c |    3 +--
 drivers/net/wireguard/send.c    |    6 ++----
 2 files changed, 3 insertions(+), 6 deletions(-)
drivers/net/wireguard/receive.c +1 -2
Index: linux-2.6/drivers/net/wireguard/receive.c
===================================================================
@@ -501,8 +501,7 @@ void wg_packet_decrypt_worker(struct wor
 			likely(decrypt_packet(skb, PACKET_CB(skb)->keypair)) ?
 				PACKET_STATE_CRYPTED : PACKET_STATE_DEAD;
 		wg_queue_enqueue_per_peer_rx(skb, state);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }
 
drivers/net/wireguard/send.c +2 -4
Index: linux-2.6/drivers/net/wireguard/send.c
===================================================================
@@ -279,8 +279,7 @@ void wg_packet_tx_worker(struct work_str
 
 		wg_noise_keypair_put(keypair, false);
 		wg_peer_put(peer);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }
 
@@ -303,8 +302,7 @@ void wg_packet_encrypt_worker(struct wor
 			}
 		}
 		wg_queue_enqueue_per_peer_tx(first, state);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }