Skip to contentSkip to conversation

Rename LLCC cache-controller to system-cache-controller

PATCH In review Sai Prakash Ranjan 3 participants 6 messages Nov 15, 2019 – Dec 3, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Rename LLCC cache-controller to system-cache-controller

DT schema checks for the node name 'cache-controller' and enforces that there has to be a cache-level associated with it. But LLCC is a system cache and does not have a cache-level property and hence the dt binding check fails. So let us rename the LLCC cache-controller to system-cache-controller which is the proper description and also makes the schema happy.

Sai Prakash Ranjan (2):
dt-bindings: msm: Rename cache-controller to system-cache-controller
arm64: dts: sdm845: Update the device tree node for LLCC

 Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH 1/2 dt-bindings: msm: Rename cache-controller to system-cache-controller

DT schema checks for the node name 'cache-controller' and enforces that there has to be a cache-level associated with it. But LLCC is a system cache and does not have a cache-level property and hence the dt binding check fails. So let us rename the LLCC cache-controller to system-cache-controller which is the proper description and also makes the schema happy.

---
 Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml +1 -1
index 558749065b97..79902f470e4b 100644
@@ -47,7 +47,7 @@ examples:
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>
 
-    cache-controller@1100000 {
+    system-cache-controller@1100000 {
       compatible = "qcom,sdm845-llcc";
       reg = <0x1100000 0x200000>, <0x1300000 0x50000> ;
       reg-names = "llcc_base", "llcc_broadcast_base";
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: msm: Rename cache-controller to system-cache-controller

Quoting Sai Prakash Ranjan (2019-11-15 02:59:11)

Quoted 10 lines

DT schema checks for the node name 'cache-controller' and enforces that there has to be a cache-level associated with it. But LLCC is a system cache and does not have a cache-level property and hence the dt binding check fails. So let us rename the LLCC cache-controller to system-cache-controller which is the proper description and also makes the schema happy.

---

maintainer Acked-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] dt-bindings: msm: Rename cache-controller to system-cache-controller

In reply to Sai Prakash Ranjan
Quoted 7 lines · Sai Prakash Ranjan

DT schema checks for the node name 'cache-controller' and enforces that there has to be a cache-level associated with it. But LLCC is a system cache and does not have a cache-level property and hence the dt binding check fails. So let us rename the LLCC cache-controller to system-cache-controller which is the proper description and also makes the schema happy.

Quoted 6 lines
---
 Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#4 lore raw

PATCH 2/2 arm64: dts: sdm845: Update the device tree node for LLCC

In reply to Sai Prakash Ranjan

LLCC cache-controller was renamed to system-cache-controller to make schema pass the dt binding check. Update the device tree node to reflect this change.

---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
index ddb1f23c936f..250b65e8f7e5 100644
@@ -1357,7 +1357,7 @@
 			};
 		};
 
-		cache-controller@1100000 {
+		system-cache-controller@1100000 {
 			compatible = "qcom,sdm845-llcc";
 			reg = <0 0x01100000 0 0x200000>, <0 0x01300000 0 0x50000>;
 			reg-names = "llcc_base", "llcc_broadcast_base";
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation