Add support for WiFi/BT header on Pine64 A64
Subsystems (2)
v3 cover Add support for WiFi/BT header on Pine64 A64
Add the BT and WiFi pins on the WiFi/BT header on the Pine64/Sopine boards.
Changes in v3:
- Explicitly disable mmc WiFi section in DT even though it's already disabled in the SoC DT.
Changes in v2:
- drop patch that enables the WiFi module, it'll move to a overlay later
Peter Robinson (2):
arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64
arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
.../boot/dts/allwinner/sun50i-a64-pine64.dts | 18 +++++++++++++ .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ 2 files changed, 43 insertions(+)
Signature · 1 line
2.49.0
PATCH v3 1/2 arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64
This adds all the pin mappings on the WiFi/BT header on the original Pine64. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
--- .../boot/dts/allwinner/sun50i-a64-pine64.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +18 -0
@@ -35,6 +35,11 @@ hdmi_con_in: endpoint { }; }; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ + }; }; &codec {
@@ -124,6 +129,18 @@ &mmc0 { status = "okay"; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>; + bus-width = <4>; + non-removable; + status = "disabled"; +}; + &ohci0 { status = "okay"; };
@@ -286,6 +303,7 @@ &uart0 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; status = "disabled"; };
Signature · 1 line
2.49.0
Re: [PATCH v3 1/2] arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64
Hello Peter,
Quoted 16 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the original Pine64. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
Signed-off-by Peter Robinson <[email protected]>--- .../boot/dts/allwinner/sun50i-a64-pine64.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts hdmi_con_in: endpoint { · line 42
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +5
-0@@ -35,6 +35,11 @@ hdmi_con_in: endpoint { }; }; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ + };
Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +0
-0}; &codec {
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts &mmc0 { · line 138
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +7
-0@@ -124,6 +129,18 @@ &mmc0 { status = "okay"; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;
Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +6
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &ohci0 { status = "okay"; };@@ -286,6 +303,7 @@ &uart0 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; status = "disabled"; };
PATCH v3 2/2 arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
In reply to Peter RobinsonThis adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
--- .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +25 -0
@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ + }; }; &ac_power_supply {
@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>; + bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;
@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Signature · 1 line
2.49.0
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Hello Peter,
Quoted 4 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 12 lines
Signed-off-by Peter Robinson <[email protected]>--- .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 49
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +5
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ + };
Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;
Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
A message that is not in the archive (sent off-list or not yet received): CALeDE9M_c7556sTdTC37Ce5vzLC2E8SV_P-J2CtFiUksdM_71Q@mail.gmail.com
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Quoted 41 lines · Peter Robinson
Quoted 40 lines · Dragan Simic
Quoted 4 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 3 lines
Signed-off-by Peter Robinson <[email protected]>---
.../allwinner/sun50i-a64-sopine-baseboard.dts| 25+++++++++++++++++++
Quoted 7 lines
1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644
---
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsQuoted 1 line
+++
b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsarch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 48
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +4
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2*/
Review reg_vcc1v8: vcc1v8 { · line 49
Quoted 1 line
(quoted diff) +1
-0+ };Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
Quoted 5 lines
Quoted 3 lines
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
But the pin itself is pinned out through the header on the device.
Good point. On second thought, the right approach should be to reserve the reset pin through pinctrl additions to the board dts files, but to move the "mmc-pwrseq-simple" nodes to the proposed add-on overlays.
You can have a look at rk3399-pinebook-pro.dts for an example of such a pinctrl definition and its use.
Quoted 41 lines
Quoted 41 lines
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Quoted 49 lines · Dragan Simic
Quoted 41 lines · Peter Robinson
Quoted 40 lines · Dragan Simic
Quoted 4 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 3 lines
Signed-off-by Peter Robinson <[email protected]>---
.../allwinner/sun50i-a64-sopine-baseboard.dts| 25+++++++++++++++++++
Quoted 7 lines
1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644
---
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsQuoted 1 line
+++
b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsarch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 48
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +4
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2*/
Review reg_vcc1v8: vcc1v8 { · line 49
Quoted 1 line
(quoted diff) +1
-0+ };Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
Quoted 5 lines
Quoted 3 lines
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
But the pin itself is pinned out through the header on the device.
Quoted 7 lines
Good point. On second thought, the right approach should be to reserve the reset pin through pinctrl additions to the board dts files, but to move the "mmc-pwrseq-simple" nodes to the proposed add-on overlays.
You can have a look at
rk3399-pinebook-pro.dtsfor an example of such a pinctrl definition and its use.
For sunxi, we don't add pinctrl nodes for GPIO usage.
ChenYu
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Hello Chen-Yu,
Quoted 48 lines · Chen-Yu Tsai
Quoted 47 lines · Dragan Simic
Quoted 45 lines · Peter Robinson
Quoted 43 lines · Dragan Simic
Quoted 4 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 3 lines
Signed-off-by Peter Robinson <[email protected]>---
.../allwinner/sun50i-a64-sopine-baseboard.dts| 25+++++++++++++++++++
Quoted 7 lines
1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644
---
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsQuoted 1 line
+++
b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsarch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 48
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +4
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2*/
Review reg_vcc1v8: vcc1v8 { · line 49
Quoted 1 line
(quoted diff) +1
-0+ };Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
But the pin itself is pinned out through the header on the device.
Good point. On second thought, the right approach should be to reserve the reset pin through pinctrl additions to the board dts files, but to move the "mmc-pwrseq-simple" nodes to the proposed add-on overlays.
Actually, s/overlays/overlay/
Quoted 5 lines
Quoted 3 lines
You can have a look at
rk3399-pinebook-pro.dtsfor an example of such a pinctrl definition and its use.For sunxi, we don't add pinctrl nodes for GPIO usage.
I see, thanks for the note. In that case, I'd still suggest that the "mmc-pwrseq-simple" nodes are moved to the proposed add-on overlay, because that's where they belong to.
In theory, some add-on module may actually not need resetting, so defining that should belong to what defines the specific add-on module, which is the add-on overlay.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Quoted 68 lines · Dragan Simic
Hello Chen-Yu,
Quoted 49 lines · Chen-Yu Tsai
Quoted 47 lines · Dragan Simic
Quoted 45 lines · Peter Robinson
Quoted 43 lines · Dragan Simic
Quoted 4 lines · Peter Robinson
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 3 lines
Signed-off-by Peter Robinson <[email protected]>---
.../allwinner/sun50i-a64-sopine-baseboard.dts| 25+++++++++++++++++++
Quoted 7 lines
1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644
---
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsQuoted 1 line
+++
b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsarch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 48
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +4
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2*/
Review reg_vcc1v8: vcc1v8 { · line 49
Quoted 1 line
(quoted diff) +1
-0+ };Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
But the pin itself is pinned out through the header on the device.
Good point. On second thought, the right approach should be to reserve the reset pin through pinctrl additions to the board dts files, but to move the "mmc-pwrseq-simple" nodes to the proposed add-on overlays.
Actually, s/overlays/overlay/
Quoted 5 lines
Quoted 3 lines
You can have a look at
rk3399-pinebook-pro.dtsfor an example of such a pinctrl definition and its use.For sunxi, we don't add pinctrl nodes for GPIO usage.
Quoted 7 lines
I see, thanks for the note. In that case, I'd still suggest that the "mmc-pwrseq-simple" nodes are moved to the proposed add-on overlay, because that's where they belong to.
In theory, some add-on module may actually not need resetting, so defining that should belong to what defines the specific add-on module, which is the add-on overlay.
I agree.
Quoted 42 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
In reply to Dragan SimicHi Dragan,
Quoted 9 lines
Quoted 4 lines
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
It literally has baseboard in the second line of the description.
Quoted 70 lines
Quoted 12 lines
Signed-off-by Peter Robinson <[email protected]>--- .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsb/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dtsindexbe2347c8f267..64d696f110ee100644arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts reg_vcc1v8: vcc1v8 { · line 49
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +5
-0@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + wifi_pwrseq: pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ + };Is there a reason why the status of this node isn't set to "disabled"? Or even better, why don't we move this node entirely into the proposed DT overlay?
The required reset procedure actually depends on what's found on the add-on module, so it should belong to the DT overlay that defines the add-on module.
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +0
-0}; &ac_power_supply {arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts ext_rgmii_phy: ethernet-phy@1 { · line 117
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +7
-0@@ -103,6 +108,18 @@ ext_rgmii_phy: ethernet-phy@1 { }; }; +/* On Wifi/BT connector */ +&mmc1 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc1_pins>; + vmmc-supply = <®_dldo4>; + vqmmc-supply = <®_eldo1>; + mmc-pwrseq = <&wifi_pwrseq>;Of course, the "mmc-pwrseq" property would then also be moved to the DT overlay that defines the add-on module.
Quoted 23 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +13
-0+ bus-width = <4>; + non-removable; + status = "disabled"; +}; + &mmc2 { pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>;@@ -175,6 +192,14 @@ &uart0 { status = "okay"; }; +/* On Wifi/BT connector, with RTS/CTS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "disabled"; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Hello Peter,
Quoted 11 lines · Peter Robinson
Quoted 9 lines
Quoted 4 lines
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
It literally has baseboard in the second line of the description.
True, but the patch subject should also contain "Baseboard", because SOPINE is a system on module, and the SOPINE Baseboard turns it into an SBC that actually has the add-on headers that the patch addresses. I hope it makes sense.
Re: [PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
Quoted 14 lines · Dragan Simic
Hello Peter,
Quoted 10 lines · Peter Robinson
Quoted 9 lines
Quoted 4 lines
This adds all the pin mappings on the WiFi/BT header on the SoPine baseboard/A64-LTS. They're disabled by default as the modules don't ship by default. This includes, where they haven't been already, UART1 for BT and mmc1 for WiFi.
The patch subject should be improved a bit, to include "Baseboard" as well. Having just "SoPine" is a bit too vague, and it should actually be written as "SOPINE" at all places in the prose.
Quoted 6 lines
Quoted 1 line
It literally has baseboard in the second line of the description.
True, but the patch subject should also contain "Baseboard", because SOPINE is a system on module, and the SOPINE Baseboard turns it into an SBC that actually has the add-on headers that the patch addresses. I hope it makes sense.
I mean it's pretty clear from the file that is being patched, I think you're splitting hairs here, but I've already updated it in v4