Skip to contentSkip to conversation

platform/wmi: string-kunit: Add missing oversized string test case

PATCH In review Armin Wolf 2 participants 3 messages Jan 23 – Jan 27

Subsystems (2)
lore
Share & tools
lore

Armin Wolf

author maintainer
#0 lore raw

PATCH 1/1 platform/wmi: string-kunit: Add missing oversized string test case

When compiling the WMI string kunit tests using llvm, the compiler will issue a warning about "oversized_test_utf8_string" being unused. This happens because the test case that was supposed to use said variable was accidentally omitted when adding the kunit tests.

Fix this by adding the aforementioned test case.

Fixes 0e1a8143e797 ("platform/wmi: Add kunit test for the string conversion code")
---
 drivers/platform/wmi/tests/string_kunit.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/platform/wmi/tests/string_kunit.c +18 -0
index 9aa3ffa85090..117f32ee26a8 100644
@@ -228,6 +228,23 @@ static void wmi_string_to_utf8s_oversized_test(struct kunit *test)
 	KUNIT_EXPECT_MEMEQ(test, result, test_utf8_string, sizeof(test_utf8_string));
 }
 
+static void wmi_string_from_utf8s_oversized_test(struct kunit *test)
+{
+	struct wmi_string *result;
+	size_t max_chars;
+	ssize_t ret;
+
+	max_chars = (TEST_WMI_STRING_LENGTH - sizeof(*result)) / 2;
+	result = kunit_kzalloc(test, TEST_WMI_STRING_LENGTH, GFP_KERNEL);
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, result);
+
+	ret = wmi_string_from_utf8s(result, max_chars, oversized_test_utf8_string,
+				    sizeof(oversized_test_utf8_string));
+
+	KUNIT_EXPECT_EQ(test, ret, sizeof(test_utf8_string) - 1);
+	KUNIT_EXPECT_MEMEQ(test, result, &test_wmi_string, sizeof(test_wmi_string));
+}
+
 static void wmi_string_to_utf8s_invalid_test(struct kunit *test)
 {
 	u8 result[sizeof(invalid_test_utf8_string)];
@@ -261,6 +278,7 @@ static struct kunit_case wmi_string_test_cases[] = {
 	KUNIT_CASE(wmi_string_to_utf8s_padded_test),
 	KUNIT_CASE(wmi_string_from_utf8s_padded_test),
 	KUNIT_CASE(wmi_string_to_utf8s_oversized_test),
+	KUNIT_CASE(wmi_string_from_utf8s_oversized_test),
 	KUNIT_CASE(wmi_string_to_utf8s_invalid_test),
 	KUNIT_CASE(wmi_string_from_utf8s_invalid_test),
 	{}
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 8 lines · Armin Wolf

When compiling the WMI string kunit tests using llvm, the compiler will issue a warning about "oversized_test_utf8_string" being unused. This happens because the test case that was supposed to use said variable was accidentally omitted when adding the kunit tests.

Fix this by adding the aforementioned test case.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] platform/wmi: string-kunit: Add missing oversized string test case

      commit: 5d4ae0bffb6eeada6dd16ba52150457ae96c3725

--
i.

author maintainer
#2 lore raw

Am 26.01.26 um 15:30 schrieb Ilpo Järvinen:

Quoted 7 lines · Armin Wolf
Quoted 6 lines

When compiling the WMI string kunit tests using llvm, the compiler will issue a warning about "oversized_test_utf8_string" being unused. This happens because the test case that was supposed to use said variable was accidentally omitted when adding the kunit tests.

Quoted 8 lines
Quoted 3 lines

Fix this by adding the aforementioned test case.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

Thank you :)

Quoted 7 lines

The list of commits applied:
[1/1] platform/wmi: string-kunit: Add missing oversized string test case

       commit: 5d4ae0bffb6eeada6dd16ba52150457ae96c3725

--
i.