Skip to contentSkip to conversation

package/vlc: disable on riscv32

PATCH New Fabrice Fontaine 3 participants 3 messages May 28, 2021 – Jun 10, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/vlc: disable on riscv32

vlc unconditionally uses __NR_futex resulting in the following build failure on riscv32:

linux/thread.c:53:20: error: '__NR_futex' undeclared (first use in this function)

   53 |     return syscall(__NR_futex, addr, op, val, to, addr2, val3);
      |                    ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/be0f2243919d7a052b33118d8a901c922f8d88e7

---
 package/vlc/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/vlc/Config.in +2 -0
index 96ff8f2fcb..964b7660af 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_VLC
 	bool "vlc"
+	depends on !BR2_RISCV_32
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS
@@ -23,6 +24,7 @@ config BR2_PACKAGE_VLC_OPENCV3_BACKEND
 	select BR2_PACKAGE_OPENCV3_LIB_OBJDETECT
 
 comment "vlc needs a toolchain w/ C++, dynamic library, wchar, threads, gcc >= 4.9, headers >= 3.7"
+	depends on !BR2_RISCV_32
 	depends on BR2_USE_MMU
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS \
 		|| !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS \
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/vlc: disable on riscv32

Quoted 7 lines · Fabrice Fontaine

vlc unconditionally uses __NR_futex resulting in the following build failure on riscv32:

linux/thread.c:53:20: error: '__NR_futex' undeclared (first use in this function)

   53 |     return syscall(__NR_futex, addr, op, val, to, addr2, val3);
      |                    ^~~~~~~~~~

I added a comment that the upstream patch is rejected and applied to master,
thanks.

Regards,
Arnout

Quoted 28 lines

Fixes:
- http://autobuild.buildroot.org/results/be0f2243919d7a052b33118d8a901c922f8d88e7

---
 package/vlc/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/vlc/Config.in +2 -0
index 96ff8f2fcb..964b7660af 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_VLC
 	bool "vlc"
+	depends on !BR2_RISCV_32
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS
@@ -23,6 +24,7 @@ config BR2_PACKAGE_VLC_OPENCV3_BACKEND
 	select BR2_PACKAGE_OPENCV3_LIB_OBJDETECT
 
 comment "vlc needs a toolchain w/ C++, dynamic library, wchar, threads, gcc >= 4.9, headers >= 3.7"
+	depends on !BR2_RISCV_32
 	depends on BR2_USE_MMU
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS \
 		|| !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS \
#2 lore raw

PATCH 1/1 package/vlc: disable on riscv32

In reply to Fabrice Fontaine
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

vlc unconditionally uses __NR_futex resulting in the following build failure on riscv32:

Quoted 8 lines

linux/thread.c:53:20: error: '__NR_futex' undeclared (first use in this function)

   53 |     return syscall(__NR_futex, addr, op, val, to, addr2, val3);
      |                    ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/be0f2243919d7a052b33118d8a901c922f8d88e7

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard