Skip to contentSkip to conversation

fs/ntfs3: remove duplicated assignment to variable r

PATCH In review Colin Ian King 2 participants 2 messages Jul 4, 2022 – Jul 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/ntfs3: remove duplicated assignment to variable r

The assignment to variable r is duplicated, the second assignment is redundant and can be removed.

---
 fs/ntfs3/run.c | 1 -
 1 file changed, 1 deletion(-)
fs/ntfs3/run.c +0 -1
index 7609d45a2d72..aba8ab1b9fcb 100644
@@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
 	e = run->runs + run->count;
 	r = run->runs + index;
 
-	r = run->runs + index;
 	if (vcn > r->vcn)
 		r += 1;
 
Signature · 1 line
2.35.3
#1 lore raw
Quoted 13 lines · Colin Ian King

The assignment to variable r is duplicated, the second assignment is redundant and can be removed.

---
  fs/ntfs3/run.c | 1 -
  1 file changed, 1 deletion(-)
fs/ntfs3/run.c +0 -0
index 7609d45a2d72..aba8ab1b9fcb 100644

fs/ntfs3/run.c bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len) · line 568

Quoted 7 lines
fs/ntfs3/run.c +0 -1
@@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
  	e = run->runs + run->count;
  	r = run->runs + index;
 
-	r = run->runs + index;
  	if (vcn > r->vcn)
  		r += 1;
 

Thanks for patch, applied!