support/misc/gitlab-ci.yml.in: specify image to use
PATCH 1/1 support/misc/gitlab-ci.yml.in: specify image to use
Commit 93a2870966 split off the generated gitlab-ci.yml into a child pipeline. However, the generated gitlab-ci.yml file no longer had an 'image' tag. The result is that the jobs will use whatever image happens to be configured on the runner - which leads to frequent pipeline failures.
Fix this by explicitly specifying the image to use (the same one as in top-level .gitlab-ci.yml).
--- support/misc/gitlab-ci.yml.in | 2 ++ 1 file changed, 2 insertions(+)
support/misc/gitlab-ci.yml.in +2 -0
@@ -1,3 +1,5 @@ +image: buildroot/base:20200814.2228 + .check-DEVELOPERS_base: # get-developers should print just "No action specified"; if it prints # anything else, it's a parse error.
Signature · 1 line
2.26.2
PATCH 1/1 support/misc/gitlab-ci.yml.in: specify image to use
Hello Arnout,
Le 15/09/2020 ? 21:38, Arnout Vandecappelle (Essensium/Mind) a ?crit?:
Quoted 19 lines
Commit
93a2870966split off the generated gitlab-ci.yml into a child pipeline. However, the generated gitlab-ci.yml file no longer had an 'image' tag. The result is that the jobs will use whatever image happens to be configured on the runner - which leads to frequent pipeline failures.Fix this by explicitly specifying the image to use (the same one as in top-level .gitlab-ci.yml).
--- support/misc/gitlab-ci.yml.in | 2 ++ 1 file changed, 2 insertions(+)support/misc/gitlab-ci.yml.in +0
-0
support/misc/gitlab-ci.yml.in line 2
Quoted 2 lines
support/misc/gitlab-ci.yml.in +2
-0@@ -1,3 +1,5 @@ +image: buildroot/base:20200814.2228 +
Adding Yann in Cc:
This basically revert change from:
https://git.buildroot.net/buildroot/commit/?id=bef67390949dd6ba5cbfd658371c5df81bb5758c
commit 93a2870966 didn't remove the 'image' tag.
I guess you used support/scripts/generate-gitlab-ci-yml locally without gilab environment variable (CI_JOB_IMAGE).
Best regards,
Romain
Quoted 4 lines
support/misc/gitlab-ci.yml.in +0
-0.check-DEVELOPERS_base: # get-developers should print just "No action specified"; if it prints # anything else, it's a parse error.
PATCH 1/1 support/misc/gitlab-ci.yml.in: specify image to use
In reply to Arnout Vandecappelle (Essensium/Mind)Arnout, All,
On 2020-09-15 21:38 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
Quoted 3 lines
Commit
93a2870966split off the generated gitlab-ci.yml into a child pipeline. However, the generated gitlab-ci.yml file no longer had an 'image' tag.
Commit 93a2870966 still kept the image tag in the template. The removal of the iamge tag was done later, see below...
Quoted 3 lines
The result is that the jobs will use whatever image happens to be configured on the runner - which leads to frequent pipeline failures.
Do you have an example of such a pipeline (and its parent)?
Quoted 2 lines
Fix this by explicitly specifying the image to use (the same one as in top-level .gitlab-ci.yml).
I was the one to explicitly remove it, because it is now supposed to be added bny the script, with commit bef6739094 (gitlab-ci: share the image version with the child):
+preamble() {
+ local template="${1}"
+
+ cat - "${template}" <<-_EOF_
+ # This file is generated; do not edit!
+ # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
+
+ image: ${CI_JOB_IMAGE}
+
+_EOF_
+}So the preamble is supposed to now contain the image name, the the template.
And indeed it works for me:
$ CI_JOB_IMAGE=FOOO support/scripts/generate-gitlab-ci-yml \
support/misc/gitlab-ci.yml.in
[...]
image: FOOO
[...]And it looks like the tests I had done were also successfull:
https://gitlab.com/ymorin/buildroot/-/pipelines/186530918 https://gitlab.com/ymorin/buildroot/-/jobs/723345502 https://gitlab.com/ymorin/buildroot/-/jobs/723345502/artifacts/file/generated-gitlab-ci.yml -> image: buildroot/base:20200814.2228
And so the jobs in the child pipeline use the expected image:
https://gitlab.com/ymorin/buildroot/-/pipelines/186531247 https://gitlab.com/ymorin/buildroot/-/jobs/723346533 -> Using Docker executor with image buildroot/base:20200814.2228 ...
So, I'm not in favour of restoring the hard-coded version in the child pipeline.
Regards,
Yann E. MORIN.
Quoted 22 lines
--- support/misc/gitlab-ci.yml.in | 2 ++ 1 file changed, 2 insertions(+)support/misc/gitlab-ci.yml.in +2
-0@@ -1,3 +1,5 @@ +image: buildroot/base:20200814.2228 + .check-DEVELOPERS_base: # get-developers should print just "No action specified"; if it prints # anything else, it's a parse error.Signature · 6 lines
2.26.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 support/misc/gitlab-ci.yml.in: specify image to use
Arnout, All,
On 2020-09-15 21:50 +0200, Yann E. MORIN spake thusly:
Quoted 10 lines
On 2020-09-15 21:38 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
Quoted 3 lines
Commit
93a2870966split off the generated gitlab-ci.yml into a child pipeline. However, the generated gitlab-ci.yml file no longer had an 'image' tag.Commit
93a2870966still kept the image tag in the template. The removal of the iamge tag was done later, see below...Quoted 3 lines
The result is that the jobs will use whatever image happens to be configured on the runner - which leads to frequent pipeline failures.
Do you have an example of such a pipeline (and its parent)?
Ah, I see some, indeed:
https://gitlab.com/buildroot.org/buildroot/-/pipelines/189823194
What is interesting here, is that the generate-gitlab-ci-yml job ran on your runner:
https://gitlab.com/buildroot.org/buildroot/-/jobs/737264806 Running with gitlab-runner 12.6.0 (ac8e767a) on Buildroot-mind fMZePpyU
While a working pipeline was running on another runner:
https://gitlab.com/buildroot.org/buildroot/-/pipelines/190372488 https://gitlab.com/buildroot.org/buildroot/-/jobs/739712931 Running with gitlab-runner 13.0.0 (c127439c) on gcc160 f0ab0d82
And my tests were also using a more recent runner version:
https://gitlab.com/ymorin/buildroot/-/pipelines/186530918 https://gitlab.com/ymorin/buildroot/-/jobs/723345502 Running with gitlab-runner 13.3.1 (738bbe5a) on docker-auto-scale ed2dce3a
So it seems that the 12.6.0 runner version is too old to export the CI_JOB_IMAGE variable, and that 13.0.0 and up are OK.
Could you update your runner, maybe?
And we should also probably be using the same version on all our runners, maybe...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 support/misc/gitlab-ci.yml.in: specify image to use
Quoted 9 lines · Yann E. MORIN
Arnout, All,
On 2020-09-15 21:50 +0200, Yann E. MORIN spake thusly:
Quoted 6 lines
On 2020-09-15 21:38 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
Quoted 3 lines
Commit
93a2870966split off the generated gitlab-ci.yml into a child pipeline. However, the generated gitlab-ci.yml file no longer had an 'image' tag.Commit
93a2870966still kept the image tag in the template. The removal of the iamge tag was done later, see below...
Darn, I shouldn't be doing this quick-quick stuff...
Quoted 33 lines
Quoted 4 lines
Quoted 3 lines
The result is that the jobs will use whatever image happens to be configured on the runner - which leads to frequent pipeline failures.
Do you have an example of such a pipeline (and its parent)?
Ah, I see some, indeed:
https://gitlab.com/buildroot.org/buildroot/-/pipelines/189823194What is interesting here, is that the generate-gitlab-ci-yml job ran on your runner:
https://gitlab.com/buildroot.org/buildroot/-/jobs/737264806 Running with gitlab-runner 12.6.0 (ac8e767a) on Buildroot-mind fMZePpyUWhile a working pipeline was running on another runner:
https://gitlab.com/buildroot.org/buildroot/-/pipelines/190372488 https://gitlab.com/buildroot.org/buildroot/-/jobs/739712931 Running with gitlab-runner 13.0.0 (c127439c) on gcc160 f0ab0d82And my tests were also using a more recent runner version:
https://gitlab.com/ymorin/buildroot/-/pipelines/186530918 https://gitlab.com/ymorin/buildroot/-/jobs/723345502 Running with gitlab-runner 13.3.1 (738bbe5a) on docker-auto-scale ed2dce3a
Quoted 4 lines
So it seems that the 12.6.0 runner version is too old to export the
CI_JOB_IMAGEvariable, and that 13.0.0 and up are OK.Could you update your runner, maybe?
Thank you for your investigation! I've updated the runner and marked this patch
as rejected. Let's see how this goes.
Quoted 2 lines
And we should also probably be using the same version on all our runners, maybe...
Really, gitlab should give a warning if a runner is too old...
Regards,
Arnout