Skip to contentSkip to conversation

ti-bsp: Disable GC320 support conditionally on BSP version

PATCH In review Andrew Davis 3 participants 6 messages Jan 8, 2025 – Jan 12, 2025 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ti-bsp: Disable GC320 support conditionally on BSP version

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
- Rebased on latest with new meta-beagle layer

 meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++
 meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++
 2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +6 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
 BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+
 # ==========
 # bb_org-6_6
 # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
 BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
 BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
+
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +15 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
 # in mainline, usually present in TI staging or derivative like BB.org
 MACHINE_FEATURES:remove:bsp-mainline = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+
 # ==========
 # next
 # upcoming upstream/mainline kernel, u-boot
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
 # in next, usually present in TI staging or derivative like BB.org
 MACHINE_FEATURES:remove:bsp-next = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"
+
 # ==========
 # ti-6_12
 # TI staging kernel 6.12, u-boot 2024.10
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
 # in 6.12 yet
 MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+
 # ==========
 # ti-6_6
 # TI staging kernel 6.6, u-boot 2024.04
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
 BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+
 # ==========
 # ti-6_1
 # TI staging kernel 6.1, u-boot 2023.04
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
 BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+
 # ==========
 # sane fallback defaults
 # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2
#1 lore raw
Quoted 54 lines · Andrew Davis via lists.yoctoproject.org

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
- Rebased on latest with new meta-beagle layer

 meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++
 meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++
 2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +6 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
 BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+
 # ==========
 # bb_org-6_6
 # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
 BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
 BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
+
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
 # in mainline, usually present in TI staging or derivative like BB.org
 MACHINE_FEATURES:remove:bsp-mainline = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+
 # ==========
 # next
 # upcoming upstream/mainline kernel, u-boot

meta-ti-bsp/conf/machine/include/ti-bsp.inc BSP_BOOTLOADER_VERSION:bsp-next = "%" · line 42

Quoted 5 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +2 -0
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
 # in next, usually present in TI staging or derivative like BB.org
 MACHINE_FEATURES:remove:bsp-next = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"

Andrew, Ryan,

Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got committed removing it for bsp-ti-6_12 twice:

https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3

Was there any manual massaging involved?

Quoted 36 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +10 -0
+
 # ==========
 # ti-6_12
 # TI staging kernel 6.12, u-boot 2024.10
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
 # in 6.12 yet
 MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+
 # ==========
 # ti-6_6
 # TI staging kernel 6.6, u-boot 2024.04
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
 BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+
 # ==========
 # ti-6_1
 # TI staging kernel 6.1, u-boot 2023.04
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
 BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+
 # ==========
 # sane fallback defaults
 # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2
#2 lore raw
Quoted 63 lines · Denys Dmytriyenko
Quoted 54 lines · Andrew Davis via lists.yoctoproject.org

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
- Rebased on latest with new meta-beagle layer

  meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++
  meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++
  2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +6 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
  BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+
  # ==========
  # bb_org-6_6
  # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
  BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
+
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
  # in mainline, usually present in TI staging or derivative like BB.org
  MACHINE_FEATURES:remove:bsp-mainline = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+
  # ==========
  # next
  # upcoming upstream/mainline kernel, u-boot

meta-ti-bsp/conf/machine/include/ti-bsp.inc BSP_BOOTLOADER_VERSION:bsp-next = "%" · line 42

Quoted 5 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +2 -0
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
  # in next, usually present in TI staging or derivative like BB.org
  MACHINE_FEATURES:remove:bsp-next = "gpu"
 
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"

Andrew, Ryan,

Quoted 7 lines

Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got committed removing it for bsp-ti-6_12 twice:

https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3

Was there any manual massaging involved?

Yes. I did. Let me look at it.

Quoted 37 lines
Quoted 37 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +10 -0
+
  # ==========
  # ti-6_12
  # TI staging kernel 6.12, u-boot 2024.10
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
  # in 6.12 yet
  MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+
  # ==========
  # ti-6_6
  # TI staging kernel 6.6, u-boot 2024.04
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+
  # ==========
  # ti-6_1
  # TI staging kernel 6.1, u-boot 2023.04
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
 
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+
  # ==========
  # sane fallback defaults
  # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 70 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 67 lines · Denys Dmytriyenko
Quoted 57 lines · Andrew Davis via lists.yoctoproject.org

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
  - Rebased on latest with new meta-beagle layer

  meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++ meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++

  2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +0 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%" BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+

  # ==========

  # bb_org-6_6
  # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
meta-beagle/conf/machine/include/beagle-bsp.inc +0 -0
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = 

"ti-img-rogue-driver"
  BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+
+# GC320 support requires out-of-tree drivers not yet available in 

bb.org 6.6

meta-beagle/conf/machine/include/beagle-bsp.inc +1 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
   # in mainline, usually present in TI staging or derivative like BB.org

  MACHINE_FEATURES:remove:bsp-mainline = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+

  # ==========

  # next
  # upcoming upstream/mainline kernel, u-boot
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
   # in next, usually present in TI staging or derivative like BB.org

  MACHINE_FEATURES:remove:bsp-next = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc BSP_BOOTLOADER_VERSION:bsp-next = "%" · line 42

Quoted 2 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +2 -0
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"

Andrew, Ryan,

Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got committed removing it for bsp-ti-6_12 twice:

Quoted 5 lines
Quoted 3 lines

https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3

Was there any manual massaging involved?

Yes.  I did.  Let me look at it.

Fixed on master-wip, scarthgap-wip was correct.

Quoted 46 lines
Quoted 27 lines
Quoted 27 lines

+
  # ==========

  # ti-6_12
  # TI staging kernel 6.12, u-boot 2024.10
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
   # in 6.12 yet

  MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+

  # ==========

  # ti-6_6
  # TI staging kernel 6.6, u-boot 2024.04
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+

  # ==========

  # ti-6_1
  # TI staging kernel 6.1, u-boot 2023.04
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"

Quoted 8 lines
Quoted 8 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+

  # ==========

  # sane fallback defaults
  # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18179): https://lists.yoctoproject.org/g/meta-ti/message/18179
Mute This Topic: https://lists.yoctoproject.org/mt/110504595/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#5 lore raw
Quoted 76 lines · Ryan Eatmon
Quoted 73 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 70 lines · Denys Dmytriyenko
Quoted 59 lines · Andrew Davis via lists.yoctoproject.org

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
  - Rebased on latest with new meta-beagle layer

  meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++ meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++

  2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +0 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%" BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%" +# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+

  # ==========

  # bb_org-6_6
  # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
meta-beagle/conf/machine/include/beagle-bsp.inc +0 -0
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 =

"ti-img-rogue-driver"
  BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+
+# GC320 support requires out-of-tree drivers not yet

available in bb.org 6.6

meta-beagle/conf/machine/include/beagle-bsp.inc +1 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
   # in mainline, usually present in TI staging or derivative like BB.org

  MACHINE_FEATURES:remove:bsp-mainline = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+

  # ==========

  # next
  # upcoming upstream/mainline kernel, u-boot
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
   # in next, usually present in TI staging or derivative like BB.org

  MACHINE_FEATURES:remove:bsp-next = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc BSP_BOOTLOADER_VERSION:bsp-next = "%" · line 42

Quoted 2 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +2 -0
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"

Andrew, Ryan,

Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got committed removing it for bsp-ti-6_12 twice:

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3

Was there any manual massaging involved?

Yes.  I did.  Let me look at it.

Fixed on master-wip, scarthgap-wip was correct.

bsp-ti-6_next ?

Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines

+
  # ==========

  # ti-6_12
  # TI staging kernel 6.12, u-boot 2024.10
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
   # in 6.12 yet

  MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+

  # ==========

  # ti-6_6
  # TI staging kernel 6.6, u-boot 2024.04
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+

  # ==========

  # ti-6_1
  # TI staging kernel 6.1, u-boot 2023.04
meta-ti-bsp/conf/machine/include/ti-bsp.inc +0 -0
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"

  BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
  BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"

meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+

  # ==========

  # sane fallback defaults
  # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2
#6 lore raw
Quoted 79 lines · Denys Dmytriyenko
Quoted 78 lines · Ryan Eatmon
Quoted 75 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 72 lines · Denys Dmytriyenko
Quoted 57 lines · Andrew Davis via lists.yoctoproject.org

Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet.

We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently.

---

Changes for v2:
  - Rebased on latest with new meta-beagle layer

   meta-beagle/conf/machine/include/beagle-bsp.inc |  6 ++++++
   meta-ti-bsp/conf/machine/include/ti-bsp.inc     | 15 +++++++++++++++
   2 files changed, 21 insertions(+)
meta-beagle/conf/machine/include/beagle-bsp.inc +1 -0
index 34889b41..06483ba9 100644
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
   BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
   BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
+# GC320 support requires out-of-tree drivers not yet

available in bb.org 6.1

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+
   # ==========
   # bb_org-6_6
   # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 =

"ti-img-rogue-driver"
  BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%" BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%" BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"

meta-beagle/conf/machine/include/beagle-bsp.inc +2 -0
+
+# GC320 support requires out-of-tree drivers not yet

available in bb.org 6.6

meta-beagle/conf/machine/include/beagle-bsp.inc +1 -0
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
meta-ti-bsp/conf/machine/include/ti-bsp.inc +3 -0
index 4bbe7668..6773bb7a 100644
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
   # in mainline, usually present in TI staging or derivative like BB.org
   MACHINE_FEATURES:remove:bsp-mainline = "gpu"
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+
   # ==========
   # next
   # upcoming upstream/mainline kernel, u-boot

meta-ti-bsp/conf/machine/include/ti-bsp.inc BSP_BOOTLOADER_VERSION:bsp-next = "%" · line 41

Quoted 4 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +2 -0
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
   # in next, usually present in TI staging or derivative like BB.org
   MACHINE_FEATURES:remove:bsp-next = "gpu"
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"

Andrew, Ryan,

Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got committed removing it for bsp-ti-6_12 twice:

https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Was there any manual massaging involved?

Yes.  I did.  Let me look at it.

Fixed on master-wip, scarthgap-wip was correct.

bsp-ti-6_next ?

Sigh... Fixed for real this time.

Quoted 34 lines
Quoted 34 lines
Quoted 34 lines
Quoted 34 lines
Quoted 34 lines
meta-ti-bsp/conf/machine/include/ti-bsp.inc +10 -0
+
   # ==========
   # ti-6_12
   # TI staging kernel 6.12, u-boot 2024.10
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
   # in 6.12 yet
   MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+
   # ==========
   # ti-6_6
   # TI staging kernel 6.6, u-boot 2024.04
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
   BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
   BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+
   # ==========
   # ti-6_1
   # TI staging kernel 6.1, u-boot 2023.04
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
   BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
   BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+
   # ==========
   # sane fallback defaults
   # if specific values are not defined or bsp is set incorrectly
Signature · 1 line
2.39.2
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS