Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
Subsystems (3)
PATCH 1/1 Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
Seems to cause stability issues for some users.
This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498.
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc.c +0 -6
@@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,copy_stream_update_to_stream (dc, context, stream, stream_update); -if (!dc->res_pool->funcs->validate_bandwidth (dc, context, false)) { -DC_ERROR ("Mode validation failed for stream update!\n" ); -dc_release_state (context); -return ; - } - commit_planes_for_stream( dc, srf_updates,
Signature · 6 lines
2.25.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 6 lines · Alex Deucher
Seems to cause stability issues for some users.
This reverts commit
a24eaa5c51255b344d5a321f1eeb3205f2775498.
I don't see the error in their log. How do we know this commit is actually causing the issue?
I don't really want to revert this commit because it means that we missed rejecting a commit during atomic check, meaning we're either going to get underflow on the screen or a pipe hang.
Regards,
Nicholas Kazlauskas
Quoted 12 lines
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------ 1 file changed, 6 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc.c +0
-0@@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,copy_stream_update_to_stream (dc, context, stream, stream_update);
drivers/gpu/drm/amd/display/dc/core/dc.c void dc_commit_updates_for_stream(struct dc *dc, · line 2612
Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc.c +0
-6-if (!dc->res_pool->funcs->validate_bandwidth (dc, context, false)) { -DC_ERROR ("Mode validation failed for stream update!\n" ); -dc_release_state (context); -return ; - } - commit_planes_for_stream( dc, srf_updates,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 7 lines · Nicholas
Quoted 6 lines · Alex Deucher
Seems to cause stability issues for some users.
This reverts commit
a24eaa5c51255b344d5a321f1eeb3205f2775498.
Quoted 8 lines
Quoted 1 line
Signed-off-by Alex Deucher <[email protected]>I don't see the error in their log. How do we know this commit is actually causing the issue?
I don't really want to revert this commit because it means that we missed rejecting a commit during atomic check, meaning we're either going to get underflow on the screen or a pipe hang.
Regards,
Nicholas Kazlauskas
Actually, we only want to be doing this on full updates - it's not a very fast operation. Not sure if this is causing their stability issue though.
Regards,
Nicholas Kazlauskas
Quoted 18 lines
Quoted 18 lines
---
drivers/gpu/drm/amd/display/dc/core/dc.c| 6 ------1 file changed, 6 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc.c +0
-6@@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc, copy_stream_update_to_stream(dc, context, stream, stream_update); - if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) { - DC_ERROR("Mode validation failed for stream update!\n"); - dc_release_state(context); - return; - } -commit_planes_for_stream(
Quoted 9 lines
Quoted 3 lines
dc,
srf_updates,_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 19 lines · Nicholas
Quoted 17 lines · Nicholas
Quoted 8 lines · Alex Deucher
Seems to cause stability issues for some users.
This reverts commit
a24eaa5c51255b344d5a321f1eeb3205f2775498.Bug:
https://gitlab.freedesktop.org/drm/amd/-/issues/1191Signed-off-by Alex Deucher <[email protected]>I don't see the error in their log. How do we know this commit is actually causing the issue?
I don't really want to revert this commit because it means that we missed rejecting a commit during atomic check, meaning we're either going to get underflow on the screen or a pipe hang.
Quoted 6 lines
Quoted 2 lines
Regards,
Nicholas KazlauskasActually, we only want to be doing this on full updates - it's not a very fast operation. Not sure if this is causing their stability issue though.
Maybe. Several people have reported reverting it fixes hangs. Maybe something in the validation code hangs? Maybe some sort of software deadlock?
Alex
Quoted 33 lines
Regards,
Nicholas KazlauskasQuoted 28 lines
Quoted 12 lines
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------ 1 file changed, 6 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc.c +0
-0@@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,copy_stream_update_to_stream (dc, context, stream, stream_update);drivers/gpu/drm/amd/display/dc/core/dc.c void dc_commit_updates_for_stream(struct dc *dc, · line 2611
Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc.c +0
-6-if (!dc->res_pool->funcs->validate_bandwidth (dc, context, false)) { -DC_ERROR ("Mode validation failed for stream update!\n" ); -dc_release_state (context); -return ; - } - commit_planes_for_stream( dc, srf_updates,_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx