client: Add SPDX License Identifer

PATCH Superseded [email protected] 4 participants 11 messages Sep 12, 2020 – Sep 14, 2020 1 message not in the archive Bluetooth drivers

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

[email protected]

author

2020-09-12 06:34 UTC #1 lore raw

PATCH 3/17 btio: Add SPDX License Identifier

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 2

License: GPL-2.0-or-later
btio/btio.h
btio/btio.c

---
 btio/btio.c | 1 +
 btio/btio.h | 1 +
 2 files changed, 2 insertions(+)

btio/btio.c +1 -0

index 844d6007f..42874e13c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

btio/btio.h +1 -0

index 23e0ef72b..e15f52a7c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

Signature · 1 line

2.25.4

[email protected]

2020-09-12 06:51 UTC #2 lore raw

RE: [BlueZ,03/17] btio: Add SPDX License Identifier

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'btio/btio.h', please use '/*' instead #31: FILE: btio/btio.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #31: FILE: btio/btio.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

- total: 0 errors, 2 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth

[email protected]

author

2020-09-12 06:29 UTC #3 lore raw

PATCH 4/17 client: Add SPDX License Identifer

In reply to a message not in the archive

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 9

License: GPL-2.0-or-later
client/advertising.h
client/display.c
client/main.c
client/display.h
client/agent.h
client/gatt.c
client/agent.c
client/advertising.c
client/gatt.h

---
 client/advertising.c | 1 +
 client/advertising.h | 1 +
 client/agent.c       | 1 +
 client/agent.h       | 1 +
 client/display.c     | 1 +
 client/display.h     | 1 +
 client/gatt.c        | 1 +
 client/gatt.h        | 1 +
 client/main.c        | 1 +
 9 files changed, 9 insertions(+)

client/advertising.c +1 -0

index 1aa28e749..2bba5eca5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/advertising.h +1 -0

index 9967e657b..b2c7a1244 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/agent.c +1 -0

index 4def1b478..b1e36e5d1 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/agent.h +1 -0

index 30f302cdc..3ee7526db 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/display.c +1 -0

index 05613865b..f3d451ed8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/display.h +1 -0

index e991d191a..9e416e9f8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/gatt.c +1 -0

index e5bab6dd0..3552491d8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/gatt.h +1 -0

index 09ca618d3..da347e06d 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

client/main.c +1 -0

index da877b546..abe0cf307 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

Signature · 1 line

2.25.4

[email protected]

2020-09-12 06:51 UTC #4 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/advertising.h', please use '/*' instead #38: FILE: client/advertising.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #38: FILE: client/advertising.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/agent.h', please use '/*' instead #56: FILE: client/agent.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #56: FILE: client/agent.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/display.h', please use '/*' instead #74: FILE: client/display.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #74: FILE: client/display.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/gatt.h', please use '/*' instead #92: FILE: client/gatt.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #92: FILE: client/gatt.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

- total: 0 errors, 8 warnings, 36 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth

[email protected]

author

2020-09-12 06:34 UTC #5 lore raw

PATCH 5/17 emulator: Add SPDX License Identifier

In reply to a message not in the archive

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
LGPL-2.1-or-later : 20
GPL-2.0-or-later : 2

License: LGPL-2.1-or-later
emulator/server.c
emulator/amp.c
emulator/hciemu.c
emulator/vhci.c
emulator/btdev.c
emulator/serial.h
emulator/le.h
emulator/le.c
emulator/main.c
emulator/amp.h
emulator/hciemu.h
emulator/bthost.h
emulator/btdev.h
emulator/vhci.h
emulator/serial.c
emulator/phy.c
emulator/smp.c
emulator/phy.h
emulator/bthost.c
emulator/server.h

License: GPL-2.0-or-later
emulator/b1ee.c
emulator/hfp.c

---
 emulator/amp.c    | 1 +
 emulator/amp.h    | 1 +
 emulator/b1ee.c   | 1 +
 emulator/btdev.c  | 1 +
 emulator/btdev.h  | 1 +
 emulator/bthost.c | 1 +
 emulator/bthost.h | 1 +
 emulator/hciemu.c | 1 +
 emulator/hciemu.h | 1 +
 emulator/hfp.c    | 1 +
 emulator/le.c     | 1 +
 emulator/le.h     | 1 +
 emulator/main.c   | 1 +
 emulator/phy.c    | 1 +
 emulator/phy.h    | 1 +
 emulator/serial.c | 1 +
 emulator/serial.h | 1 +
 emulator/server.c | 1 +
 emulator/server.h | 1 +
 emulator/smp.c    | 1 +
 emulator/vhci.c   | 1 +
 emulator/vhci.h   | 1 +
 22 files changed, 22 insertions(+)

emulator/amp.c +1 -0

index 605c6c825..33e6ff476 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/amp.h +1 -0

index 189dfb7d4..0c948a38c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/b1ee.c +1 -0

index 377181b01..d84b4587f 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/btdev.c +1 -0

index e9c3811f8..05bf76cb2 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/btdev.h +1 -0

index a9f71b281..7a6ca9571 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/bthost.c +1 -0

index 71d5f97bb..40a40ea3c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/bthost.h +1 -0

index 2b347136f..d190d38bc 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/hciemu.c +1 -0

index ac861cce2..ef5dc35d5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/hciemu.h +1 -0

index 4c8858bb6..5c70aa2fd 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/hfp.c +1 -0

index 29ec63e7d..533f6dbb4 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/le.c +1 -0

index 1c8ba280b..9980475b3 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/le.h +1 -0

index 5e832e8e5..7d977292c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/main.c +1 -0

index 75cb79c7b..9d613f75b 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/phy.c +1 -0

index beb8bbbe4..0711495fa 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/phy.h +1 -0

index d5efa5180..192bb567b 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/serial.c +1 -0

index 1c324d531..9ae73f102 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/serial.h +1 -0

index 4e5a56f88..75aff38cb 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/server.c +1 -0

index c28b15ebf..3fb348ac3 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/server.h +1 -0

index bf725e788..a169c4c09 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/smp.c +1 -0

index c30de3666..ae06ae9aa 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/vhci.c +1 -0

index f79b34f46..58ae0a5f8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

emulator/vhci.h +1 -0

index 1ec7191f8..dcb8860e2 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

Signature · 1 line

2.25.4

[email protected]

2020-09-12 06:51 UTC #6 lore raw

RE: [BlueZ,05/17] emulator: Add SPDX License Identifier

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/amp.h', please use '/*' instead #54: FILE: emulator/amp.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #54: FILE: emulator/amp.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/btdev.h', please use '/*' instead #81: FILE: emulator/btdev.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #81: FILE: emulator/btdev.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/bthost.h', please use '/*' instead #99: FILE: emulator/bthost.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #99: FILE: emulator/bthost.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/hciemu.h', please use '/*' instead #117: FILE: emulator/hciemu.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #117: FILE: emulator/hciemu.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/le.h', please use '/*' instead #144: FILE: emulator/le.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #144: FILE: emulator/le.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/phy.h', please use '/*' instead #171: FILE: emulator/phy.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #171: FILE: emulator/phy.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/serial.h', please use '/*' instead #189: FILE: emulator/serial.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #189: FILE: emulator/serial.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/server.h', please use '/*' instead #207: FILE: emulator/server.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #207: FILE: emulator/server.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'emulator/vhci.h', please use '/*' instead #234: FILE: emulator/vhci.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #234: FILE: emulator/vhci.h:1:
+// SPDX-License-Identifier: LGPL-2.1-or-later

- total: 0 errors, 18 warnings, 88 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth

[email protected]

author

2020-09-12 06:39 UTC #7 lore raw

PATCH 11/17 obexd: Add SPDX License Identifer

In reply to a message not in the archive

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 65

License: GPL-2.0-or-later
obexd/src/mimetype.c
obexd/src/transport.h
obexd/src/server.c
obexd/src/obex.c
obexd/src/log.h
obexd/src/service.h
obexd/src/plugin.h
obexd/src/plugin.c
obexd/src/main.c
obexd/src/mimetype.h
obexd/src/transport.c
obexd/src/obexd.h
obexd/src/obex.h
obexd/src/obex-priv.h
obexd/src/log.c
obexd/src/map_ap.h
obexd/src/manager.c
obexd/src/service.c
obexd/src/server.h
obexd/src/manager.h
obexd/plugins/opp.c
obexd/plugins/vcard.h
obexd/plugins/pbap.c
obexd/plugins/vcard.c
obexd/plugins/messages.h
obexd/plugins/phonebook.h
obexd/plugins/pcsuite.c
obexd/plugins/messages-tracker.c
obexd/plugins/phonebook-tracker.c
obexd/plugins/irmc.c
obexd/plugins/ftp.c
obexd/plugins/ftp.h
obexd/plugins/filesystem.c
obexd/plugins/messages-dummy.c
obexd/plugins/phonebook-ebook.c
obexd/plugins/syncevolution.c
obexd/plugins/bluetooth.c
obexd/plugins/phonebook-dummy.c
obexd/plugins/filesystem.h
obexd/plugins/mas.c
obexd/client/transport.h
obexd/client/opp.c
obexd/client/pbap.c
obexd/client/transfer.h
obexd/client/opp.h
obexd/client/driver.c
obexd/client/map-event.h
obexd/client/bluetooth.h
obexd/client/sync.h
obexd/client/transport.c
obexd/client/pbap.h
obexd/client/driver.h
obexd/client/transfer.c
obexd/client/ftp.c
obexd/client/map.h
obexd/client/ftp.h
obexd/client/bluetooth.c
obexd/client/manager.c
obexd/client/session.h
obexd/client/session.c
obexd/client/map.c
obexd/client/sync.c
obexd/client/map-event.c
obexd/client/mns.c
obexd/client/manager.h

---
 obexd/client/bluetooth.c          | 1 +
 obexd/client/bluetooth.h          | 1 +
 obexd/client/driver.c             | 1 +
 obexd/client/driver.h             | 1 +
 obexd/client/ftp.c                | 1 +
 obexd/client/ftp.h                | 1 +
 obexd/client/manager.c            | 1 +
 obexd/client/manager.h            | 1 +
 obexd/client/map-event.c          | 1 +
 obexd/client/map-event.h          | 1 +
 obexd/client/map.c                | 1 +
 obexd/client/map.h                | 1 +
 obexd/client/mns.c                | 1 +
 obexd/client/opp.c                | 1 +
 obexd/client/opp.h                | 1 +
 obexd/client/pbap.c               | 1 +
 obexd/client/pbap.h               | 1 +
 obexd/client/session.c            | 1 +
 obexd/client/session.h            | 1 +
 obexd/client/sync.c               | 1 +
 obexd/client/sync.h               | 1 +
 obexd/client/transfer.c           | 1 +
 obexd/client/transfer.h           | 1 +
 obexd/client/transport.c          | 1 +
 obexd/client/transport.h          | 1 +
 obexd/plugins/bluetooth.c         | 1 +
 obexd/plugins/filesystem.c        | 1 +
 obexd/plugins/filesystem.h        | 1 +
 obexd/plugins/ftp.c               | 1 +
 obexd/plugins/ftp.h               | 1 +
 obexd/plugins/irmc.c              | 1 +
 obexd/plugins/mas.c               | 1 +
 obexd/plugins/messages-dummy.c    | 1 +
 obexd/plugins/messages-tracker.c  | 1 +
 obexd/plugins/messages.h          | 1 +
 obexd/plugins/opp.c               | 1 +
 obexd/plugins/pbap.c              | 1 +
 obexd/plugins/pcsuite.c           | 1 +
 obexd/plugins/phonebook-dummy.c   | 1 +
 obexd/plugins/phonebook-ebook.c   | 1 +
 obexd/plugins/phonebook-tracker.c | 1 +
 obexd/plugins/phonebook.h         | 1 +
 obexd/plugins/syncevolution.c     | 1 +
 obexd/plugins/vcard.c             | 1 +
 obexd/plugins/vcard.h             | 1 +
 obexd/src/log.c                   | 1 +
 obexd/src/log.h                   | 1 +
 obexd/src/main.c                  | 1 +
 obexd/src/manager.c               | 1 +
 obexd/src/manager.h               | 1 +
 obexd/src/map_ap.h                | 1 +
 obexd/src/mimetype.c              | 1 +
 obexd/src/mimetype.h              | 1 +
 obexd/src/obex-priv.h             | 1 +
 obexd/src/obex.c                  | 1 +
 obexd/src/obex.h                  | 1 +
 obexd/src/obexd.h                 | 1 +
 obexd/src/plugin.c                | 1 +
 obexd/src/plugin.h                | 1 +
 obexd/src/server.c                | 1 +
 obexd/src/server.h                | 1 +
 obexd/src/service.c               | 1 +
 obexd/src/service.h               | 1 +
 obexd/src/transport.c             | 1 +
 obexd/src/transport.h             | 1 +
 65 files changed, 65 insertions(+)

obexd/client/bluetooth.c +1 -0

index 0c043e0ac..d7100a36c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/bluetooth.h +1 -0

index 968e131e0..1d1e85c68 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/driver.c +1 -0

index 0dae35601..773a6efe4 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/client/driver.h +1 -0

index 0112219d5..a503a1751 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/client/ftp.c +1 -0

index 5e30654af..b260dc298 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/ftp.h +1 -0

index 3d9096863..280872bd0 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/manager.c +1 -0

index fbcad6da4..4782203e0 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/manager.h +1 -0

index e4068de44..d8fed0c83 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/client/map-event.c +1 -0

index e164e863c..7b7e227e5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX

obexd/client/map-event.h +1 -0

index 5414b2621..db7cc0a20 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX

obexd/client/map.c +1 -0

index 23be2d6b2..e352499a3 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/map.h +1 -0

index 86f6b9512..eadd8371a 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/mns.c +1 -0

index 4912cb90f..47c75c8e1 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/client/opp.c +1 -0

index 92785f66e..4a08540f7 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/opp.h +1 -0

index a23e94e00..3c727ddd8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/pbap.c +1 -0

index 3f5665fcd..1b1edb1ea 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/pbap.h +1 -0

index ce56258b5..b28a6bf09 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/session.c +1 -0

index 5bd2d2670..43e86551e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/session.h +1 -0

index b561b7e58..aebc17d21 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/sync.c +1 -0

index 548c318c3..90a2bcb0e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/sync.h +1 -0

index 8adc5f8d6..2e6e628c7 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/transfer.c +1 -0

index b53dffa21..489c03743 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/transfer.h +1 -0

index b6b835d18..dea9e97ca 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Client

obexd/client/transport.c +1 -0

index 4cd770672..3467f7001 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/client/transport.h +1 -0

index b035cfc45..e9f7d1193 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/bluetooth.c +1 -0

index ba1e0a99a..955616010 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/filesystem.c +1 -0

index 48239a8bc..e50338fb3 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/filesystem.h +1 -0

index f95773beb..397d74673 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/ftp.c +1 -0

index 3ee18a619..cf58cd3a8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/ftp.h +1 -0

index f06de8490..8de21ac2c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/irmc.c +1 -0

index fcf5340e7..782afb485 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX IrMC Sync Server

obexd/plugins/mas.c +1 -0

index f73c3e9d8..ac379d622 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/messages-dummy.c +1 -0

index 3eca9ef4c..63632c9c3 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/messages-tracker.c +1 -0

index 60f3a807e..3d0a20069 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/messages.h +1 -0

index 00a16b1ae..83a45cb43 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/opp.c +1 -0

index 5bb766770..c0747856f 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/pbap.c +1 -0

index d5a3046ae..0dc5e4cfc 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/pcsuite.c +1 -0

index 43ab409e9..1b37f3e81 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/phonebook-dummy.c +1 -0

index 9279ef29a..edcacf420 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/phonebook-ebook.c +1 -0

index c422585df..2230148d6 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/phonebook-tracker.c +1 -0

index c1d14078b..ea1811786 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Phonebook access through D-Bus vCard and call history service
  *

obexd/plugins/phonebook.h +1 -0

index 70a9cb797..28110a971 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/syncevolution.c +1 -0

index 854505a58..32e772a1e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/plugins/vcard.c +1 -0

index dc7c3b3e6..40269f4e2 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * OBEX Server
  *

obexd/plugins/vcard.h +1 -0

index 22c3f6899..933636fa7 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * OBEX Server
  *

obexd/src/log.c +1 -0

index 8e2ebaab2..769c7183c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/log.h +1 -0

index d9fb8678f..e0b69bd50 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/main.c +1 -0

index 139f1412c..462fd796c 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/manager.c +1 -0

index a4af627cb..a3cbd3fa9 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/manager.h +1 -0

index d709af5a8..ffabd7608 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/map_ap.h +1 -0

index da108fe6e..40664c89d 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/mimetype.c +1 -0

index c8b040a43..7dac1ee98 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/mimetype.h +1 -0

index 79529b890..6cba7507b 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/obex-priv.h +1 -0

index 355a7f87b..8fe936e0d 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/obex.c +1 -0

index 2850d3a37..d9b6b93d4 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/obex.h +1 -0

index 67593f11b..5acb333fd 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/obexd.h +1 -0

index 42c3c4d97..0f2805c4e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/plugin.c +1 -0

index a1962b91d..fcfd0b182 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/plugin.h +1 -0

index 13d77695f..4d824a4f5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/server.c +1 -0

index db854233b..5e3ed7283 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/server.h +1 -0

index 278c35fce..222b2ef80 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/service.c +1 -0

index c088535e9..faa39329f 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/service.h +1 -0

index 5d9d325fb..57fc95897 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/transport.c +1 -0

index 4984643e2..b6b7f7a61 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

obexd/src/transport.h +1 -0

index 97e10d05f..948b97cf2 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  OBEX Server

Signature · 1 line

2.25.4

[email protected]

2020-09-12 06:51 UTC #8 lore raw

RE: [BlueZ,11/17] obexd: Add SPDX License Identifer

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/bluetooth.h', please use '/*' instead #94: FILE: obexd/client/bluetooth.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #94: FILE: obexd/client/bluetooth.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/driver.h', please use '/*' instead #112: FILE: obexd/client/driver.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #112: FILE: obexd/client/driver.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/ftp.h', please use '/*' instead #130: FILE: obexd/client/ftp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #130: FILE: obexd/client/ftp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/manager.h', please use '/*' instead #148: FILE: obexd/client/manager.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #148: FILE: obexd/client/manager.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/map-event.h', please use '/*' instead #166: FILE: obexd/client/map-event.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #166: FILE: obexd/client/map-event.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/map.h', please use '/*' instead #184: FILE: obexd/client/map.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #184: FILE: obexd/client/map.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/opp.h', please use '/*' instead #211: FILE: obexd/client/opp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #211: FILE: obexd/client/opp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/pbap.h', please use '/*' instead #229: FILE: obexd/client/pbap.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #229: FILE: obexd/client/pbap.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/session.h', please use '/*' instead #247: FILE: obexd/client/session.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #247: FILE: obexd/client/session.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/sync.h', please use '/*' instead #265: FILE: obexd/client/sync.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #265: FILE: obexd/client/sync.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/transfer.h', please use '/*' instead #283: FILE: obexd/client/transfer.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #283: FILE: obexd/client/transfer.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/client/transport.h', please use '/*' instead #301: FILE: obexd/client/transport.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #301: FILE: obexd/client/transport.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/filesystem.h', please use '/*' instead #328: FILE: obexd/plugins/filesystem.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #328: FILE: obexd/plugins/filesystem.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/ftp.h', please use '/*' instead #346: FILE: obexd/plugins/ftp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #346: FILE: obexd/plugins/ftp.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/messages.h', please use '/*' instead #391: FILE: obexd/plugins/messages.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #391: FILE: obexd/plugins/messages.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/phonebook.h', please use '/*' instead #454: FILE: obexd/plugins/phonebook.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #454: FILE: obexd/plugins/phonebook.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/plugins/vcard.h', please use '/*' instead #481: FILE: obexd/plugins/vcard.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #481: FILE: obexd/plugins/vcard.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/log.h', please use '/*' instead #499: FILE: obexd/src/log.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #499: FILE: obexd/src/log.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/manager.h', please use '/*' instead #526: FILE: obexd/src/manager.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #526: FILE: obexd/src/manager.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/map_ap.h', please use '/*' instead #535: FILE: obexd/src/map_ap.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #535: FILE: obexd/src/map_ap.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/mimetype.h', please use '/*' instead #553: FILE: obexd/src/mimetype.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #553: FILE: obexd/src/mimetype.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obex-priv.h', please use '/*' instead #562: FILE: obexd/src/obex-priv.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #562: FILE: obexd/src/obex-priv.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obex.h', please use '/*' instead #580: FILE: obexd/src/obex.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #580: FILE: obexd/src/obex.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/obexd.h', please use '/*' instead #589: FILE: obexd/src/obexd.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #589: FILE: obexd/src/obexd.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/plugin.h', please use '/*' instead #607: FILE: obexd/src/plugin.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #607: FILE: obexd/src/plugin.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/server.h', please use '/*' instead #625: FILE: obexd/src/server.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #625: FILE: obexd/src/server.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/service.h', please use '/*' instead #643: FILE: obexd/src/service.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #643: FILE: obexd/src/service.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'obexd/src/transport.h', please use '/*' instead #661: FILE: obexd/src/transport.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #661: FILE: obexd/src/transport.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later

- total: 0 errors, 56 warnings, 260 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth

[email protected]

author

2020-09-12 06:39 UTC #9 lore raw

PATCH 13/17 plugins: Add SPDX License Identifer

In reply to a message not in the archive

From: Tedd Ho-Jeong An <[email protected]>

This patch adds SPDX License Identifier.

-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 7

License: GPL-2.0-or-later
plugins/autopair.c
plugins/hostname.c
plugins/neard.c
plugins/policy.c
plugins/sixaxis.c
plugins/wiimote.c
plugins/external-dummy.c

---
 plugins/autopair.c       | 1 +
 plugins/external-dummy.c | 1 +
 plugins/hostname.c       | 1 +
 plugins/neard.c          | 1 +
 plugins/policy.c         | 1 +
 plugins/sixaxis.c        | 1 +
 plugins/wiimote.c        | 1 +
 7 files changed, 7 insertions(+)

plugins/autopair.c +1 -0

index 3089430a8..381d91c8f 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/external-dummy.c +1 -0

index 536ad0663..78377b021 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/hostname.c +1 -0

index 4f9dfe6d8..32f15b3a5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/neard.c +1 -0

index 6ffcd6e10..1fefc5015 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/policy.c +1 -0

index de51e58b9..86eb25ee9 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/sixaxis.c +1 -0

index 939fed759..8350d63f8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/wiimote.c +1 -0

index 0ced27514..9441a7681 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

Signature · 1 line

2.25.4

Luiz Augusto von Dentz

maintainer

2020-09-14 17:33 UTC #10 lore raw

Re: [BlueZ 13/17] plugins: Add SPDX License Identifer

Hi Tedd,

Quoted 9 lines · On Fri, Sep 11, 2020 at 11:41 PM <[email protected]> wrote:

From: Tedd Ho-Jeong An <[email protected]>
This patch adds SPDX License Identifier.
-------------------------------------
License COUNT
-------------------------------------
GPL-2.0-or-later : 7

I guess all GPL 2.0 or later can be updated to GPL 2.1 or later.

Quoted 23 lines

License: GPL-2.0-or-later
plugins/autopair.c
plugins/hostname.c
plugins/neard.c
plugins/policy.c
plugins/sixaxis.c
plugins/wiimote.c
plugins/external-dummy.c
---
 plugins/autopair.c       | 1 +
 plugins/external-dummy.c | 1 +
 plugins/hostname.c       | 1 +
 plugins/neard.c          | 1 +
 plugins/policy.c         | 1 +
 plugins/sixaxis.c        | 1 +
 plugins/wiimote.c        | 1 +
 7 files changed, 7 insertions(+)
plugins/autopair.c +0 -0
index 3089430a8..381d91c8f 100644

plugins/autopair.c line 1

Quoted 1 line

plugins/autopair.c +1 -0

@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later

Why are you using C++ // comments on the .c files and /* */ comments on .h? Also it looks like you are keeping the old license text which should no longer be necessary.

Quoted 60 lines

plugins/autopair.c +0 -0

 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/external-dummy.c +1 -0

index 536ad0663..78377b021 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/hostname.c +1 -0

index 4f9dfe6d8..32f15b3a5 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/neard.c +1 -0

index 6ffcd6e10..1fefc5015 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/policy.c +1 -0

index de51e58b9..86eb25ee9 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/sixaxis.c +1 -0

index 939fed759..8350d63f8 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux

plugins/wiimote.c +1 -1

index 0ced27514..9441a7681 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *
  *  BlueZ - Bluetooth protocol stack for Linux
--

2.25.4

Signature · 1 line

Luiz Augusto von Dentz

An, Tedd

2020-09-14 20:27 UTC #11 lore raw

Re: [BlueZ 13/17] plugins: Add SPDX License Identifer

Hi Luiz,

I realized that there is no GPL 2.1 or later.

Only for LGPL 2.1 or later...
I will keep as is.

Regards,
Tedd

On 9/14/20, 10:33 AM, "Luiz Augusto von Dentz" <[email protected]> wrote:

    Hi Tedd,

    On Fri, Sep 11, 2020 at 11:41 PM <[email protected]> wrote:
    >
    > From: Tedd Ho-Jeong An <[email protected]>
    >
    > This patch adds SPDX License Identifier.
    >
    > -------------------------------------
    >        License            COUNT
    > -------------------------------------
    >  GPL-2.0-or-later     :      7

    I guess all GPL 2.0 or later can be updated to GPL 2.1 or later.

    > License: GPL-2.0-or-later
    >    plugins/autopair.c
    >    plugins/hostname.c
    >    plugins/neard.c
    >    plugins/policy.c
    >    plugins/sixaxis.c
    >    plugins/wiimote.c
    >    plugins/external-dummy.c
    > ---
    >  plugins/autopair.c       | 1 +
    >  plugins/external-dummy.c | 1 +
    >  plugins/hostname.c       | 1 +
    >  plugins/neard.c          | 1 +
    >  plugins/policy.c         | 1 +
    >  plugins/sixaxis.c        | 1 +
    >  plugins/wiimote.c        | 1 +
    >  7 files changed, 7 insertions(+)
    >
    > diff --git a/plugins/autopair.c b/plugins/autopair.c
    > index 3089430a8..381d91c8f 100644
    > --- a/plugins/autopair.c
    > +++ b/plugins/autopair.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later

    Why are you using C++ // comments on the .c files and /* */ comments
    on .h? Also it looks like you are keeping the old license text which
    should no longer be necessary.

    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/external-dummy.c b/plugins/external-dummy.c
    > index 536ad0663..78377b021 100644
    > --- a/plugins/external-dummy.c
    > +++ b/plugins/external-dummy.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/hostname.c b/plugins/hostname.c
    > index 4f9dfe6d8..32f15b3a5 100644
    > --- a/plugins/hostname.c
    > +++ b/plugins/hostname.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/neard.c b/plugins/neard.c
    > index 6ffcd6e10..1fefc5015 100644
    > --- a/plugins/neard.c
    > +++ b/plugins/neard.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/policy.c b/plugins/policy.c
    > index de51e58b9..86eb25ee9 100644
    > --- a/plugins/policy.c
    > +++ b/plugins/policy.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
    > index 939fed759..8350d63f8 100644
    > --- a/plugins/sixaxis.c
    > +++ b/plugins/sixaxis.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > diff --git a/plugins/wiimote.c b/plugins/wiimote.c
    > index 0ced27514..9441a7681 100644
    > --- a/plugins/wiimote.c
    > +++ b/plugins/wiimote.c
    > @@ -1,3 +1,4 @@
    > +// SPDX-License-Identifier: GPL-2.0-or-later
    >  /*
    >   *
    >   *  BlueZ - Bluetooth protocol stack for Linux
    > --
    > 2.25.4
    >


    -- 
    Luiz Augusto von Dentz