vp_vdpa: synchronize irq when free irq
PATCH 1/1 vp_vdpa: synchronize irq when free irq
This commits synchronizes irqs when free them
--- drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/vdpa/virtio_pci/vp_vdpa.c +2 -0
@@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)for (i =0 ; i < vp_vdpa->queues; i++) {if (vp_vdpa->vring[i].irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_queue_vector (mdev, i,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->vring[i].irq);devm_free_irq (&pdev->dev, vp_vdpa->vring[i].irq, &vp_vdpa->vring[i]); vp_vdpa->vring[i].irq =VIRTIO_MSI_NO_VECTOR ;
@@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)if (vp_vdpa->config_irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_config_vector (mdev,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->config_irq);devm_free_irq (&pdev->dev, vp_vdpa->config_irq, vp_vdpa); vp_vdpa->config_irq =VIRTIO_MSI_NO_VECTOR ; }
Signature · 6 lines
2.39.3 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 2 lines · Zhu Lingshan
This commits synchronizes irqs when free them
Need to explain why it is needed.
Quoted 12 lines
Signed-off-by Zhu Lingshan <[email protected]>Tested-by Cindy Lu <[email protected]>--- drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)drivers/vdpa/virtio_pci/vp_vdpa.c +0
-0
drivers/vdpa/virtio_pci/vp_vdpa.c static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa) · line 119
Quoted 4 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)for (i =0 ; i < vp_vdpa->queues; i++) {if (vp_vdpa->vring[i].irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_queue_vector (mdev, i,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->vring[i].irq);
Interestingly, we don't do this in virtio_pci_common.c and we only synchronize during reset there.
Any reason makes vp_vdpa different?
Thanks
Quoted 12 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-1devm_free_irq (&pdev->dev, vp_vdpa->vring[i].irq, &vp_vdpa->vring[i]); vp_vdpa->vring[i].irq =VIRTIO_MSI_NO_VECTOR ;@@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)if (vp_vdpa->config_irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_config_vector (mdev,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->config_irq);devm_free_irq (&pdev->dev, vp_vdpa->config_irq, vp_vdpa); vp_vdpa->config_irq =VIRTIO_MSI_NO_VECTOR ; } --
Quoted 2 lines
2.39.3
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 22 lines · Jason Wang
Quoted 1 line · Zhu Lingshan
This commits synchronizes irqs when free them
Need to explain why it is needed.
Quoted 11 lines
Signed-off-by Zhu Lingshan <[email protected]>Tested-by Cindy Lu <[email protected]>--- drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)drivers/vdpa/virtio_pci/vp_vdpa.c +0
-0drivers/vdpa/virtio_pci/vp_vdpa.c static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa) · line 119
Quoted 4 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)for (i =0 ; i < vp_vdpa->queues; i++) {if (vp_vdpa->vring[i].irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_queue_vector (mdev, i,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->vring[i].irq);Interestingly, we don't do this in
virtio_pci_common.cand we only synchronize during reset there.
Quoted 1 line
Any reason makes
vp_vdpadifferent?
As Michael point out, free_irq calls synchronize_irq internally. And this vp_vdpa_free irq is called in the reset routine. So I think we don't need to sync it here.
Quoted 8 lines
Thanks
Quoted 5 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +0
-0devm_free_irq (&pdev->dev, vp_vdpa->vring[i].irq, &vp_vdpa->vring[i]); vp_vdpa->vring[i].irq =VIRTIO_MSI_NO_VECTOR ;@@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)
Quoted 9 lines
Quoted 9 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-1if (vp_vdpa->config_irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_config_vector (mdev,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->config_irq);devm_free_irq (&pdev->dev, vp_vdpa->config_irq, vp_vdpa); vp_vdpa->config_irq =VIRTIO_MSI_NO_VECTOR ; } --2.39.3
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerQuoted 21 lines · Zhu Lingshan
This commits synchronizes irqs when free them
Signed-off-by Zhu Lingshan <[email protected]>Tested-by Cindy Lu <[email protected]>--- drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)for (i =0 ; i < vp_vdpa->queues; i++) {if (vp_vdpa->vring[i].irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_queue_vector (mdev, i,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->vring[i].irq);devm_free_irq (&pdev->dev, vp_vdpa->vring[i].irq, &vp_vdpa->vring[i]); vp_vdpa->vring[i].irq =VIRTIO_MSI_NO_VECTOR ;
drivers/vdpa/virtio_pci/vp_vdpa.c static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa) · line 130
Quoted 6 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)if (vp_vdpa->config_irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_config_vector (mdev,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->config_irq);devm_free_irq (&pdev->dev, vp_vdpa->config_irq, vp_vdpa); vp_vdpa->config_irq =VIRTIO_MSI_NO_VECTOR ;
Weird, doesn't free_irq synchronize automatically?
Quoted 3 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +0
-0}Signature · 1 line
2.39.3
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 23 lines · Michael S. Tsirkin
Quoted 22 lines · Zhu Lingshan
This commits synchronizes irqs when free them
Signed-off-by Zhu Lingshan <[email protected]>Tested-by Cindy Lu <[email protected]>--- drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)for (i =0 ; i < vp_vdpa->queues; i++) {if (vp_vdpa->vring[i].irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_queue_vector (mdev, i,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->vring[i].irq);devm_free_irq (&pdev->dev, vp_vdpa->vring[i].irq, &vp_vdpa->vring[i]); vp_vdpa->vring[i].irq =VIRTIO_MSI_NO_VECTOR ;@@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)
Quoted 7 lines
drivers/vdpa/virtio_pci/vp_vdpa.c static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa) · line 130
Quoted 5 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0if (vp_vdpa->config_irq !=VIRTIO_MSI_NO_VECTOR ) {vp_modern_config_vector (mdev,VIRTIO_MSI_NO_VECTOR ); +synchronize_irq (vp_vdpa->config_irq);devm_free_irq (&pdev->dev, vp_vdpa->config_irq, vp_vdpa); vp_vdpa->config_irq =VIRTIO_MSI_NO_VECTOR ;Weird, doesn't
free_irqsynchronize automatically?
Oh, I see free_irq calls __syncronize_hardirq internally
Thanks
Quoted 4 lines
Quoted 4 lines
drivers/vdpa/virtio_pci/vp_vdpa.c +0
-0}Signature · 1 line
2.39.3
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization