Skip to contentSkip to conversation

hw/usb/canokey: change license to GPLv2+

PATCH In review Hongren (Zenithal) Zheng 4 participants 4 messages Apr 30, 2023 – May 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/usb/canokey: change license to GPLv2+

Apache license is considered by some to be not compatible with GPLv2+. Since QEMU as combined work is GPLv2-only, these two files should be made compatible.

---
 hw/usb/canokey.c | 2 +-
 hw/usb/canokey.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/usb/canokey.c +1 -1
index bbc5da07b5..b306eeb20e 100644
@@ -4,7 +4,7 @@
  * Copyright (c) 2021-2022 Canokeys.org <[email protected]>
  * Written by Hongren (Zenithal) Zheng <[email protected]>
  *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
  */
 
 #include "qemu/osdep.h"
hw/usb/canokey.h +1 -1
index 24cf304203..e528889d33 100644
@@ -4,7 +4,7 @@
  * Copyright (c) 2021-2022 Canokeys.org <[email protected]>
  * Written by Hongren (Zenithal) Zheng <[email protected]>
  *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
  */
 
 #ifndef CANOKEY_H
Signature · 1 line
2.37.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Hongren (Zenithal) Zheng

Apache license is considered by some to be not compatible with GPLv2+. Since QEMU as combined work is GPLv2-only, these two files should be made compatible.

---
  hw/usb/canokey.c | 2 +-
  hw/usb/canokey.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Thank you!

#2 lore raw
In reply to Hongren (Zenithal) Zheng

Apache license is considered by some to be not compatible

Quoted 40 lines

with GPLv2+. Since QEMU as combined work is GPLv2-only, these two files should be made compatible.

---
hw/usb/canokey.c | 2 +-
hw/usb/canokey.h | 2 +-

2 files changed, 2 insertions(+), 2 deletions(-)
hw/usb/canokey.c +1 -1
index bbc5da07b5..b306eeb20e 100644
@@ -4,7 +4,7 @@
   * Copyright (c) 2021-2022Canokeys.org<http://Canokeys.org><[email protected]>
   * Written by Hongren (Zenithal) Zheng <[email protected]>
   *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
   */


#include "qemu/osdep.h"

hw/usb/canokey.h +1 -1
index 24cf304203..e528889d33 100644
@@ -4,7 +4,7 @@
   * Copyright (c) 2021-2022Canokeys.org<http://Canokeys.org><[email protected]>
   * Written by Hongren (Zenithal) Zheng <[email protected]>
   *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
   */


#ifndef CANOKEY_H
--
2.37.2

Acked-by on v1 1/1
#3 lore raw
In reply to Hongren (Zenithal) Zheng
Quoted 7 lines · Hongren (Zenithal) Zheng

Apache license is considered by some to be not compatible with GPLv2+. Since QEMU as combined work is GPLv2-only, these two files should be made compatible.

Quoted 34 lines
---
 hw/usb/canokey.c | 2 +-
 hw/usb/canokey.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/usb/canokey.c +1 -1
index bbc5da07b5..b306eeb20e 100644
@@ -4,7 +4,7 @@
  * Copyright (c) 2021-2022 Canokeys.org <[email protected]>
  * Written by Hongren (Zenithal) Zheng <[email protected]>
  *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
  */
 
 #include "qemu/osdep.h"
hw/usb/canokey.h +1 -1
index 24cf304203..e528889d33 100644
@@ -4,7 +4,7 @@
  * Copyright (c) 2021-2022 Canokeys.org <[email protected]>
  * Written by Hongren (Zenithal) Zheng <[email protected]>
  *
- * This code is licensed under the Apache-2.0.
+ * This code is licensed under the GPL v2 or later.
  */
 
 #ifndef CANOKEY_H
Signature · 1 line
2.37.2