Skip to contentSkip to conversation

x86/boot: Simplify BSS zeroing

PATCH In review Andrew Cooper 2 participants 2 messages Jan 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/boot: Simplify BSS zeroing

There is no need to load a non-flat %es to zero the BSS. Use sym_esi() instead, which is easier to follow, faster (avoids two segment loads) and doesn't require use of the stack.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>

Looking through the code, almost everything that uses sym_fs() would be better using sym_esi(). It is unnecessary extra instruction stream bytes, and AGU hit for every memory operand.

Most importantly however, the code is far more simple to reason about when it is consitent about being flat, rather than mixing and matching between flat and non-flat views of the same memory.

---
 xen/arch/x86/boot/head.S | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
xen/arch/x86/boot/head.S +2 -6
index 82395e91dd..1b729c37f8 100644
@@ -617,16 +617,12 @@ trampoline_setup:
         jnz     1f
 
         /* Initialize BSS (no nasty surprises!). */
-        mov     $sym_offs(__bss_start),%edi
-        mov     $sym_offs(__bss_end),%ecx
-        push    %fs
-        pop     %es
+        lea     sym_esi(__bss_start), %edi
+        lea     sym_esi(__bss_end), %ecx
         sub     %edi,%ecx
         xor     %eax,%eax
         shr     $2,%ecx
         rep stosl
-        push    %ds
-        pop     %es
 
 1:
         /* Interrogate CPU extended features via CPUID. */
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Andrew Cooper

There is no need to load a non-flat %es to zero the BSS. Use sym_esi() instead, which is easier to follow, faster (avoids two segment loads) and doesn't require use of the stack.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel