ref-manual/variables.rst: fix wording in COMPATIBLE_MACHINE note
PATCH 1/1 ref-manual/variables.rst: fix wording in COMPATIBLE_MACHINE note
Add missing "that" between "recipe" and "inherits".
--- documentation/ref-manual/variables.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/variables.rst +1 -1
@@ -1679,7 +1679,7 @@ system and gives an overview of their function and contents. .. note:: - When :term:`COMPATIBLE_MACHINE` is set in a recipe inherits from + When :term:`COMPATIBLE_MACHINE` is set in a recipe that inherits from native, the recipe is always skipped. All native recipes must be entirely target independent and should not rely on :term:`MACHINE`.
Signature · 1 line
2.47.0
Hi João,
Quoted 12 lines · Joao Marcos Costa via lists.yoctoproject.org
Add missing "that" between "recipe" and "inherits".
Signed-off-by João Marcos Costa <[email protected]>--- documentation/ref-manual/variables.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 1683
Quoted 6 lines
documentation/ref-manual/variables.rst +1
-1@@ -1679,7 +1679,7 @@ system and gives an overview of their function and contents. .. note:: - When :term:`COMPATIBLE_MACHINE` is set in a recipe inherits from + When :term:`COMPATIBLE_MACHINE` is set in a recipe that inherits from native, the recipe is always skipped. All native recipes must be
Doesn't read well to me still. I would say maybe go for
"in a native recipe"
What do you think?
Cheers,
Quentin
Hello, Quentin
Quoted 25 lines · Quentin Schulz via lists.yoctoproject.org
Hi João,
Quoted 12 lines · Joao Marcos Costa via lists.yoctoproject.org
Add missing "that" between "recipe" and "inherits".
Signed-off-by João Marcos Costa <[email protected]>---
documentation/ref-manual/variables.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)documentation/ref-manual/variables.rst +0
-0@@ -1679,7 +1679,7 @@ system and gives an overview of their functionQuoted 7 lines
and contents.
.. note::
- When :term:COMPATIBLE_MACHINEis set in a recipe inherits from
+ When :term:COMPATIBLE_MACHINEis set in a recipe that inherits from
native, the recipe is always skipped. All native recipes must beDoesn't read well to me still. I would say maybe go for
Quoted 6 lines
"in a native recipe"
What do you think?
Cheers,
Quentin
I like the current phrasing, to be honest. My only concern about it is the grammar, so my goal here is to provide a plain fix rather than a subjective improvement in semantics.
Thanks for the review!
Signature · 2 lines
Best regards, João Marcos Costa
Quoted 28 lines · Joao Marcos Costa
Hello, Quentin
Quoted 25 lines · Quentin Schulz via lists.yoctoproject.org
Hi João,
Quoted 12 lines · Joao Marcos Costa via lists.yoctoproject.org
Add missing "that" between "recipe" and "inherits".
Signed-off-by João Marcos Costa <[email protected]>---
documentation/ref-manual/variables.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)documentation/ref-manual/variables.rst +0
-0@@ -1679,7 +1679,7 @@ system and gives an overview of their functionQuoted 7 lines
and contents.
.. note::
- When :term:COMPATIBLE_MACHINEis set in a recipe inherits from
+ When :term:COMPATIBLE_MACHINEis set in a recipe that inherits from
native, the recipe is always skipped. All native recipes must beDoesn't read well to me still. I would say maybe go for
Quoted 9 lines
Quoted 6 lines
"in a native recipe"
What do you think?
Cheers,
QuentinI like the current phrasing, to be honest. My only concern about it is the grammar, so my goal here is to provide a plain fix rather than a subjective improvement in semantics.
inherits from native doesn't mean anything. A recipe can inherit the native class, but even then, that's not the only way for a recipe to be native, see https://docs.yoctoproject.org/ref-manual/classes.html#native. In the BBCLASSEXTEND, it'll technically inherit the native class but not via the inherit directive.
What matters here is that in the native context of a recipe, COMPATIBLE_MACHINE if set will make BitBake skip the native variant of the recipe.
Cheers,
Quentin