drm/amdgpu: force to use CPU_ACCESS hint optimization
Subsystems (2)
PATCH 1/1 drm/amdgpu: force to use CPU_ACCESS hint optimization
As we know, visible vram can be placed to invisible when no cpu access.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +3 -5
@@ -592,8 +592,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file vram_gtt.vram_size = adev->gmc.real_vram_size -atomic64_read (&adev->vram_pin_size); - vram_gtt.vram_cpu_accessible_size = adev->gmc.visible_vram_size - -atomic64_read (&adev->visible_pin_size); + vram_gtt.vram_cpu_accessible_size = vram_gtt.vram_size; vram_gtt.gtt_size = adev->mman.bdev.man[TTM_PL_TT ].size; vram_gtt.gtt_size *=PAGE_SIZE ; vram_gtt.gtt_size -=atomic64_read (&adev->gart_pin_size);
@@ -612,9 +611,8 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file mem.vram.max_allocation = mem.vram.usable_heap_size *3 /4 ; mem.cpu_accessible_vram.total_heap_size = - adev->gmc.visible_vram_size; - mem.cpu_accessible_vram.usable_heap_size = adev->gmc.visible_vram_size - -atomic64_read (&adev->visible_pin_size); + mem.vram.total_heap_size; + mem.cpu_accessible_vram.usable_heap_size = mem.vram.usable_heap_size; mem.cpu_accessible_vram.heap_usage =amdgpu_vram_mgr_vis_usage (&adev->mman.bdev.man[TTM_PL_VRAM ]); mem.cpu_accessible_vram.max_allocation =
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Am 06.03.19 um 12:52 schrieb Chunming Zhou:
Quoted 12 lines
As we know, visible vram can be placed to invisible when no cpu access.
Signed-off-by Chunming Zhou <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file · line 595
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-2@@ -592,8 +592,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file vram_gtt.vram_size = adev->gmc.real_vram_size -atomic64_read (&adev->vram_pin_size); - vram_gtt.vram_cpu_accessible_size = adev->gmc.visible_vram_size - -atomic64_read (&adev->visible_pin_size); + vram_gtt.vram_cpu_accessible_size = vram_gtt.vram_size;
Well, NAK that would of course report the full VRAM as visible which isn't correct.
Christian.
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0vram_gtt.gtt_size = adev->mman.bdev.man[TTM_PL_TT ].size; vram_gtt.gtt_size *=PAGE_SIZE ; vram_gtt.gtt_size -=atomic64_read (&adev->gart_pin_size);@@ -612,9 +611,8 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file mem.vram.max_allocation = mem.vram.usable_heap_size *3 /4 ;
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file · line 618
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +2
-3mem.cpu_accessible_vram.total_heap_size = - adev->gmc.visible_vram_size; - mem.cpu_accessible_vram.usable_heap_size = adev->gmc.visible_vram_size - -atomic64_read (&adev->visible_pin_size); + mem.vram.total_heap_size; + mem.cpu_accessible_vram.usable_heap_size = mem.vram.usable_heap_size; mem.cpu_accessible_vram.heap_usage =amdgpu_vram_mgr_vis_usage (&adev->mman.bdev.man[TTM_PL_VRAM ]); mem.cpu_accessible_vram.max_allocation =
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 5ff670c0-6279-98cd-56c1-db792693ead9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoted 26 lines
-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, March 06, 2019 7:55 PM
To: Zhou, David(ChunMing) <[email protected]>; Koenig, Christian <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: force to useCPU_ACCESShint optimizationAm 06.03.19 um 12:52 schrieb Chunming Zhou:
Quoted 15 lines
As we know, visible vram can be placed to invisible when no cpu access.
Signed-off-by Chunming Zhou <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -592,8 +592,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file · line 595
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-1vram_gtt.vram_size = adev->gmc.real_vram_size -atomic64_read (&adev->vram_pin_size); - vram_gtt.vram_cpu_accessible_size = adev-gmc.visible_vram_size -
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-1-atomic64_read (&adev->visible_pin_size); + vram_gtt.vram_cpu_accessible_size = vram_gtt.vram_size;Well, NAK that would of course report the full VRAM as visible which isn't correct.
UMD also said same reason that they like report explicit vram info to application. No idea to do that.
-David
Quoted 12 lines
Christian.
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device
Quoted 5 lines
vram_gtt.gtt_size = adev-
mman.bdev.man[TTM_PL_TT].size;
vram_gtt.gtt_size *=PAGE_SIZE; vram_gtt.gtt_size -=atomic64_read(&adev->gart_pin_size);drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -612,9 +611,8 @@ static int amdgpu_info_ioctl(struct drm_device*dev, void *data, struct
drm_filedrivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device · line 611
Quoted 1 line
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0mem.vram.max_allocation = mem.vram.usable_heap_size *3 / 4;
Quoted 1 line
Quoted 12 lines
Quoted 10 lines
mem.cpu_accessible_vram.total_heap_size =
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-2- adev->gmc.visible_vram_size; - mem.cpu_accessible_vram.usable_heap_size = adev-gmc.visible_vram_size -
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +3
-1-atomic64_read (&adev->visible_pin_size); + mem.vram.total_heap_size; + mem.cpu_accessible_vram.usable_heap_size = +mem.vram.usable_heap_size; mem.cpu_accessible_vram.heap_usage = amdgpu_vram_mgr_vis_usage(&adev-Quoted 2 lines
mman.bdev.man[TTM_PL_VRAM]);
mem.cpu_accessible_vram.max_allocation =
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): MN2PR12MB2910C1E01F48480A034E1E82B4730-rweVpJHSKTr1t3MqfsnKMAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Am 06.03.19 um 13:00 schrieb Zhou, David(ChunMing):
Quoted 33 lines
Quoted 25 lines
-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, March 06, 2019 7:55 PM
To: Zhou, David(ChunMing) <[email protected]>; Koenig, Christian <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: force to useCPU_ACCESShint optimizationAm 06.03.19 um 12:52 schrieb Chunming Zhou:
Quoted 15 lines
As we know, visible vram can be placed to invisible when no cpu access.
Signed-off-by Chunming Zhou <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -592,8 +592,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_fileQuoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file · line 595
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-1vram_gtt.vram_size = adev->gmc.real_vram_size -atomic64_read (&adev->vram_pin_size); - vram_gtt.vram_cpu_accessible_size = adev-gmc.visible_vram_size -
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-1-atomic64_read (&adev->visible_pin_size); + vram_gtt.vram_cpu_accessible_size = vram_gtt.vram_size;Well, NAK that would of course report the full VRAM as visible which isn't correct.
Quoted 1 line
UMD also said same reason that they like report explicit vram info to application.
Yeah, I mean that is a rather good argument. The application should certainly know that.
Quoted 1 line
No idea to do that.
Well if I understood that correctly Vulkan had the same problem with cached and uncached system memory. How is it handled there?
Christian.
Quoted 12 lines
-David
Quoted 10 lines
Christian.
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device
Quoted 5 lines
vram_gtt.gtt_size = adev-
mman.bdev.man[TTM_PL_TT].size; vram_gtt.gtt_size *= PAGE_SIZE; vram_gtt.gtt_size -= atomic64_read(&adev->gart_pin_size);drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -612,9 +611,8 @@ static int amdgpu_info_ioctl(struct drm_device*dev, void *data, struct
drm_filedrivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device · line 611
Quoted 1 line
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0mem.vram.max_allocation = mem.vram.usable_heap_size *3 / 4;
Quoted 16 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-2mem.cpu_accessible_vram.total_heap_size = - adev->gmc.visible_vram_size; - mem.cpu_accessible_vram.usable_heap_size = adev-gmc.visible_vram_size -
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +3
-1-atomic64_read (&adev->visible_pin_size); + mem.vram.total_heap_size; + mem.cpu_accessible_vram.usable_heap_size = +mem.vram.usable_heap_size; mem.cpu_accessible_vram.heap_usage = amdgpu_vram_mgr_vis_usage(&adev-mman.bdev.man[TTM_PL_VRAM]);
mem.cpu_accessible_vram.max_allocation =_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1977ace8-19a7-2277-648b-d464fe46f2f7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoted 39 lines · Christian König
Am 06.03.19 um 13:00 schrieb Zhou, David(ChunMing):
Quoted 35 lines
Quoted 26 lines
-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, March 06, 2019 7:55 PM
To: Zhou, David(ChunMing) <[email protected]>; Koenig, Christian <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: force to useCPU_ACCESShint optimizationAm 06.03.19 um 12:52 schrieb Chunming Zhou:
Quoted 16 lines
As we know, visible vram can be placed to invisible when no cpu access.
Signed-off-by Chunming Zhou <[email protected]>---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 8 +++-----1 file changed, 3 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -592,8 +592,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_fileQuoted 9 lines
Quoted 6 lines
vram_gtt.vram_size =
adev->gmc.real_vram_size-atomic64_read(&adev->vram_pin_size);
- vram_gtt.vram_cpu_accessible_size = adev- gmc.visible_vram_size -
-atomic64_read(&adev->visible_pin_size);
+ vram_gtt.vram_cpu_accessible_size = vram_gtt.vram_size;Well, NAK that would of course report the full VRAM as visible which isn't
correct.Quoted 2 lines
UMD also said same reason that they like report explicit vram info to application.
Quoted 7 lines
Yeah, I mean that is a rather good argument. The application should certainly know that.
Quoted 1 line
No idea to do that.
Well if I understood that correctly Vulkan had the same problem with cached and uncached system memory. How is it handled there?
Which problem with cached and uncached system memory?
-David
Quoted 32 lines
Christian.
Quoted 28 lines
-David
Quoted 22 lines
Christian.
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c static int amdgpu_info_ioctl(struct drm_device
Quoted 5 lines
vram_gtt.gtt_size = adev- mman.bdev.man[TTM_PL_TT].size;
vram_gtt.gtt_size *=PAGE_SIZE; vram_gtt.gtt_size -=atomic64_read(&adev->gart_pin_size);drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-0@@ -612,9 +611,8 @@ static int amdgpu_info_ioctl(struct drm_device*dev, void *data, struct
drm_fileQuoted 1 line
mem.vram.max_allocation = mem.vram.usable_heap_size *
3 / 4;
Quoted 12 lines
mem.cpu_accessible_vram.total_heap_size =
-adev->gmc.visible_vram_size;
- mem.cpu_accessible_vram.usable_heap_size = adev- gmc.visible_vram_size -
-atomic64_read(&adev->visible_pin_size); + mem.vram.total_heap_size;
+ mem.cpu_accessible_vram.usable_heap_size = +mem.vram.usable_heap_size; mem.cpu_accessible_vram.heap_usage =amdgpu_vram_mgr_vis_usage(&adev- mman.bdev.man[TTM_PL_VRAM]); mem.cpu_accessible_vram.max_allocation =_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx