Skip to contentSkip to conversation

omap2/3: dmtimer: Enable autoidle

PATCH New Tero Kristo 4 participants 5 messages Feb 15, 2011 – Mar 10, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Tero Kristo

author
#0 lore raw

PATCH v2 1/1 omap2/3: dmtimer: Enable autoidle

This saves some power. OMAP4 version should check for GPT module ID, as autoidle is only supported on a subset of these.

Signed-off-by Tero Kristo <[email protected]>
---
 arch/arm/plat-omap/dmtimer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/plat-omap/dmtimer.c +4 -0
index 1d706cf..ee9f6eb 100644
@@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer)
 	l |= 0x02 << 3;  /* Set to smart-idle mode */
 	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on idle */
 
+	/* Enable autoidle on OMAP2 / OMAP3 */
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+		l |= 0x1 << 0;
+
 	/*
 	 * Enable wake-up on OMAP2 CPUs.
 	 */
Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 1/1 omap2/3: dmtimer: Enable autoidle

Quoted 28 lines

-----Original Message-----
From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- owner at vger.kernel.org] On Behalf Of Tero Kristo
Sent: Tuesday, February 15, 2011 10:00 PM
To: linux-omap at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle

This saves some power. OMAP4 version should check for GPT module ID, as
autoidle is only supported on a subset of these.

Signed-off-by Tero Kristo <[email protected]>
---
 arch/arm/plat-omap/dmtimer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/plat- renamed from arch/arm/plat-omap/dmtimer.c +0 -0

omap/dmtimer.c
index 1d706cf..ee9f6eb 100644

arch/arm/plat-omap/dmtimer.c +0 -0
@@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
 omap_dm_timer *timer)
 	l |= 0x02 << 3;  /* Set to smart-idle mode */
 	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on

idle */

arch/arm/plat-omap/dmtimer.c static void omap_dm_timer_reset(struct omap_dm_timer *timer) · line 348

Quoted 4 lines
arch/arm/plat-omap/dmtimer.c +4 -0
+	/* Enable autoidle on OMAP2 / OMAP3 */
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+		l |= 0x1 << 0;
+

We should get rid of this CPU checks. How about adding a flag and populating it on init for the architectures it supports.

Quoted 11 lines
arch/arm/plat-omap/dmtimer.c +0 -1
 	/*
 	 * Enable wake-up on OMAP2 CPUs.
 	 */
--

1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux- omap" in
the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

PATCH v2 1/1 omap2/3: dmtimer: Enable autoidle

Quoted 28 lines · Santosh Shilimkar
Quoted 28 lines

-----Original Message-----
From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- owner at vger.kernel.org] On Behalf Of Tero Kristo
Sent: Tuesday, February 15, 2011 10:00 PM
To: linux-omap at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle

This saves some power. OMAP4 version should check for GPT module ID, as
autoidle is only supported on a subset of these.

Signed-off-by Tero Kristo <[email protected]>
---
 arch/arm/plat-omap/dmtimer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/plat- renamed from arch/arm/plat-omap/dmtimer.c +0 -0

omap/dmtimer.c
index 1d706cf..ee9f6eb 100644

arch/arm/plat-omap/dmtimer.c +0 -0
@@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
 omap_dm_timer *timer)
 	l |= 0x02 << 3;  /* Set to smart-idle mode */
 	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on

idle */

Quoted 7 lines

arch/arm/plat-omap/dmtimer.c static void omap_dm_timer_reset(struct omap_dm_timer *timer) · line 348

Quoted 4 lines
arch/arm/plat-omap/dmtimer.c +4 -0
+	/* Enable autoidle on OMAP2 / OMAP3 */
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+		l |= 0x1 << 0;
+

We should get rid of this CPU checks. How about adding a flag and populating it on init for the architectures it supports.

Instead, this should be implemented on top of Tarun's hwmod conversion which knows that different timers have different capabilities (e.g. 1ms) and autoidle can be set based on capabilities.

Kevin

#3 lore raw

PATCH v2 1/1 omap2/3: dmtimer: Enable autoidle

Quoted 47 lines

-----Original Message-----
From: Kevin Hilman [mailto:khilman at ti.com]
Sent: Tuesday, February 15, 2011 9:50 PM
To: Santosh Shilimkar
Cc: Tero Kristo; linux-omap at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCHv2] omap2/3: dmtimer: Enable autoidle

Quoted 9 lines · Santosh Shilimkar
Quoted 9 lines

-----Original Message-----
From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- owner at vger.kernel.org] On Behalf Of Tero Kristo
Sent: Tuesday, February 15, 2011 10:00 PM
To: linux-omap at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle

This saves some power. OMAP4 version should check for GPT module

ID,

Quoted 19 lines
Quoted 19 lines

as
autoidle is only supported on a subset of these.

Signed-off-by Tero Kristo <[email protected]>
---
 arch/arm/plat-omap/dmtimer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/plat- renamed from arch/arm/plat-omap/dmtimer.c +0 -0

omap/dmtimer.c
index 1d706cf..ee9f6eb 100644

arch/arm/plat-omap/dmtimer.c +0 -0
@@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
 omap_dm_timer *timer)
 	l |= 0x02 << 3;  /* Set to smart-idle mode */
 	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on

idle */

Quoted 7 lines

arch/arm/plat-omap/dmtimer.c static void omap_dm_timer_reset(struct omap_dm_timer *timer) · line 348

Quoted 4 lines
arch/arm/plat-omap/dmtimer.c +4 -0
+	/* Enable autoidle on OMAP2 / OMAP3 */
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+		l |= 0x1 << 0;
+

We should get rid of this CPU checks. How about adding a flag and populating it on init for the architectures it supports.

Quoted 6 lines

Instead, this should be implemented on top of Tarun's hwmod conversion
which knows that different timers have different capabilities (e.g. 1ms)
and autoidle can be set based on capabilities.

You are right. Looking at patches it's seems to be already implemented.

So this patch isn't needed really.

Regards,
Santosh

#4 lore raw

PATCH v2 1/1 omap2/3: dmtimer: Enable autoidle

In reply to Tero Kristo
Quoted 4 lines · Tero Kristo

This saves some power. OMAP4 version should check for GPT module ID, as autoidle is only supported on a subset of these.

Signed-off-by Tero Kristo <[email protected]>

Thanks, queued for 2.6.39 since it looks like these won't be converted to hwmod in time for 2.6.39.

- Paul