Skip to contentSkip to conversation

ARM: dts: Add missing clocks for exynos4412 dwmmc node

PATCH In review Alex Ling 2 participants 3 messages Dec 14, 2013 – Dec 15, 2013

Subsystems (2)
lore
Share & tools
lore

Alex Ling

author
#0 lore raw

PATCH v2 1/1 ARM: dts: Add missing clocks for exynos4412 dwmmc node

This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc node. Without this patch, dwmmc host driver will skip enabling the two clocks and it will break dwmmc host function on exynos4412. Tested on FriendlyARM TINY4412 board.

---
Changes for v2:
- Fix patch description as Mark Rutland suggested

 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/exynos4412.dtsi +2 -0
index e743e67..67bef99 100644
@@ -67,5 +67,7 @@
 		interrupts = <0 77 0>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		clocks = <&clock 301>, <&clock 149>;
+		clock-names = "biu", "ciu";
 	};
 };
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Alex,

Quoted 5 lines · On Saturday 14 of December 2013 13:21:30 Alex Ling wrote:

This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc node. Without this patch, dwmmc host driver will skip enabling the two clocks and it will break dwmmc host function on exynos4412. Tested on FriendlyARM TINY4412 board.

Quoted 7 lines

---
Changes for v2:
- Fix patch description as Mark Rutland suggested

 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)

The patch is correct, but unfortunately it's not the only thing that is wrong with MSHC device tree node for Exynos4x12.

Please refer to my series fixing DW-MSHC support on Exynos4x12 (and enabling it on TRATS2 board):
http://www.spinics.net/lists/arm-kernel/msg293652.html

Best regards,
Tomasz

author
#2 lore raw

Thanks for pointing out this, Tomasz. I'll use those patches instead.

Regards,
Alex

Quoted 26 lines · Tomasz Figa

Hi Alex,

Quoted 5 lines · On Saturday 14 of December 2013 13:21:30 Alex Ling wrote:

This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc node. Without this patch, dwmmc host driver will skip enabling the two clocks and it will break dwmmc host function on exynos4412. Tested on FriendlyARM TINY4412 board.

Quoted 7 lines

---
Changes for v2:
- Fix patch description as Mark Rutland suggested

 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)

The patch is correct, but unfortunately it's not the only thing that is wrong with MSHC device tree node for Exynos4x12.

Please refer to my series fixing DW-MSHC support on Exynos4x12 (and enabling it on TRATS2 board):
http://www.spinics.net/lists/arm-kernel/msg293652.html

Best regards,
Tomasz