gst-examples,gstreamer1.0-libav: Add option to exclude from world build
PATCH 1/2 gst-examples,gstreamer1.0-libav: Add option to exclude from world build
When LICENSE_FLAGS_WHITELIST does not have commercial in it then the the dependencies like ffmpeg will become invisible and render these packages unbuildable, therefore world build will report parse issues
its better to exclude them from world build in such cases
--- meta/recipes-multimedia/gstreamer/gst-examples_1.18.4.bb | 2 ++ meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb | 3 +++ 2 files changed, 5 insertions(+)
meta/recipes-multimedia/gstreamer/gst-examples_1.18.4.bb +2 -0
@@ -33,3 +33,5 @@ RRECOMMENDS_${PN} = "gstreamer1.0-plugins-base-meta \ ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "gstreamer1.0-libav", "", d)} \ ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "gstreamer1.0-plugins-ugly-meta", "", d)}" RPROVIDES_${PN} += "gst-player gst-player-bin" + +EXCLUDE_FROM_WORLD = "${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "0", "1", d)}"
meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb +3 -0
@@ -6,6 +6,7 @@ SECTION = "multimedia" # ffmpeg has comercial license flags so add it as we need ffmpeg as a dependency LICENSE_FLAGS = "commercial" + LICENSE = "LGPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \ file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \
@@ -22,3 +23,5 @@ inherit meson pkgconfig upstream-version-is-even FILES_${PN} += "${libdir}/gstreamer-1.0/*.so" FILES_${PN}-staticdev += "${libdir}/gstreamer-1.0/*.a" + +EXCLUDE_FROM_WORLD = "${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "0", "1", d)}"
Signature · 1 line
2.31.1
PATCH 2/2 gstreamer1.0-libav: remove explicit LICENSE_FLAGS
From: Yann Dirson <[email protected]>
This flag does not describe the gst-libav package, but ffmpeg instead. It gets in the way of using finer-grained LICENSE_FLAGS in ffmpeg.
It is above all not needed, the real problem is even more clear without it:
ffmpeg was skipped: because it has a restricted license 'commercial'. Which is not whitelisted in LICENSE_FLAGS_WHITELIST
ERROR: Required build target 'gstreamer1.0-libav' has no buildable providers.
Missing or unbuildable dependency chain was: ['gstreamer1.0-libav', 'ffmpeg']
--- meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb | 3 --- 1 file changed, 3 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb +0 -3
@@ -4,9 +4,6 @@ muxers, and demuxers provided by FFmpeg." HOMEPAGE = "http://gstreamer.freedesktop.org/" SECTION = "multimedia" -# ffmpeg has comercial license flags so add it as we need ffmpeg as a dependency -LICENSE_FLAGS = "commercial" - LICENSE = "LGPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \ file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \
Signature · 1 line
2.31.1
Re: [OE-core] [PATCH 2/2] gstreamer1.0-libav: remove explicit LICENSE_FLAGS
Hi Khem,
There has already been a discussion about this in
https://lists.openembedded.org/g/openembedded-core/message/143935
In short: If libav needs ffmpeg, it will need that line (with a comment explaining its due to the dependency). Assuming libav without ffmpeg doesn't make sense/work
Khem Raj <[email protected]> escreveu no dia quinta, 13/05/2021 à(s) 23:38:
Quoted 38 lines
From: Yann Dirson <[email protected]>
This flag does not describe the gst-libav package, but ffmpeg instead. It gets in the way of using finer-grained
LICENSE_FLAGSin ffmpeg.It is above all not needed, the real problem is even more clear without it:
ffmpeg was skipped: because it has a restricted license 'commercial'. Which is not whitelisted in
LICENSE_FLAGS_WHITELIST
ERROR: Required build target 'gstreamer1.0-libav' has no buildable providers.
Missing or unbuildable dependency chain was: ['gstreamer1.0-libav', 'ffmpeg']Signed-off-by Yann Dirson <[email protected]>Signed-off-by Khem Raj <[email protected]>--- meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb | 3 --- 1 file changed, 3 deletions(-)meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb +0
-4@@ -4,9 +4,6 @@ muxers, and demuxers provided by FFmpeg." HOMEPAGE = "http://gstreamer.freedesktop.org/" SECTION = "multimedia" -# ffmpeg has comercial license flags so add it as we need ffmpeg as a dependency -LICENSE_FLAGS = "commercial" - LICENSE = "LGPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \ file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \ --2.31.1
Signature · 3 lines
Best regards, José Quaresma
Re: [OE-core] [PATCH 2/2] gstreamer1.0-libav: remove explicit LICENSE_FLAGS
Quoted 9 lines · Jose Quaresma
Hi Khem,
There has already been a discussion about this in
https://lists.openembedded.org/g/openembedded-core/message/143935In short: If libav needs ffmpeg, it will need that line (with a comment explaining its due to the dependency). Assuming libav without ffmpeg doesn't make sense/work
yeah, I think this is perhaps not the best way to solve it. Lets ignore this patchset
Quoted 41 lines
Khem Raj <[email protected]> escreveu no dia quinta, 13/05/2021 à(s) 23:38:
Quoted 38 lines
From: Yann Dirson <[email protected]>
This flag does not describe the gst-libav package, but ffmpeg instead. It gets in the way of using finer-grained
LICENSE_FLAGSin ffmpeg.It is above all not needed, the real problem is even more clear without it:
ffmpeg was skipped: because it has a restricted license 'commercial'. Which is not whitelisted in
LICENSE_FLAGS_WHITELIST
ERROR: Required build target 'gstreamer1.0-libav' has no buildable providers.
Missing or unbuildable dependency chain was: ['gstreamer1.0-libav', 'ffmpeg']Signed-off-by Yann Dirson <[email protected]>Signed-off-by Khem Raj <[email protected]>--- meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb | 3 --- 1 file changed, 3 deletions(-)meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.4.bb +0
-4@@ -4,9 +4,6 @@ muxers, and demuxers provided by FFmpeg." HOMEPAGE = "http://gstreamer.freedesktop.org/" SECTION = "multimedia" -# ffmpeg has comercial license flags so add it as we need ffmpeg as a dependency -LICENSE_FLAGS = "commercial" - LICENSE = "LGPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \ file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \ --2.31.1