Skip to contentSkip to conversation

monitor: Fix the incorrect vendor name

PATCH Superseded Tedd Ho-Jeong An 2 participants 2 messages Apr 21, 2021 Bluetooth drivers

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 monitor: Fix the incorrect vendor name

From: Tedd Ho-Jeong An <[email protected]>

This patch fixes the vendor name is alwasy shown as "Microsoft" for the commands and Unknown name for vendor events.

< HCI Command: Microsoft Secure Send (0x3f|0x0009) plen 249

        Type: Data fragment (0x01)
Quoted 1 line

HCI Event: Command Complete (0x0e) plen 4

      Microsoft Secure Send (0x3f|0x0009) ncmd 31
        Status: Success (0x00)
---
 monitor/msft.h   |   6 +++
 monitor/packet.c | 132 ++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 114 insertions(+), 24 deletions(-)
monitor/msft.h +6 -0
index a268f4bc7..9072c6ef8 100644
@@ -24,6 +24,12 @@
 
 #include <stdint.h>
 
+struct msft_ext {
+	uint16_t opcode;
+	uint8_t  evt_prefix_len;
+	uint8_t  evt_prefix[32];
+} __attribute__ ((packed));
+
 struct vendor_ocf;
 struct vendor_evt;
 
monitor/packet.c +108 -24

228 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=470557

---Test result---

Test Summary:

CheckPatch                    FAIL      0.44 seconds
GitLint                       PASS      0.11 seconds
Prep - Setup ELL              PASS      47.24 seconds
Build - Prep                  PASS      0.14 seconds
Build - Configure             PASS      8.17 seconds
Build - Make                  PASS      204.14 seconds
Make Check                    PASS      8.95 seconds
Make Dist                     PASS      12.26 seconds
Make Dist - Configure         PASS      4.99 seconds
Make Dist - Make              PASS      84.00 seconds
Build w/ext ELL - Configure   PASS      8.27 seconds
Build w/ext ELL - Make        PASS      195.15 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
monitor: Fix the incorrect vendor name WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) #27: FILE: monitor/msft.h:31:
+} __attribute__ ((packed));

WARNING:BRACES: braces {} are not necessary for single statement blocks #189: FILE: monitor/packet.c:9448:
+ if (size > prefix_len && !memcmp(data, prefix, prefix_len)) {
+ return msft_vendor_evt();
+ }

- total: 0 errors, 2 warnings, 240 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] monitor: Fix the incorrect vendor name" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball

##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball

##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration

---
Regards,
Linux Bluetooth