mmc-utils: implemented CMD42 locking/unlocking
PATCH 1/1 mmc-utils: implemented CMD42 locking/unlocking
From: Daniel Kucera <[email protected]>
Implemented locking/unlocking using CMD42 according to Micron Technical Note
original link https://media-www.micron.com/-/media/client/global/documents/products/technical-note/sd-cards/tnsd01_enable_sd_lock_unlock_in_linux.pdf?rev=03f03a6bc0f8435fafa93a8fc8e88988
currently available at https://github.com/danielkucera/esp32-sdcard/blob/master/tnsd01_enable_sd_lock_unlock_in_linux.pdf
--- mmc.c | 11 +++++ mmc.h | 11 +++++ mmc_cmds.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 2 + 4 files changed, 141 insertions(+)
mmc.c +11 -0
@@ -250,6 +250,17 @@ static struct Command commands[] = {"be 1." ,NULL }, + { do_lock_unlock, -3, +"cmd42" ,"<password> " "<parameter> " "<device>\n" +"Usage: mmc cmd42 <password> <s|c|l|u|e> <device>\n" +"s\tset password\n" +"c\tclear password\n" +"l\tlock\n" +"sl\tset password and lock\n" +"u\tunlock\n" +"e\tforce erase\n" , +NULL + }, { do_softreset, -1,"softreset" ,"<device>\n" "Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works",
mmc.h +11 -0
@@ -30,6 +30,7 @@#define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */ #define R1_SWITCH_ERROR (1 << 7)/* sx, c */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03/* Set target to value */ +#define MMC_SET_BLOCKLEN 16/* ac [31:0] block len R1 */ #define MMC_READ_MULTIPLE_BLOCK 18/* adtc [31:0] data addr R1 */ #define MMC_SET_BLOCK_COUNT 23/* adtc [31:0] data addr R1 */ #define MMC_WRITE_BLOCK 24/* adtc [31:0] data addr R1 */
@@ -46,6 +47,7 @@[1] Discard Enable [0] Identify Write Blocks for Erase (or TRIM Enable) R1b */ +#define MMC_LOCK_UNLOCK 42/* adtc R1b */ #define MMC_GEN_CMD 56/* adtc [31:1] stuff bits. [0]: RD/WR1 R1 */
@@ -70,6 +72,15 @@#define R1_EXCEPTION_EVENT (1 << 6)/* sr, a */ #define R1_APP_CMD (1 << 5)/* sr, c */ +#define MMC_CMD42_UNLOCK 0x0/* UNLOCK */ +#define MMC_CMD42_SET_PWD 0x1/* SET_PWD */ +#define MMC_CMD42_CLR_PWD 0x2/* CLR_PWD */ +#define MMC_CMD42_LOCK 0x4/* LOCK */ +#define MMC_CMD42_SET_LOCK 0x5/* SET_PWD & LOCK */ +#define MMC_CMD42_ERASE 0x8/* ERASE */ +#define MAX_PWD_LENGTH 32/* max PWDS_LEN: old+new */ +#define MMC_BLOCK_SIZE 512/* data blk size for cmd42 */ +/* * EXT_CSD fields */
mmc_cmds.c +117 -0
123 lines not on this page · raw message
mmc_cmds.h +2 -0
@@ -50,3 +50,5 @@ int do_general_cmd_read(int nargs, char **argv);int do_softreset (int nargs,char **argv);int do_preidle (int nargs,char **argv);int do_alt_boot_op (int nargs,char **argv); +int do_lock_unlock (int nargs,char **argv); +int set_block_len (int fd,int blk_len);
Signature · 1 line
2.34.1
Hi,
Please see some comments below.
Please don't send a v2 yet - allow few days to look into the details of this feature.
Quoted 11 lines
From: Daniel Kucera <[email protected]>
Implemented locking/unlocking using CMD42 according to Micron Technical Note
original link https://media-www.micron.com/-
/media/client/global/documents/products/technical-note/sd- cards/tnsd01_enable_sd_lock_unlock_in_linux.pdf?rev=03f03a6bc0f8435fafa93a8fc8e88988
currently available at https://github.com/danielkucera/esp32-
sdcard/blob/master/tnsd01_enable_sd_lock_unlock_in_linux.pdf
The above technical note specifically refers to SD, Is this designated for SD only? If yes please make note of that.
If not - Please relate in your commit log to the differences, if any, between eMMC & SD.
The above technical note contains an implementation for mmc-utils. Are you the author of that code?
Quoted 73 lines
Signed-off-by Daniel Kucera <[email protected]>--- mmc.c | 11 +++++ mmc.h | 11 +++++ mmc_cmds.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 2 + 4 files changed, 141 insertions(+)mmc.c +11
-0@@ -250,6 +250,17 @@ static struct Command commands[] = {"be 1." ,NULL }, + { do_lock_unlock, -3, +"cmd42" ,"<password> " "<parameter> " "<device>\n" +"Usage: mmc cmd42 <password> <s|c|l|u|e> <device>\n" +"s\tset password\n" +"c\tclear password\n" +"l\tlock\n" +"sl\tset password and lock\n" +"u\tunlock\n" +"e\tforce erase\n" , +NULL + }, { do_softreset, -1,"softreset" ,"<device>\n" "Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works",mmc.h +11
-0@@ -30,6 +30,7 @@#define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */ #define R1_SWITCH_ERROR (1 << 7)/* sx, c */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03/* Set target to value */ +#define MMC_SET_BLOCKLEN 16/* ac [31:0] block len R1 */ #define MMC_READ_MULTIPLE_BLOCK 18/* adtc [31:0] data addr R1 */ #define MMC_SET_BLOCK_COUNT 23/* adtc [31:0] data addr R1 */ #define MMC_WRITE_BLOCK 24/* adtc [31:0] data addr R1 */ @@ -46,6 +47,7 @@[1] Discard Enable [0] Identify Write Blocks for Erase (or TRIM Enable) R1b */ +#define MMC_LOCK_UNLOCK 42/* adtc R1b */ #define MMC_GEN_CMD 56/* adtc [31:1] stuff bits. [0]: RD/WR1 R1 */ @@ -70,6 +72,15 @@#define R1_EXCEPTION_EVENT (1 << 6)/* sr, a */ #define R1_APP_CMD (1 << 5)/* sr, c */ +#define MMC_CMD42_UNLOCK 0x0/* UNLOCK */ +#define MMC_CMD42_SET_PWD 0x1/* SET_PWD */ +#define MMC_CMD42_CLR_PWD 0x2/* CLR_PWD */ +#define MMC_CMD42_LOCK 0x4/* LOCK */ +#define MMC_CMD42_SET_LOCK 0x5/* SET_PWD & LOCK */ +#define MMC_CMD42_ERASE 0x8/* ERASE */ +#define MAX_PWD_LENGTH 32/* max PWDS_LEN: old+new */ +#define MMC_BLOCK_SIZE 512/* data blk size for cmd42 */ +/* * EXT_CSD fields */ mmc_cmds.c +0
-0
mmc_cmds.c int send_status(int fd, __u32 *response) · line 132
Quoted 4 lines
mmc_cmds.c +1
-0@@ -129,6 +129,123 @@ int send_status(int fd, __u32 *response)return ret; } +//lock/unlock feature implementation
C99 style single line comments (//) should not be used. Prefer the block comment style instead.
See: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
Please change throughout.
mmc_cmds.c int send_status(int fd, __u32 *response) · line 137
Quoted 5 lines
mmc_cmds.c +5
-0+int do_lock_unlock (int nargs,char **argv) +{ +int fd, ret =0 ; +char *device; +__u8 data_block[MMC_BLOCK_SIZE ] = {0 };
Just empty braces please.
Quoted 123 lines
mmc_cmds.c +36
-0+__u8 data_block_onebyte[1 ] = {0 }; +int block_size =0 ; +struct mmc_ioc_cmd idata; +int cmd42_para;//parameter of cmd42 +char pwd[MAX_PWD_LENGTH +1 ];//password +int pwd_len;//password length +__u32 r1_response;//R1 response token + +if (nargs !=4 ) { + fprintf(stderr, "Usage: mmc cmd42 <password> <s|c|l|u|e> <device>\n"); + exit(1); + } + +strcpy (pwd, argv[1 ]); + pwd_len =strlen (pwd); + +if (!strcmp ("s" , argv[2 ])) { + cmd42_para =MMC_CMD42_SET_PWD ; +printf ("Set password: password=%s ...\n" , pwd); + }else if (!strcmp ("c" , argv[2 ])) { + cmd42_para =MMC_CMD42_CLR_PWD ; +printf ("Clear password: password=%s ...\n" , pwd); + }else if (!strcmp ("l" , argv[2 ])) { + cmd42_para =MMC_CMD42_LOCK ; +printf ("Lock the card: password=%s ...\n" , pwd); + }else if (!strcmp ("sl" , argv[2 ])) { + cmd42_para =MMC_CMD42_SET_LOCK ; +printf ("Set password and lock the card: password - %s ...\n" , pwd); + }else if (!strcmp ("u" , argv[2 ])) { + cmd42_para =MMC_CMD42_UNLOCK ; +printf ("Unlock the card: password=%s ...\n" , pwd); + }else if (!strcmp ("e" , argv[2 ])) { + cmd42_para =MMC_CMD42_ERASE ; +printf ("Force erase (Warning: all card data will be erased together with PWD!)\n"); + } else { + printf("Invalid parameter:\n" "s\tset password\n" "c\tclearpassword\n" "l\tlock\n"
mmc_cmds.c +14
-0+ "sl\tset password and lock\n" "u\tunlock\n" "e\tforce erase\n"); +exit (1 ); + } + + device = argv[nargs-1 ]; + + fd =open (device,O_RDWR ); +if (fd <0 ) { +perror ("open" ); +exit (1 ); + } + +if (cmd42_para ==MMC_CMD42_ERASE ) + block_size =2 ;//set blk size to 2-byte for Force Erase @DDR50 compatibility
mmc_cmds.c +61
-0+else + block_size =MMC_BLOCK_SIZE ; + + ret =set_block_len (fd, block_size);//set data block size prior to cmd42 +printf ("Set to data block length = %d byte(s).\n" , block_size); + +if (cmd42_para ==MMC_CMD42_ERASE ) { + data_block_onebyte[0 ] = cmd42_para; + }else { + data_block[0 ] = cmd42_para; + data_block[1 ] = pwd_len; +memcpy ((char *)(data_block+2 ), pwd, pwd_len); + } + +memset (&idata,0 ,sizeof (idata)); + idata.write_flag =1 ; + idata.opcode =MMC_LOCK_UNLOCK ; + idata.arg =0 ;//set all 0 for cmd42 arg + idata.flags =MMC_RSP_R1 |MMC_CMD_AC |MMC_CMD_ADTC ; + idata.blksz = block_size; + idata.blocks =1 ; + +if (cmd42_para ==MMC_CMD42_ERASE ) +mmc_ioc_cmd_set_data (idata, data_block_onebyte); +else +mmc_ioc_cmd_set_data (idata, data_block); + + ret =ioctl (fd,MMC_IOC_CMD , &idata);//Issue CMD42 + + r1_response = idata.response[0 ]; +printf ("cmd42 response: 0x%08x\n" , r1_response); +if (r1_response &R1_ERROR ) {//check CMD42 error +printf ("cmd42 error! Error code: 0x%08x\n" , r1_response &R1_ERROR ); + ret =-1 ; + } +if (r1_response &R1_LOCK_UNLOCK_FAILED ) {//check lock/unlock error +printf ("Card lock/unlock fail! Error code: 0x%08x\n" , + r1_response &R1_LOCK_UNLOCK_FAILED ); + ret =-1 ; + } + +close (fd); +return ret; +} + +//change data block length +int set_block_len (int fd,int blk_len) +{ +int ret =0 ; +struct mmc_ioc_cmd idata; + +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_SET_BLOCKLEN ; + idata.arg = blk_len; + idata.flags =MMC_RSP_R1 |MMC_CMD_AC ; + + ret =ioctl (fd,MMC_IOC_CMD , &idata); + +return ret; +} +static __u32 get_size_in_blks (int fd) {int res;mmc_cmds.h +0
-0
mmc_cmds.h int do_general_cmd_read(int nargs, char **argv); · line 54
Quoted 5 lines
mmc_cmds.h +2
-0@@ -50,3 +50,5 @@ int do_general_cmd_read(int nargs, char **argv);int do_softreset (int nargs,char **argv);int do_preidle (int nargs,char **argv);int do_alt_boot_op (int nargs,char **argv); +int do_lock_unlock (int nargs,char **argv); +int set_block_len (int fd,int blk_len);
Please make set_block_len() static - as its only caller is do_lock_unlock.
Thanks,
Avri
Quoted 3 lines
--
2.34.1
Quoted 5 lines
Hi,
Please see some comments below.
Please don't send a v2 yet - allow few days to look into the details of this feature.
Some more comments below.
Quoted 82 lines
Quoted 9 lines
From: Daniel Kucera <[email protected]>
Implemented locking/unlocking using CMD42 according to Micron Technical Note
original link https://media-www.micron.com/-
/media/client/global/documents/products/technical-note/sd-cards/tnsd01_enable_sd_lock_unlock_in_linux.pdf?rev=03f03a6bc0f8435faf
Quoted 4 lines
a93a
8fc8e88988
currently available at https://github.com/danielkucera/esp32-
sdcard/blob/master/tnsd01_enable_sd_lock_unlock_in_linux.pdfThe above technical note specifically refers to SD, Is this designated for SD only?
If yes please make note of that.
If not - Please relate in your commit log to the differences, if any, between eMMC & SD.The above technical note contains an implementation for mmc-utils. Are you the author of that code?
Quoted 37 lines
Signed-off-by Daniel Kucera <[email protected]>--- mmc.c | 11 +++++ mmc.h | 11 +++++ mmc_cmds.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 2 + 4 files changed, 141 insertions(+)mmc.c +11
-0@@ -250,6 +250,17 @@ static struct Command commands[] = {"be 1." ,NULL }, + { do_lock_unlock, -3, +"cmd42" ,"<password> " "<parameter> " "<device>\n" +"Usage: mmc cmd42 <password> <s|c|l|u|e> <device>\n" +"s\tset password\n" +"c\tclear password\n" +"l\tlock\n" +"sl\tset password and lock\n" +"u\tunlock\n" +"e\tforce erase\n" , +NULL + }, { do_softreset, -1,"softreset" ,"<device>\n" "Issues a CMD0 softreset, e.g. for testing if hardware resetfor UHS works", diff --git
a/mmc.hb/mmc.hindex 6f1bf3e..f8bac22 100644mmc.h line 32
Quoted 3 lines
mmc.h +0
-0@@ -30,6 +30,7 @@#define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */ #define R1_SWITCH_ERROR (1 << 7)/* sx, c */ #define MMC_SWITCH_MODE_WRITE_BYTE 0x03/* Set target to value */
mmc.h
Quoted 4 lines
mmc.h +1
-0+#define MMC_SET_BLOCKLEN 16/* ac [31:0] block len R1 */ #define MMC_READ_MULTIPLE_BLOCK 18/* adtc [31:0] data addr R1 */ #define MMC_SET_BLOCK_COUNT 23/* adtc [31:0] data addr R1 */ #define MMC_WRITE_BLOCK 24/* adtc [31:0] data addr R1 */
Quoted 13 lines
mmc.h +0
-0@@ -46,6 +47,7 @@ [1] Discard Enable [0] Identify Write Blocks for Erase (or TRIM Enable)R1b */
mmc.h +1
-0+#define MMC_LOCK_UNLOCK 42/* adtc R1b */ #define MMC_GEN_CMD 56/* adtc [31:1] stuff bits. [0]: RD/WR1 R1 */ @@ -70,6 +72,15 @@#define R1_EXCEPTION_EVENT (1 << 6)/* sr, a */ #define R1_APP_CMD (1 << 5)/* sr, c */
Quoted 6 lines
mmc.h line 80
Quoted 6 lines
mmc.h +6
-0+#define MMC_CMD42_UNLOCK 0x0/* UNLOCK */ +#define MMC_CMD42_SET_PWD 0x1/* SET_PWD */ +#define MMC_CMD42_CLR_PWD 0x2/* CLR_PWD */ +#define MMC_CMD42_LOCK 0x4/* LOCK */ +#define MMC_CMD42_SET_LOCK 0x5/* SET_PWD & LOCK */ +#define MMC_CMD42_ERASE 0x8/* ERASE */
There are 3 variants of sd cards that support lock/unlock.
There is a warning in the spec - see note 2* to table 4-10 in sd spec 9.0:
"The host should not issue a force erase command if the permanent write protect is set to 1, Otherwise, the type 1 cards can no longer be used even if the user remembers the password." For that reason, its destructive nature, and the complications of FEP with COP vs. non-COP cards - I think its better to leave FEP out for now.
Quoted 27 lines
Quoted 11 lines
mmc.h +3
-0+#define MAX_PWD_LENGTH 32/* max PWDS_LEN: old+new */ +#define MMC_BLOCK_SIZE 512/* data blk size for cmd42 */ +/* * EXT_CSD fields */ mmc_cmds.c +0
-0mmc_cmds.c int send_status(int fd, __u32 *response) · line 132
Quoted 4 lines
mmc_cmds.c +1
-0@@ -129,6 +129,123 @@ int send_status(int fd, __u32 *response)return ret; } +//lock/unlock feature implementation C99 style single line comments (//) should not be used. Prefer the block comment style instead.
See: https://www.kernel.org/doc/html/latest/process/coding-
style.html#commenting
Please change throughout.mmc_cmds.c int send_status(int fd, __u32 *response) · line 137
Quoted 4 lines
mmc_cmds.c +4
-0+int do_lock_unlock (int nargs,char **argv) { +int fd, ret =0 ; +char *device; +__u8 data_block[MMC_BLOCK_SIZE ] = {0 };Just empty braces please.
Quoted 16 lines
Quoted 6 lines
mmc_cmds.c +6
-0+__u8 data_block_onebyte[1 ] = {0 }; +int block_size =0 ; +struct mmc_ioc_cmd idata; +int cmd42_para;//parameter of cmd42 +char pwd[MAX_PWD_LENGTH +1 ];//password +int pwd_len;//password length mmc_cmds.c int send_status(int fd, __u32 *response) · line 151
Quoted 10 lines
mmc_cmds.c +9
-0+__u32 r1_response;//R1 response token + +if (nargs !=4 ) { + fprintf(stderr, "Usage: mmc cmd42 <password> + <s|c|l|u|e> <device>\n"); + exit(1); + } + +strcpy (pwd, argv[1 ]);
Maybe strncpy up to MAX_PWD_LENGTH
Also, in case of a password change, it makes more sense to capture the old and new as 2 different strings.
Quoted 1 line
mmc_cmds.c int send_status(int fd, __u32 *response) · line 152
Quoted 1 line
mmc_cmds.c +1
-0+ pwd_len =strlen (pwd);
Maybe clarify in the usage, that passwords are not allowed to include '\0'
Quoted 40 lines
Quoted 24 lines
mmc_cmds.c +23
-0+ +if (!strcmp ("s" , argv[2 ])) { + cmd42_para =MMC_CMD42_SET_PWD ; +printf ("Set password: password=%s ...\n" , pwd); + }else if (!strcmp ("c" , argv[2 ])) { + cmd42_para =MMC_CMD42_CLR_PWD ; +printf ("Clear password: password=%s ...\n" , pwd); + }else if (!strcmp ("l" , argv[2 ])) { + cmd42_para =MMC_CMD42_LOCK ; +printf ("Lock the card: password=%s ...\n" , pwd); + }else if (!strcmp ("sl" , argv[2 ])) { + cmd42_para =MMC_CMD42_SET_LOCK ; +printf ("Set password and lock the card: password - %s ...\n" , pwd); + }else if (!strcmp ("u" , argv[2 ])) { + cmd42_para =MMC_CMD42_UNLOCK ; +printf ("Unlock the card: password=%s ...\n" , pwd); + }else if (!strcmp ("e" , argv[2 ])) { + cmd42_para =MMC_CMD42_ERASE ; + printf("Force erase (Warning: all card data will be + erased together with PWD!)\n"); + } else { + printf("Invalid parameter:\n" "s\tset password\n" + "c\tclearQuoted 2 lines
password\n" "l\tlock\n"
+ "sl\tset password and lock\n" "u\tunlock\n" "e\tforceerase\n");
Quoted 13 lines
mmc_cmds.c +13
-0+exit (1 ); + } + + device = argv[nargs-1 ]; + + fd =open (device,O_RDWR ); +if (fd <0 ) { +perror ("open" ); +exit (1 ); + } + +if (cmd42_para ==MMC_CMD42_ERASE ) + block_size =2 ;//set blk size to 2-byte for Force
Quoted 8 lines
mmc_cmds.c int send_status(int fd, __u32 *response)
Quoted 8 lines
+ Erase @DDR50
compatibilitymmc_cmds.c +6
-0+else + block_size =MMC_BLOCK_SIZE ; + + ret =set_block_len (fd, block_size);//set data block size prior to cmd42 +printf ("Set to data block length = %d byte(s).\n" , + block_size);
On a failure here you should bail out.
But it makes more sense to me that you would pack cmd16 & cmd42 in a multi-ioctl.
Quoted 10 lines
mmc_cmds.c int send_status(int fd, __u32 *response) · line 202
Quoted 10 lines
mmc_cmds.c +10
-0+ +if (cmd42_para ==MMC_CMD42_ERASE ) { + data_block_onebyte[0 ] = cmd42_para; + }else { + data_block[0 ] = cmd42_para; + data_block[1 ] = pwd_len; +memcpy ((char *)(data_block+2 ), pwd, pwd_len); + } + +memset (&idata,0 ,sizeof (idata));
Can be initialized with {}
Thanks,
Avri
Quoted 67 lines
Quoted 8 lines
mmc_cmds.c +8
-0+ idata.write_flag =1 ; + idata.opcode =MMC_LOCK_UNLOCK ; + idata.arg =0 ;//set all 0 for cmd42 arg + idata.flags =MMC_RSP_R1 |MMC_CMD_AC |MMC_CMD_ADTC ; + idata.blksz = block_size; + idata.blocks =1 ; + +if (cmd42_para ==MMC_CMD42_ERASE )mmc_cmds.c int send_status(int fd, __u32 *response)
Quoted 10 lines
mmc_cmds.c +10
-0+mmc_ioc_cmd_set_data (idata, data_block_onebyte); + else +mmc_ioc_cmd_set_data (idata ,data_block ); + + ret =ioctl (fd,MMC_IOC_CMD , &idata);//Issue CMD42 + + r1_response = idata.response[0 ]; +printf ("cmd42 response: 0x%08x\n" , r1_response); +if (r1_response &R1_ERROR ) {//check CMD42 error + printf("cmd42 error! Error code: 0x%08x\n", r1_response &
R1_ERROR);mmc_cmds.c int send_status(int fd, __u32 *response)
Quoted 3 lines
mmc_cmds.c +3
-0+ ret =-1 ; + } +if (r1_response &R1_LOCK_UNLOCK_FAILED ) {//check lock/unlock error
Quoted 31 lines
mmc_cmds.c +24
-0+printf ("Card lock/unlock fail! Error code: 0x%08x\n" , + r1_response &R1_LOCK_UNLOCK_FAILED ); + ret =-1 ; + } + +close (fd); +return ret; +} + +//change data block length +int set_block_len (int fd,int blk_len) { +int ret =0 ; +struct mmc_ioc_cmd idata; + +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_SET_BLOCKLEN ; + idata.arg = blk_len; + idata.flags =MMC_RSP_R1 |MMC_CMD_AC ; + + ret =ioctl (fd,MMC_IOC_CMD , &idata); + +return ret; +} +static __u32 get_size_in_blks (int fd) {int res;mmc_cmds.h +0
-0mmc_cmds.h int do_general_cmd_read(int nargs, char **argv); · line 53
Quoted 4 lines
mmc_cmds.h +2
-0@@ -50,3 +50,5 @@ int do_general_cmd_read(int nargs, char **argv);int do_softreset (int nargs,char **argv);int do_preidle (int nargs,char **argv);int do_alt_boot_op (int nargs,char **argv); +int do_lock_unlock (int nargs,char **argv);int set_block_len (int fd, +int blk_len);Please make
set_block_len()static - as its only caller isdo_lock_unlock.Thanks,
AvriQuoted 3 lines
mmc_cmds.h +0
-1--2.34.1
Quoted 8 lines · On 5/19/24 08:08, [email protected] wrote:
------ Tessian Warning ------
Be careful, the email's sending domain "@danman[.]eu" has never been seen on your company's network before today
This warning message will be removed if you reply to or forward this email to a recipient outside of your organization.
---- Tessian Warning End ----
Quoted 7 lines
From: Daniel Kucera <[email protected]>
Implemented locking/unlocking using CMD42 according to Micron Technical Note
original link https://media-www.micron.com/-/media/client/global/documents/products/technical-note/sd-cards/tnsd01_enable_sd_lock_unlock_in_linux.pdf?rev=03f03a6bc0f8435fafa93a8fc8e88988
currently available at https://github.com/danielkucera/esp32-sdcard/blob/master/tnsd01_enable_sd_lock_unlock_in_linux.pdf
You explained it nicely in v1 why this feature is indeed more dangerous than a simple erase:
https://lore.kernel.org/linux-mmc/DM6PR04MB6575AC22506EDEBB7C7E9310FCE82@DM6PR04MB6575.namprd04.prod.outlook.com/T/#m4241fce85459336e2ca4d2abbcccf6d6227e9501
Locking a card will essentially brick it for all practical purposes if it is removed (or the system shuts down) between locking and unlocking until mmcblk supports initialization of locked cards.
I'd upstream that first, I had a similar patch like you mentioned, but didn't get around to it.
Quoted 21 lines · Christian Loehle
Quoted 8 lines · On 5/19/24 08:08, [email protected] wrote:
------ Tessian Warning ------
Be careful, the email's sending domain "@danman[.]eu" has never been seen on your company's network before today
This warning message will be removed if you reply to or forward this email to a recipient outside of your organization.
---- Tessian Warning End ----
Quoted 7 lines
From: Daniel Kucera <[email protected]>
Implemented locking/unlocking using CMD42 according to Micron Technical Note
original link https://media-www.micron.com/-/media/client/global/documents/products/technical-note/sd-cards/tnsd01_enable_sd_lock_unlock_in_linux.pdf?rev=03f03a6bc0f8435fafa93a8fc8e88988
currently available at https://github.com/danielkucera/esp32-sdcard/blob/master/tnsd01_enable_sd_lock_unlock_in_linux.pdfYou explained it nicely in v1 why this feature is indeed more dangerous than a simple erase:
https://lore.kernel.org/linux-mmc/DM6PR04MB6575AC22506EDEBB7C7E9310FCE82@DM6PR04MB6575.namprd04.prod.outlook.com/T/#m4241fce85459336e2ca4d2abbcccf6d6227e9501
Quoted 6 lines
Locking a card will essentially brick it for all practical purposes if it is removed (or the system shuts down)
between locking and unlocking until mmcblk supports initialization of locked cards.
I'd upstream that first, I had a similar patch like you mentioned, but didn't get around to it.
I think this is a chicken-egg problem:
If you don't have the tools to lock you cannot test correct detection with kernel. If you don't have kernel supporting locked cards you cannot unlock (but can lock).
Regarding the potential damage: what can cause a bigger damage? Loosing data or loosing the medium?
But anyway, I will prepare the kernel patch shortly.
D.