Skip to contentSkip to conversation

package/libpsl: needs wchar

PATCH New Fabrice Fontaine 3 participants 3 messages Jun 9, 2021 – Jun 20, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libpsl: needs wchar

Add a dependency on wchar as both icu and libunistring needs wchar

Fixes:
- http://autobuild.buildroot.org/results/704d8e6f8b78015180e5b12c132495425637430a

---
 package/libpsl/Config.in  | 4 ++++
 package/libsoup/Config.in | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
package/libpsl/Config.in +4 -0
index dd484799e7..de77ff8d10 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_LIBPSL
 	bool "libpsl"
+	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
 	select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
 	help
 	  C library to handle the Public Suffix List of TLDs.
 
 	  https://github.com/rockdaboot/libpsl
+
+comment "libpsl needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR
package/libsoup/Config.in +1 -1
index 47adfb33f2..0c0454c7c2 100644
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBSOUP
 	bool "libsoup"
-	depends on BR2_USE_WCHAR # glib2 and gnutls
+	depends on BR2_USE_WCHAR # glib2, gnutls and libpsl
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	select BR2_PACKAGE_LIBXML2
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/libpsl: needs wchar

Hi,

Quoted 1 line · On Wed, 09 Jun 2021 23:41:30 +0200 Fabrice Fontaine…

Add a dependency on wchar as both icu and libunistring needs wchar

Good catch, thanks! \o/

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/704d8e6f8b78015180e5b12c132495425637430a

Quoted 37 lines
---
 package/libpsl/Config.in  | 4 ++++
 package/libsoup/Config.in | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
package/libpsl/Config.in +4 -0
index dd484799e7..de77ff8d10 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_LIBPSL
 	bool "libpsl"
+	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
 	select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
 	help
 	  C library to handle the Public Suffix List of TLDs.
 
 	  https://github.com/rockdaboot/libpsl
+
+comment "libpsl needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR
package/libsoup/Config.in +1 -1
index 47adfb33f2..0c0454c7c2 100644
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBSOUP
 	bool "libsoup"
-	depends on BR2_USE_WCHAR # glib2 and gnutls
+	depends on BR2_USE_WCHAR # glib2, gnutls and libpsl
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	select BR2_PACKAGE_LIBXML2
Signature · 1 line
2.30.2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210610/b6ccebfb/attachment.asc>

#2 lore raw

PATCH 1/1 package/libpsl: needs wchar

In reply to Fabrice Fontaine
Quoted 16 lines · Fabrice Fontaine

Add a dependency on wchar as both icu and libunistring needs wchar

Fixes:
- http://autobuild.buildroot.org/results/704d8e6f8b78015180e5b12c132495425637430a

---
 package/libpsl/Config.in  | 4 ++++
 package/libsoup/Config.in | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
package/libpsl/Config.in +0 -0
index dd484799e7..de77ff8d10 100644

package/libpsl/Config.in line 3

Quoted 3 lines
package/libpsl/Config.in +1 -0
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_LIBPSL
 	bool "libpsl"
+	depends on BR2_USE_WCHAR

I added a comment # libunistring, icu

Applied to master, thanks.

Regards,
Arnout

Quoted 22 lines
package/libpsl/Config.in +3 -0
 	select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
 	select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
 	help
 	  C library to handle the Public Suffix List of TLDs.
 
 	  https://github.com/rockdaboot/libpsl
+
+comment "libpsl needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR
package/libsoup/Config.in +1 -1
index 47adfb33f2..0c0454c7c2 100644
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBSOUP
 	bool "libsoup"
-	depends on BR2_USE_WCHAR # glib2 and gnutls
+	depends on BR2_USE_WCHAR # glib2, gnutls and libpsl
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	select BR2_PACKAGE_LIBXML2