net/appletalk: LTPC needs virt_to_bus
Subsystems (2)
PATCH 1/1 net/appletalk: LTPC needs virt_to_bus
The ltpc driver is rather outdated and does not get built on most platforms because it requires the ISA_DMA_API symbol. However there are some ARM platforms that have ISA_DMA_API but no virt_to_bus, and they get this build error when enabling the ltpc driver.
drivers/net/appletalk/ltpc.c: In function 'handlefc':drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
set_dma_addr(dma,virt_to_bus(ltdmacbuf));
^
This adds another dependency in Kconfig to avoid that configuration.
drivers/net/appletalk/Kconfig +1 -1
@@ -40,7 +40,7 @@ config DEV_APPLETALK config LTPC tristate "Apple/Farallon LocalTalk PC support" - depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API + depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API && VIRT_TO_BUS help This allows you to use the AppleTalk PC card to connect to LocalTalk networks. The card is also known as the Farallon PhoneNet PC card.
From: Arnd Bergmann <[email protected]>
Date: Wed, 18 Feb 2015 20:48:54 +0100
Quoted 5 lines
The ltpc driver is rather outdated and does not get built on most platforms because it requires the
ISA_DMA_APIsymbol. However there are some ARM platforms that haveISA_DMA_APIbut novirt_to_bus, and they get this build error when enabling the ltpc driver.
Quoted 8 lines
drivers/net/appletalk/ltpc.c: In function 'handlefc':drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
set_dma_addr(dma,virt_to_bus(ltdmacbuf));
^This adds another dependency in
Kconfigto avoid that configuration.Signed-off-by Arnd Bergmann <[email protected]>
Applied, thank you.