ARM: OF implies OF_FLATTREE
PATCH 1/1 ARM: OF implies OF_FLATTREE
On the ARM architecture, individual platforms select CONFIG_USE_OF if they need it, but all device tree code is keyed off CONFIG_OF. When building a platform without DT support and manually enabling CONFIG_OF, we now get a number of build errors, e.g.
arch/arm/kernel/devtree.c: In function 'setup_machine_fdt':arch/arm/kernel/devtree.c:215:19: error: implicit declaration of function 'early_init_dt_verify' [-Werror=implicit-function-declaration]
We could now try to separate the use case of booting from DT vs. the case of using the dynamic implementation, but that seems more complicated than it can gain us.
This simply changes the ARM Kconfig file to always enable OF_RESERVED_MEM and OF_EARLY_FLATTREE when CONFIG_OF is enabled. These options add a little extra code when we just want the dynamic OF implementation, but that seems like a rather obscure case, and this version solves all CONFIG_OF related randconfig regressions.
arch/arm/Kconfig +2 -2
@@ -75,6 +75,8 @@ config ARM select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NO_BOOTMEM + select OF_EARLY_FLATTREE if OF + select OF_RESERVED_MEM if OF select OLD_SIGACTION select OLD_SIGSUSPEND3 select PERF_USE_VMALLOC
@@ -1695,8 +1697,6 @@ config USE_OF bool "Flattened Device Tree support" select IRQ_DOMAIN select OF - select OF_EARLY_FLATTREE - select OF_RESERVED_MEM help Include support for flattened device tree machine descriptions.
PATCH 1/1 ARM: OF implies OF_FLATTREE
Quoted 11 lines · Arnd Bergmann
On the ARM architecture, individual platforms select
CONFIG_USE_OFif they need it, but all device tree code is keyed offCONFIG_OF. When building a platform without DT support and manually enablingCONFIG_OF, we now get a number of build errors, e.g.
arch/arm/kernel/devtree.c: In function 'setup_machine_fdt':arch/arm/kernel/devtree.c:215:19: error: implicit declaration of function 'early_init_dt_verify' [-Werror=implicit-function-declaration]We could now try to separate the use case of booting from DT vs. the case of using the dynamic implementation, but that seems more complicated than it can gain us.
Agreed. It will only/mostly save init section code at that.
Quoted 8 lines
This simply changes the ARM
Kconfigfile to always enableOF_RESERVED_MEMandOF_EARLY_FLATTREEwhenCONFIG_OFis enabled. These options add a little extra code when we just want the dynamic OF implementation, but that seems like a rather obscure case, and this version solves allCONFIG_OFrelated randconfig regressions.Signed-off-by Arnd Bergmann <[email protected]>Fixes 0166dc11be91 ("of: make CONFIG_OF user selectable")
Quoted 23 lines
arch/arm/Kconfig +2
-2@@ -75,6 +75,8 @@ config ARM select IRQ_FORCED_THREADING select MODULES_USE_ELF_REL select NO_BOOTMEM + select OF_EARLY_FLATTREE if OF + select OF_RESERVED_MEM if OF select OLD_SIGACTION select OLD_SIGSUSPEND3 select PERF_USE_VMALLOC@@ -1695,8 +1697,6 @@ config USE_OF bool "Flattened Device Tree support" select IRQ_DOMAIN select OF - select OF_EARLY_FLATTREE - select OF_RESERVED_MEM help Include support for flattened device tree machine descriptions.