Skip to contentSkip to conversation

Use accurate icons for headphones and headsets

PATCH Applied Thomas Weißschuh 3 participants 5 messages Oct 3, 2021 – Oct 12, 2021 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use accurate icons for headphones and headsets

While these icon names are not part of the spec standard names [0] they are in practice implemented by at least Adwaita, Gnome, Oxygen, Arc and Breeze themes.

[0] https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html

---
 src/dbus-common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/dbus-common.c +2 -2
index 384f27700..5e2c83d52 100644
@@ -72,9 +72,9 @@ const char *class_to_icon(uint32_t class)
 		switch ((class & 0xfc) >> 2) {
 		case 0x01:
 		case 0x02:
-			return "audio-card";	/* Headset */
+			return "audio-headset";
 		case 0x06:
-			return "audio-card";	/* Headphone */
+			return "audio-headphones";
 		case 0x0b: /* VCR */
 		case 0x0c: /* Video Camera */
 		case 0x0d: /* Camcorder */

base-commit: c1e6d6c46fcab55ec820bb83396fff57ffd22e26

Signature · 1 line
2.33.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=556811

---Test result---

Test Summary:

CheckPatch                    FAIL      1.36 seconds
GitLint                       PASS      0.92 seconds
Prep - Setup ELL              PASS      47.51 seconds
Build - Prep                  PASS      0.46 seconds
Build - Configure             PASS      8.78 seconds
Build - Make                  PASS      194.30 seconds
Make Check                    PASS      8.98 seconds
Make Distcheck                PASS      228.49 seconds
Build w/ext ELL - Configure   PASS      8.21 seconds
Build w/ext ELL - Make        PASS      176.63 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] Use accurate icons for headphones and headsets
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #50:
are in practice implemented by at least Adwaita, Gnome, Oxygen, Arc and Breeze

/github/workspace/src/12532673.patch total: 0 errors, 1 warnings, 11 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12532673.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth

#2 lore raw

Hi Thomas,

Quoted 48 lines · On Sun, Oct 3, 2021 at 3:40 AM <[email protected]> wrote:

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=556811

---Test result---

Test Summary:

CheckPatch                    FAIL      1.36 seconds
GitLint                       PASS      0.92 seconds
Prep - Setup ELL              PASS      47.51 seconds
Build - Prep                  PASS      0.46 seconds
Build - Configure             PASS      8.78 seconds
Build - Make                  PASS      194.30 seconds
Make Check                    PASS      8.98 seconds
Make Distcheck                PASS      228.49 seconds
Build w/ext ELL - Configure   PASS      8.21 seconds
Build w/ext ELL - Make        PASS      176.63 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] Use accurate icons for headphones and headsets
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #50:
are in practice implemented by at least Adwaita, Gnome, Oxygen, Arc and Breeze

/github/workspace/src/12532673.patch total: 0 errors, 1 warnings, 11 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12532673.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Quoted 3 lines

---
Regards,
Linux Bluetooth

Shouldn't they be proposed to be added to the standard before we do these changes? I mean it is better to have an icon then not have anything or is there a fallback mechanism e.g. audio prefix fallback to audio-card?

Signature · 1 line
Luiz Augusto von Dentz
#3 lore raw

Hi Luiz,

Quoted 4 lines · Luiz Augusto von Dentz

Shouldn't they be proposed to be added to the standard before we do these changes? I mean it is better to have an icon then not have anything or is there a fallback mechanism e.g. audio prefix fallback to audio-card?

The naming standard has not been updated since 2006, I'm not sure it is still maintained.
Each theme can specify other themes it inherits from where missing icons are looked up from. The themes I checked either contain these icons or they inherit from some that do.
A standard fallback mechanism by name is not specified.

If you want I can try to submit the names to the standard but they seem already be part of the de-facto standard.

Thomas

maintainer Applied
#4 lore raw

Hi Thomas,

Quoted 16 lines · On Tue, Oct 5, 2021 at 12:07 AM <[email protected]> wrote:

Hi Luiz,

Quoted 4 lines · Luiz Augusto von Dentz

Shouldn't they be proposed to be added to the standard before we do these changes? I mean it is better to have an icon then not have anything or is there a fallback mechanism e.g. audio prefix fallback to audio-card?

The naming standard has not been updated since 2006, I'm not sure it is still maintained.
Each theme can specify other themes it inherits from where missing icons are looked up from. The themes I checked either contain these icons or they inherit from some that do.
A standard fallback mechanism by name is not specified.

Quoted 4 lines

If you want I can try to submit the names to the standard but they seem already be part of the de-facto standard.

Thomas

Applied, thanks.

Signature · 1 line
Luiz Augusto von Dentz