Skip to contentSkip to conversation

sched/eevdf: using leftmost improves the readability of the code

PATCH In review Liu Song 2 participants 2 messages Jan 15, 2024 Scheduler

lore
Share & tools
lore

Liu Song

author
#0 lore raw

PATCH 1/1 sched/eevdf: using leftmost improves the readability of the code

Using 'leftmost' enhances code readability, without involving any logical changes.

---
 kernel/sched/fair.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/sched/fair.c +3 -3
index f2bb83675e4a..4247584258ae 100644
@@ -848,12 +848,12 @@ struct sched_entity *__pick_root_entity(struct cfs_rq *cfs_rq)
 
 struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq)
 {
-	struct rb_node *left = rb_first_cached(&cfs_rq->tasks_timeline);
+	struct rb_node *leftmost = rb_first_cached(&cfs_rq->tasks_timeline);
 
-	if (!left)
+	if (!leftmost)
 		return NULL;
 
-	return __node_2_se(left);
+	return __node_2_se(leftmost);
 }
 
 /*
Signature · 1 line
2.19.1.6.gb485710b
#1 lore raw
Quoted 1 line · Liu Song

Using 'leftmost' enhances code readability..

Not even a little bit, it's already blatantly obvious at a glance.

Quoted 25 lines

---
 kernel/sched/fair.c | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/sched/fair.c +0 -0
index f2bb83675e4a..4247584258ae 100644
@@ -848,12 +848,12 @@ struct sched_entity *__pick_root_entity(struct cfs_rq *cfs_rq)


 struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq) {
-       struct rb_node *left = rb_first_cached(&cfs_rq->tasks_timeline); +       struct rb_node *leftmost = rb_first_cached(&cfs_rq->tasks_timeline);
-       if (!left)
+       if (!leftmost)
                return NULL;

-       return __node_2_se(left);
+       return __node_2_se(leftmost);
 }

 /*