sched/eevdf: using leftmost improves the readability of the code
PATCH 1/1 sched/eevdf: using leftmost improves the readability of the code
Using 'leftmost' enhances code readability, without involving any logical changes.
Signed-off-by Liu Song <[email protected]>
--- kernel/sched/fair.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/sched/fair.c +3 -3
@@ -848,12 +848,12 @@ struct sched_entity *__pick_root_entity(struct cfs_rq *cfs_rq)struct sched_entity *__pick_first_entity (struct cfs_rq *cfs_rq) { -struct rb_node *left =rb_first_cached (&cfs_rq->tasks_timeline); +struct rb_node *leftmost =rb_first_cached (&cfs_rq->tasks_timeline); -if (!left) +if (!leftmost)return NULL ; -return __node_2_se (left); +return __node_2_se (leftmost); }/*
Signature · 1 line
2.19.1.6.gb485710b
Quoted 1 line · Liu Song
Using 'leftmost' enhances code readability..
Not even a little bit, it's already blatantly obvious at a glance.
Quoted 25 lines
Signed-off-by Liu Song <[email protected]>---
kernel/sched/fair.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)kernel/sched/fair.c +0
-0@@ -848,12 +848,12 @@ struct sched_entity *__pick_root_entity(struct cfs_rq *cfs_rq)
structsched_entity*__pick_first_entity(structcfs_rq*cfs_rq) {
- structrb_node*left =rb_first_cached(&cfs_rq->tasks_timeline); + structrb_node*leftmost =rb_first_cached(&cfs_rq->tasks_timeline);
- if (!left)
+ if (!leftmost)
return NULL;
- return__node_2_se(left);
+ return__node_2_se(leftmost);
}
/*