Skip to contentSkip to conversation

drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

PATCH In review [email protected] 2 participants 4 messages Jan 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

From: Carsten Haitzler <[email protected]>

Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.

---
 drivers/gpu/drm/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/arm/Kconfig +1 -0
index 58a242871b28..6e3f1d600541 100644
@@ -6,6 +6,7 @@ config DRM_HDLCD
 	depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
 	depends on COMMON_CLK
 	select DRM_KMS_HELPER
+	select DRM_GEM_CMA_HELPER
 	help
 	  Choose this option if you have an ARM High Definition Colour LCD
 	  controller.
Signature · 1 line
2.30.1
#1 lore raw

Sorry - noise. Ignore this one. Following one is fixed.

Quoted 21 lines · On 1/24/22 15:13, [email protected] wrote:

From: Carsten Haitzler <[email protected]>

Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.

---
  drivers/gpu/drm/arm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/arm/Kconfig +1 -0
index 58a242871b28..6e3f1d600541 100644
@@ -6,6 +6,7 @@ config DRM_HDLCD
  	depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
  	depends on COMMON_CLK
  	select DRM_KMS_HELPER
+	select DRM_GEM_CMA_HELPER
  	help
  	  Choose this option if you have an ARM High Definition Colour LCD
  	  controller.
Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]
Quoted 5 lines · On 24/01/2022 15:13, [email protected] wrote:

From: Carsten Haitzler <[email protected]>

Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.

To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that was removed in commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select DRM_GEM_CMA_HELPER but that transitive dependency was lost and apparently the fixup was missed in that commit.

So we need a:

Fixes 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")

and with that...

Steve

Quoted 17 lines
---
 drivers/gpu/drm/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/arm/Kconfig +1 -0
index 58a242871b28..6e3f1d600541 100644
@@ -6,6 +6,7 @@ config DRM_HDLCD
 	depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
 	depends on COMMON_CLK
 	select DRM_KMS_HELPER
+	select DRM_GEM_CMA_HELPER
 	help
 	  Choose this option if you have an ARM High Definition Colour LCD
 	  controller.
#3 lore raw

I sent an updated patch with the Fixes:

Quoted 41 lines · Steven Price
Quoted 5 lines · On 24/01/2022 15:13, [email protected] wrote:

From: Carsten Haitzler <[email protected]>

Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.

To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that was removed in commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select DRM_GEM_CMA_HELPER but that transitive dependency was lost and apparently the fixup was missed in that commit.

So we need a:

Fixes 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")

and with that...

Steve

Quoted 17 lines
---
  drivers/gpu/drm/arm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/arm/Kconfig +1 -0
index 58a242871b28..6e3f1d600541 100644
@@ -6,6 +6,7 @@ config DRM_HDLCD
  	depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
  	depends on COMMON_CLK
  	select DRM_KMS_HELPER
+	select DRM_GEM_CMA_HELPER
  	help
  	  Choose this option if you have an ARM High Definition Colour LCD
  	  controller.