test-runner: Fix parsing of command line
Luiz Augusto von Dentz
maintainerPATCH 1/1 test-runner: Fix parsing of command line
From: Luiz Augusto von Dentz <[email protected]>
Instead of parsing the command line, which can contain a shell script, run using /bin/sh so it allows more complex command line to be tested:
sudo tools/test-runner -l -d -k <pathto/bzImage> -- 'client/bluetoothctl power on && sleep 2 && client/bluetoothctl power off'
--- tools/test-runner.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-)
tools/test-runner.c +7 -21
@@ -716,25 +716,7 @@ start_next: argv[0 ] = (char *) test_table[idx]; argv[1 ] ="-q" ; argv[2 ] =NULL ; - }else { -while (1 ) { -char *ptr; - - ptr =strchr (cmdname,' ' ); -if (!ptr) { - argv[pos++] = cmdname; -break ; - } - - *ptr ='\0' ; - argv[pos++] = cmdname; -if (pos >8 ) -break ; - - cmdname = ptr +1 ; - } - - argv[pos] =NULL ; + cmdname =NULL ; } pos =0 ;
@@ -743,7 +725,7 @@ start_next: envp[pos++] = home; envp[pos] =NULL ; -printf ("Running command %s\n" , argv[0 ]); +printf ("Running command %s\n" , cmdname ? cmdname : argv[0 ]); pid =fork ();if (pid <0 ) {
@@ -758,7 +740,11 @@ start_next:perror ("Failed to change directory" ); } -execve (argv[0 ], argv, envp); +if (!cmdname) +execve (argv[0 ], argv, envp); +else +execl ("/bin/sh" ,"sh" ,"-c" , cmdname,NULL ); +exit (EXIT_SUCCESS ); }
Signature · 1 line
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=619350
---Test result---
Test Summary:
CheckPatch PASS 1.54 seconds GitLint PASS 1.02 seconds Prep - Setup ELL PASS 48.50 seconds Build - Prep PASS 0.79 seconds Build - Configure PASS 9.42 seconds Build - Make PASS 1383.88 seconds Make Check PASS 12.20 seconds Make Check w/Valgrind PASS 499.39 seconds Make Distcheck PASS 262.03 seconds Build w/ext ELL - Configure PASS 10.36 seconds Build w/ext ELL - Make PASS 1368.58 seconds Incremental Build with patchesPASS 0.00 seconds
---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz
maintainerHi,
Quoted 27 lines · On Tue, Mar 1, 2022 at 4:39 PM <[email protected]> wrote:
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=619350---Test result---
Test Summary:
CheckPatch PASS 1.54 seconds GitLint PASS 1.02 seconds Prep - Setup ELL PASS 48.50 seconds Build - Prep PASS 0.79 seconds Build - Configure PASS 9.42 seconds Build - Make PASS 1383.88 seconds Make Check PASS 12.20 seconds Make Check w/Valgrind PASS 499.39 seconds Make Distcheck PASS 262.03 seconds Build w/ext ELL - Configure PASS 10.36 seconds Build w/ext ELL - Make PASS 1368.58 seconds Incremental Build with patchesPASS 0.00 seconds
Quoted 4 lines
---
Regards,
Linux Bluetooth
Pushed.
Signature · 1 line
Luiz Augusto von Dentz