Skip to contentSkip to conversation

Bluetooth: mt7921s: fix a NULL check

PATCH Applied Dan Carpenter 4 participants 6 messages Mar 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: mt7921s: fix a NULL check

There is a typo in the NULL check so it's never true. It should be checking "*ven_data" instead of "ven_data".

Fixes 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btmtksdio.c +1 -1
index f3dc5881fff7..b6d77e04240c 100644
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
 	}
 
 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
-	if (!ven_data) {
+	if (!*ven_data) {
 		err = -ENOMEM;
 		goto error;
 	}
Signature · 1 line
2.20.1
#1 lore raw

Hi Dan,
Thanks for fixing this issue, we will update patch.

-----邮件原件-----
发件人: Dan Carpenter <[email protected]>
发送时间: 2022年3月23日 15:49
收件人: Marcel Holtmann <[email protected]>; Yake Yang (杨亚克) <[email protected]>
抄送: Johan Hedberg <[email protected]>; Luiz Augusto von Dentz <[email protected]>; Matthias Brugger <[email protected]>; Sean Wang <[email protected]>; Mark Chen <[email protected]>; [email protected]; [email protected]; [email protected] 主题: [PATCH] Bluetooth: mt7921s: fix a NULL check

There is a typo in the NULL check so it's never true. It should be checking "*ven_data" instead of "ven_data".

Fixes 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btmtksdio.c +1 -1
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
 	}
 
 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
-	if (!ven_data) {
+	if (!*ven_data) {
 		err = -ENOMEM;
 		goto error;
 	}

--
2.20.1

#2 lore raw

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----
error: cannot convert from eucgb2312_cn to UTF-8
error: cannot convert from eucgb2312_cn to UTF-8
fatal: could not parse patch

Please resolve the issue and submit the patches again.

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Dan Carpenter

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:961
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.

---
Regards,
Linux Bluetooth

#4 lore raw
Quoted 7 lines · On Wed, Mar 23, 2022 at 01:49:26AM -0700, [email protected] wrote:

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

Quoted 7 lines

----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:961
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.

I tested it and it applies to:

git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master

It would help if the email said what tree the build-bot is using. Who is maintaining the build-bot?

regards,
dan carpenter

#5 lore raw
In reply to Dan Carpenter
This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Quoted 8 lines · On Wed, 23 Mar 2022 10:48:30 +0300 you wrote:

There is a typo in the NULL check so it's never true. It should be checking "*ven_data" instead of "ven_data".

Fixes 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- Bluetooth: mt7921s: fix a NULL check

    https://git.kernel.org/bluetooth/bluetooth-next/c/864cc8a234cd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html