Skip to contentSkip to conversation

libldb: work around samba libldb packaging issues

PATCH In review Armin Kuster 2 participants 8 messages Apr 4, 2019 – Apr 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libldb: work around samba libldb packaging issues

Samba and libldb overlap in a few places. This is the simplest fix for now.

Use "sssd" DISTRO_FEATUE to test and enable changes

---
 recipes-support/libldb/libldb_%.bbappend |  1 +
 recipes-support/libldb/libldb_sssd.inc   | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 recipes-support/libldb/libldb_%.bbappend
 create mode 100644 recipes-support/libldb/libldb_sssd.inc
recipes-support/libldb/libldb_%.bbappend new file +1 -0
new file mode 100644
index 0000000..bb81700
@@ -0,0 +1 @@
+require ${@bb.utils.contains('DISTRO_FEATURES', 'sssd', '${BPN}_sssd.inc', '', d)}
recipes-support/libldb/libldb_sssd.inc new file +22 -0
new file mode 100644
index 0000000..2633a1e
@@ -0,0 +1,22 @@
+# This fixes this issue:
+#ERROR: sssd-1.16.3-r0 do_prepare_recipe_sysroot: The file /usr/lib/python2.7/site-packages/_ldb_text.py is installed by both libldb and samba, aborting
+
+EXTRA_OECONF += "--disable-python"
+
+#Error: Transaction check error:
+#  file /usr/bin/ldbadd conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+#  file /usr/bin/ldbdel conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+#  file /usr/bin/ldbedit conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+#  file /usr/bin/ldbmodify conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+#  file /usr/bin/ldbrename conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+#  file /usr/bin/ldbsearch conflicts between attempted installs of samba-4.8.4-r0.cortexa15t2hf_neon_vfpv4 and libldb-1.4.1-r0.cortexa15t2hf_neon_vfpv4
+
+do_install_append() {
+   rm -f ${D}${bindir}/ldbadd
+   rm -f ${D}${bindir}/ldbdel
+   rm -f ${D}${bindir}/ldbedit
+   rm -f ${D}${bindir}/ldbmodify
+   rm -f ${D}${bindir}/ldbrename
+   rm -f ${D}${bindir}/ldbsearch
+   rmdir ${D}${bindir}
+}
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 sssd: add DISTRO_FEATURE sssd

---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +1 -1
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
 
 SSSD_UID ?= "root"
 SSSD_GID ?= "root"
Signature · 1 line
2.7.4
#2 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 10 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 6 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#3 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
Quoted 6 lines

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 5 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

Is it a naming issue or something else? I would like to understand so I may avoid making the same mistake.

- armin

Quoted 4 lines

cu
Adrian

#4 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 15 lines · On Fri, Apr 05, 2019 at 11:05:17AM +0530, akuster808 wrote:
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
Quoted 8 lines
Quoted 6 lines

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 5 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

Is it a naming issue or something else? I would like to understand so I may avoid making the same mistake.

This has nothing to do with naming.
It is about getting rid of workarounds by fixing the root cause, instead of adding more and more layers of workarounds.

A DISTRO_FEATURE is for cases where PACKAGECONFIG in many recipes should be toggled with one setting, or the setting has to be the same in several recipes.

DISTRO_FEATURES is not appropriate to guard a quick hack workaround for breakage caused by another workaround.

The problem at hand is that libldb in meta-openembedded was upgraded to a version not compatible with the version of samba in meta-openembedded.

As workaroud the libldb shipped in samba was used and installed by the samba recipe.

The proper fix would be to upgrade samba to 4.9 or 4.10, and use the external libldb again.
This would make all problems caused by having two different versions of libldb disappear.

If this is not possible, it is likely samba that should stop just shipping the (older versions of) the conflicting binaries for now.

In a semi-related note, the current samba is a pretty outdated even for the 4.8 branch and misses several CVE fixes.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#5 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 23 lines · Adrian Bunk
Quoted 14 lines · On Fri, Apr 05, 2019 at 11:05:17AM +0530, akuster808 wrote:
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
Quoted 8 lines
Quoted 6 lines

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 5 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

Is it a naming issue or something else? I would like to understand so I may avoid making the same mistake.

Quoted 7 lines

This has nothing to do with naming.
It is about getting rid of workarounds by fixing the root cause, instead of adding more and more layers of workarounds.

A DISTRO_FEATURE is for cases where PACKAGECONFIG in many recipes should be toggled with one setting, or the setting has to be the same in several recipes.

The definition is old and needs to be updated to modern time. There a plenty of recipes that require libraries the we ended up using this mechanism. Look at the X11 situations. The sssd requires PAM but there is no PAM config option supported in the recipe so I should remove PAM to then?

Quoted 3 lines

DISTRO_FEATURES is not appropriate to guard a quick hack workaround for breakage caused by another workaround.

Its being used in the case of mali support.  So I do see value in able to use this mechanism in those cases.

I do have another option and that is to supply the previous libldb. This I know is standard practice for other layers.

Quoted 3 lines

The problem at hand is that libldb in meta-openembedded was upgraded to a version not compatible with the version of samba in meta-openembedded.

And that should not have been allowed IMHO.  What is even worse, one can not install libldb onto a system without seen the same issues so it appears no one is using it.

Quoted 9 lines

As workaroud the libldb shipped in samba was used and installed by the samba recipe.

The proper fix would be to upgrade samba to 4.9 or 4.10, and use the external libldb again.
This would make all problems caused by having two different versions of libldb disappear.

Quoted 5 lines

If this is not possible, it is likely samba that should stop just shipping the (older versions of) the conflicting binaries for now.

In a semi-related note, the current samba is a pretty outdated even for the 4.8 branch and misses several CVE fixes.

Make you wonder if folks are using samba.
- armin

Quoted 4 lines

cu
Adrian

#6 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 30 lines · On Sat, Apr 06, 2019 at 05:54:35AM +0530, akuster808 wrote:
Quoted 27 lines · Adrian Bunk
Quoted 14 lines · On Fri, Apr 05, 2019 at 11:05:17AM +0530, akuster808 wrote:
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
Quoted 8 lines
Quoted 6 lines

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 5 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

Is it a naming issue or something else? I would like to understand so I may avoid making the same mistake.

This has nothing to do with naming.
It is about getting rid of workarounds by fixing the root cause, instead of adding more and more layers of workarounds.

Quoted 8 lines
Quoted 3 lines

A DISTRO_FEATURE is for cases where PACKAGECONFIG in many recipes should be toggled with one setting, or the setting has to be the same in several recipes.

The definition is old and needs to be updated to modern time. There a plenty of recipes that require libraries the we ended up using this mechanism. Look at the X11 situations. The sssd requires PAM but there is no PAM config option supported in the recipe so I should remove PAM to then?

X11 and PAM are low-level libraries.

A user might choose to build a distribution without X11 support or without PAM support, and there is no better solution for this.

It is not intended for temporary quick hacks.

Quoted 4 lines
Quoted 2 lines

DISTRO_FEATURES is not appropriate to guard a quick hack workaround for breakage caused by another workaround.

Its being used in the case of mali support.  So I do see value in able to use this mechanism in those cases.

What are you referring to here?

Quoted 2 lines

I do have another option and that is to supply the previous libldb. This I know is standard practice for other layers.

I actually wonder why sssd currently requires libldb, it does not DEPEND on it so is not built against it.

Quoted 4 lines
Quoted 2 lines

The problem at hand is that libldb in meta-openembedded was upgraded to a version not compatible with the version of samba in meta-openembedded.

And that should not have been allowed IMHO.

0001-ldb-Refuse-to-build-Samba-against-a-newer-minor-vers.patch in samba seems to have been added to prevent exactly this in the future.

Quoted 3 lines

What is even worse, one can
not install libldb onto a system without seen the same issues so it appears no one is using it.

samba uses the internal version and for sssd it is a non-default PACKAGECONFIG.

Quoted 8 lines
Quoted 8 lines

As workaroud the libldb shipped in samba was used and installed by the samba recipe.

The proper fix would be to upgrade samba to 4.9 or 4.10, and use the external libldb again.
This would make all problems caused by having two different versions of libldb disappear.

Quoted 6 lines
Quoted 5 lines

If this is not possible, it is likely samba that should stop just shipping the (older versions of) the conflicting binaries for now.

In a semi-related note, the current samba is a pretty outdated even for the 4.8 branch and misses several CVE fixes.

Make you wonder if folks are using samba.

using != maintaining

Users tend to use whatever is provided by a stable series, and trust that this is properly security supported.

They cannot even notice that samba has not been updated for warrior before warrior becomes a stable series and they start using it.

Creating an automated regular report based on cve_check for master and all supported stable series for several layers might be easy enough.

Currently the output would be depressing for master and worse for stable branches.

Actually providing security support by providing properly tested fixes for master and 2 supported stable series would be full-time work for several people.

Quoted 1 line

- armin

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#7 lore raw

Re: [meta-security][PATCH 2/2] sssd: add DISTRO_FEATURE sssd

Quoted 46 lines · Adrian Bunk
Quoted 28 lines · On Sat, Apr 06, 2019 at 05:54:35AM +0530, akuster808 wrote:
Quoted 26 lines · Adrian Bunk
Quoted 13 lines · On Fri, Apr 05, 2019 at 11:05:17AM +0530, akuster808 wrote:
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Armin Kuster
---
 recipes-security/sssd/sssd_1.16.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-security/sssd/sssd_1.16.4.bb +0 -0
index 34bc8c8..d6a308c 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f
 
Quoted 8 lines
Quoted 6 lines

recipes-security/sssd/sssd_1.16.4.bb SRC_URI[sha256sum] = "6bb212cd6b75b918e945c24e7c3f95a486fb54d7f7d489a9334cfa1a1f · line 19

Quoted 5 lines
recipes-security/sssd/sssd_1.16.4.bb +1 -1
 inherit autotools pkgconfig gettext python-dir distro_features_check
 
-REQUIRED_DISTRO_FEATURES = "pam"
+REQUIRED_DISTRO_FEATURES = "pam sssd"
...

Adding a distro feature for a leaf package is wrong.

Is it a naming issue or something else? I would like to understand so I may avoid making the same mistake.

This has nothing to do with naming.
It is about getting rid of workarounds by fixing the root cause, instead of adding more and more layers of workarounds.

Quoted 8 lines
Quoted 3 lines

A DISTRO_FEATURE is for cases where PACKAGECONFIG in many recipes should be toggled with one setting, or the setting has to be the same in several recipes.

The definition is old and needs to be updated to modern time. There a plenty of recipes that require libraries the we ended up using this mechanism. Look at the X11 situations. The sssd requires PAM but there is no PAM config option supported in the recipe so I should remove PAM to then?

X11 and PAM are low-level libraries.

A user might choose to build a distribution without X11 support or without PAM support, and there is no better solution for this.

It is not intended for temporary quick hacks.

Quoted 2 lines
Quoted 2 lines

DISTRO_FEATURES is not appropriate to guard a quick hack workaround for breakage caused by another workaround.

Quoted 8 lines
Quoted 2 lines

Its being used in the case of mali support.  So I do see value in able to use this mechanism in those cases.

What are you referring to here?

Quoted 2 lines

I do have another option and that is to supply the previous libldb. This I know is standard practice for other layers.

I actually wonder why sssd currently requires libldb, it does not DEPEND on it so is not built against it.

Its hard coded in the configure. it is in the DEPENDs list in the recipe.

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

The problem at hand is that libldb in meta-openembedded was upgraded to a version not compatible with the version of samba in meta-openembedded.

And that should not have been allowed IMHO.

Quoted 8 lines

0001-ldb-Refuse-to-build-Samba-against-a-newer-minor-vers.patch in samba seems to have been added to prevent exactly this in the future.

Quoted 3 lines

What is even worse, one can
not install libldb onto a system without seen the same issues so it appears no one is using it.

samba uses the internal version and for sssd it is a non-default PACKAGECONFIG.

Correct.

Quoted 26 lines
Quoted 9 lines
Quoted 9 lines

As workaroud the libldb shipped in samba was used and installed by the samba recipe.

The proper fix would be to upgrade samba to 4.9 or 4.10, and use the external libldb again.
This would make all problems caused by having two different versions of libldb disappear.

Quoted 6 lines
Quoted 5 lines

If this is not possible, it is likely samba that should stop just shipping the (older versions of) the conflicting binaries for now.

In a semi-related note, the current samba is a pretty outdated even for the 4.8 branch and misses several CVE fixes.

Make you wonder if folks are using samba.

using != maintaining

Users tend to use whatever is provided by a stable series, and trust that this is properly security supported.

They cannot even notice that samba has not been updated for warrior before warrior becomes a stable series and they start using it.

Creating an automated regular report based on cve_check for master and all supported stable series for several layers might be easy enough.

Quoted 6 lines

Currently the output would be depressing for master and worse for stable branches.

Actually providing security support by providing properly tested fixes for master and 2 supported stable series would be full-time work for several people.

yep.  Late we have had 3 stable for a short period while the oldest on gets it last dot release.

Thanks for you input and feedback

kind regards,
- Armin

Quoted 5 lines
Quoted 2 lines

- armin

cu
Adrian