Skip to contentSkip to conversation

Add mbedtls to PKGMODULES

PATCH In review Anton Lundin 2 participants 4 messages Jun 1 – Jun 5

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add mbedtls to PKGMODULES

When cryptsetup is built with --with-crypto_backend=mbedtls, the pkg-config file for libcryptsetup should include mbedtls.

---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +1 -0
index 52ddf11b..260b0ab6 100644
@@ -741,6 +741,7 @@ case $with_crypto_backend in
 	openssl) PKGMODULES="$PKGMODULES openssl" ;;
 	nss)     PKGMODULES="$PKGMODULES nss" ;;
 	nettle)  PKGMODULES="$PKGMODULES nettle" ;;
+	mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
 esac
 if test "x$enable_libargon2" = "xyes"; then
 	PKGMODULES="$PKGMODULES libargon2"
Signature · 1 line
2.47.3
#1 lore raw

Hi,

I added the patch to MR for review
https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931

Thanks,
Milan

Quoted 18 lines · Anton Lundin

When cryptsetup is built with --with-crypto_backend=mbedtls, the pkg-config file for libcryptsetup should include mbedtls.

---
  configure.ac | 1 +
  1 file changed, 1 insertion(+)
configure.ac +1 -0
index 52ddf11b..260b0ab6 100644
@@ -741,6 +741,7 @@ case $with_crypto_backend in
  	openssl) PKGMODULES="$PKGMODULES openssl" ;;
  	nss)     PKGMODULES="$PKGMODULES nss" ;;
  	nettle)  PKGMODULES="$PKGMODULES nettle" ;;
+	mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
  esac
  if test "x$enable_libargon2" = "xyes"; then
  	PKGMODULES="$PKGMODULES libargon2"
#2 lore raw
Quoted 5 lines · On 02 juni, 2026 - Milan Broz wrote:

Hi,

I added the patch to MR for review
https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931

I was trying to figure out what the projects workflow was, and it looked like there were both patches on the mailing list and MR's on gitlab, and due to me not having a gitlab account since earlier it was just easier to send it to the ML.

Thanks for the review and merging the code.

//Anton

Quoted 19 lines · Anton Lundin
Quoted 18 lines

When cryptsetup is built with --with-crypto_backend=mbedtls, the pkg-config file for libcryptsetup should include mbedtls.

---
  configure.ac | 1 +
  1 file changed, 1 insertion(+)
configure.ac +1 -0
index 52ddf11b..260b0ab6 100644
@@ -741,6 +741,7 @@ case $with_crypto_backend in
  	openssl) PKGMODULES="$PKGMODULES openssl" ;;
  	nss)     PKGMODULES="$PKGMODULES nss" ;;
  	nettle)  PKGMODULES="$PKGMODULES nettle" ;;
+	mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
  esac
  if test "x$enable_libargon2" = "xyes"; then
  	PKGMODULES="$PKGMODULES libargon2"
#3 lore raw
Quoted 4 lines · Anton Lundin
Quoted 2 lines · On 02 juni, 2026 - Milan Broz wrote:

Hi,

Quoted 8 lines
Quoted 3 lines

I added the patch to MR for review
https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931

I was trying to figure out what the projects workflow was, and it looked like there were both patches on the mailing list and MR's on gitlab, and due to me not having a gitlab account since earlier it was just easier to send it to the ML.

Just for info (but I guess you already read that), workflow is documented here

https://gitlab.com/cryptsetup/cryptsetup/-/blob/main/CONTRIBUTING.md

Milan