bluetooth.service: Set StateDirectoryMode
Luiz Augusto von Dentz
maintainerPATCH 1/2 bluetooth.service: Set StateDirectoryMode
From: Luiz Augusto von Dentz <[email protected]>
This sets StateDirectoryMode to 0700 as it is the current mode used for creating files inside the storage and it is different than the default systemd uses which is 0755:
[1] https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectoryMode=
--- src/bluetooth.service.in | 1 + 1 file changed, 1 insertion(+)
src/bluetooth.service.in +1 -0
@@ -20,6 +20,7 @@ PrivateTmp=true ProtectKernelTunables=true ProtectControlGroups=true StateDirectory=bluetooth +StateDirectoryMode=0700 ConfigurationDirectory=bluetooth # Execute Mappings
Signature · 1 line
2.35.1
Luiz Augusto von Dentz
maintainerPATCH 2/2 bluetooth.service: Set ConfigurationDirectoryMode
From: Luiz Augusto von Dentz <[email protected]>
This sets ConfigurationDirectoryMode to 0555 to really enforce the ConfigurationDirectory to be read-only [1].
[1] https://github.com/bluez/bluez/issues/329#issuecomment-1102459104
--- src/bluetooth.service.in | 1 + 1 file changed, 1 insertion(+)
src/bluetooth.service.in +1 -0
@@ -22,6 +22,7 @@ ProtectControlGroups=true StateDirectory=bluetooth StateDirectoryMode=0700 ConfigurationDirectory=bluetooth +ConfigurationDirectoryMode=0555 # Execute Mappings MemoryDenyWriteExecute=true
Signature · 1 line
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=633488
---Test result---
Test Summary:
CheckPatch FAIL 1.24 seconds GitLint FAIL 0.89 seconds Prep - Setup ELL PASS 50.22 seconds Build - Prep PASS 0.62 seconds Build - Configure PASS 9.80 seconds Build - Make PASS 1740.83 seconds Make Check PASS 12.41 seconds Make Check w/Valgrind PASS 530.59 seconds Make Distcheck PASS 274.43 seconds Build w/ext ELL - Configure PASS 9.91 seconds Build w/ext ELL - Make PASS 1705.33 seconds Incremental Build with patchesPASS 3479.72 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,1/2] bluetooth.service: Set StateDirectoryMode
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #84:
[1] https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectoryMode=
/github/workspace/src/12819297.patch total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12819297.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ,1/2] bluetooth.service: Set StateDirectoryMode
9: B1 Line exceeds max length (92>80): "[1] https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectoryMode="
---
Regards,
Linux Bluetooth
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Tue, 19 Apr 2022 11:22:36 -0700 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
This sets StateDirectoryMode to 0700 as it is the current mode used for creating files inside the storage and it is different than the default systemd uses which is 0755:
[1] https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectoryMode=
[...]
Here is the summary with links:
- [BlueZ,1/2] bluetooth.service: Set StateDirectoryMode
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=edc69d253445 - [BlueZ,2/2] bluetooth.service: Set ConfigurationDirectoryMode https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=00cfb36e20e3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html