Skip to contentSkip to conversation

m68k: add support for TIF_NOTIFY_SIGNAL

PATCH In review Jens Axboe 2 participants 3 messages Oct 29, 2020 – Oct 30, 2020 m68k architecture

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

PATCH 1/1 m68k: add support for TIF_NOTIFY_SIGNAL

Wire up TIF_NOTIFY_SIGNAL handling for m68k.

---

5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting for details:

https://lore.kernel.org/io-uring/[email protected]/

As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.

 arch/m68k/include/asm/thread_info.h | 1 +
 arch/m68k/kernel/signal.c           | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
arch/m68k/include/asm/thread_info.h +1 -0
index 3689c6718c88..15a757073fa5 100644
@@ -60,6 +60,7 @@ static inline struct thread_info *current_thread_info(void)
  * bits 0-7 are tested at every exception exit
  * bits 8-15 are also tested at syscall exit
  */
+#define TIF_NOTIFY_SIGNAL	4
 #define TIF_NOTIFY_RESUME	5	/* callback before returning to user */
 #define TIF_SIGPENDING		6	/* signal pending */
 #define TIF_NEED_RESCHED	7	/* rescheduling necessary */
arch/m68k/kernel/signal.c +2 -1
index 46f91e0f6a08..349570f16a78 100644
@@ -1133,7 +1133,8 @@ static void do_signal(struct pt_regs *regs)
 
 void do_notify_resume(struct pt_regs *regs)
 {
-	if (test_thread_flag(TIF_SIGPENDING))
+	if (test_thread_flag(TIF_NOTIFY_SIGNAL) ||
+	    test_thread_flag(TIF_SIGPENDING))
 		do_signal(regs);
 
 	if (test_thread_flag(TIF_NOTIFY_RESUME))
Signature · 4 lines
2.29.0

-- 
Jens Axboe
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Jens,

Quoted 4 lines · Jens Axboe

Wire up TIF_NOTIFY_SIGNAL handling for m68k.

Thanks for your patch!

Quoted 9 lines

5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting for details:

https://lore.kernel.org/io-uring/[email protected]/

As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.

hence please pick it up. Thx!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author
#2 lore raw
Quoted 15 lines · Geert Uytterhoeven

Hi Jens,

Quoted 4 lines · Jens Axboe

Wire up TIF_NOTIFY_SIGNAL handling for m68k.

Thanks for your patch!

Quoted 5 lines

5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting for details:

https://lore.kernel.org/io-uring/[email protected]/

Quoted 7 lines
Quoted 4 lines

As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs, as that will enable a set of cleanups once all of them support it. I'm happy carrying this patch if need be, or it can be funelled through the arch tree. Let me know.

hence please pick it up. Thx!

Thanks Geert! Added.

Signature · 1 line
Jens Axboe