cpuidle: clps711x: convert to devm_platform_ioremap_resource
PATCH 1/1 cpuidle: clps711x: convert to devm_platform_ioremap_resource
Use devm_platform_ioremap_resource() to simplify code.
--- drivers/cpuidle/cpuidle-clps711x.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/cpuidle/cpuidle-clps711x.c +1 -4
@@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {static int __init clps711x_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - clps711x_halt =devm_ioremap_resource (&pdev->dev, res); + clps711x_halt =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (clps711x_halt))return PTR_ERR (clps711x_halt);
Signature · 1 line
2.17.1
PATCH 1/2 cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Use devm_platform_ioremap_resource() to simplify code.
--- drivers/cpuidle/cpuidle-kirkwood.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/cpuidle/cpuidle-kirkwood.c +1 -4
@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {/* Initialize CPU idle by registering the idle states */ static int kirkwood_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - ddr_operation_base =devm_ioremap_resource (&pdev->dev, res); + ddr_operation_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (ddr_operation_base))return PTR_ERR (ddr_operation_base);
Signature · 1 line
2.17.1
Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Quoted 3 lines · Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>
Andrew
Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
In reply to Yangtao LiQuoted 14 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-kirkwood.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-kirkwood.c +0
-0@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {/* Initialize CPU idle by registering the idle states */
drivers/cpuidle/cpuidle-kirkwood.c static struct cpuidle_driver kirkwood_idle_driver = { · line 61
Quoted 10 lines
drivers/cpuidle/cpuidle-kirkwood.c +1
-4static int kirkwood_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - ddr_operation_base =devm_ioremap_resource (&pdev->dev, res); + ddr_operation_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (ddr_operation_base))return PTR_ERR (ddr_operation_base);
Daniel, any concerns here?
Daniel Lezcano
Acked-byRe: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-kirkwood.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-kirkwood.c +0
-3@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {/* Initialize CPU idle by registering the idle states */ static int kirkwood_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );
Quoted 8 lines
drivers/cpuidle/cpuidle-kirkwood.c static struct cpuidle_driver kirkwood_idle_driver = { · line 61
Quoted 6 lines
drivers/cpuidle/cpuidle-kirkwood.c +1
-1- ddr_operation_base =devm_ioremap_resource (&pdev->dev, res); + ddr_operation_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (ddr_operation_base))return PTR_ERR (ddr_operation_base);Daniel, any concerns here?
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Rafael J. Wysocki
AppliedRe: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
In reply to Yangtao LiQuoted 14 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-kirkwood.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-kirkwood.c +0
-0@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {/* Initialize CPU idle by registering the idle states */
drivers/cpuidle/cpuidle-kirkwood.c static struct cpuidle_driver kirkwood_idle_driver = { · line 61
Quoted 10 lines
drivers/cpuidle/cpuidle-kirkwood.c +1
-4static int kirkwood_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - ddr_operation_base =devm_ioremap_resource (&pdev->dev, res); + ddr_operation_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (ddr_operation_base))return PTR_ERR (ddr_operation_base);
Applied as 5.6 material, thanks!
Quoted 14 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-clps711x.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-clps711x.c +0
-0@@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
drivers/cpuidle/cpuidle-clps711x.c static struct cpuidle_driver clps711x_idle_driver = { · line 43
Quoted 10 lines
drivers/cpuidle/cpuidle-clps711x.c +1
-4static int __init clps711x_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - clps711x_halt =devm_ioremap_resource (&pdev->dev, res); + clps711x_halt =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (clps711x_halt))return PTR_ERR (clps711x_halt);
Daniel, any concerns here?
Daniel Lezcano
Acked-byQuoted 14 lines · Rafael J. Wysocki
Quoted 13 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-clps711x.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-clps711x.c +0
-0@@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
Quoted 13 lines
drivers/cpuidle/cpuidle-clps711x.c static struct cpuidle_driver clps711x_idle_driver = { · line 43
Quoted 11 lines
drivers/cpuidle/cpuidle-clps711x.c +1
-4static int __init clps711x_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - clps711x_halt =devm_ioremap_resource (&pdev->dev, res); + clps711x_halt =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (clps711x_halt))return PTR_ERR (clps711x_halt);Daniel, any concerns here?
I'm fine with those changes also. Maybe a bit more elaborated changelog, but not sure it is worth to resend a new patch for that. May be you can just update it with an answer and Rafael can take it into account.
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Rafael J. Wysocki
AppliedQuoted 14 lines · CET Yangtao Li
Use
devm_platform_ioremap_resource()to simplify code.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpuidle/cpuidle-clps711x.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/cpuidle/cpuidle-clps711x.c +0
-0@@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
drivers/cpuidle/cpuidle-clps711x.c static struct cpuidle_driver clps711x_idle_driver = { · line 43
Quoted 10 lines
drivers/cpuidle/cpuidle-clps711x.c +1
-4static int __init clps711x_cpuidle_probe (struct platform_device *pdev) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - clps711x_halt =devm_ioremap_resource (&pdev->dev, res); + clps711x_halt =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (clps711x_halt))return PTR_ERR (clps711x_halt);
Applied as 5.6 material, thanks!